Re: [9] Review request: JDK-8129595: New DTLS tests need @modules

2015-06-24 Thread Alexander Kulyakhtin
:30 PM GMT +03:00 Iraq Subject: Re: [9] Review request: JDK-8129595: New DTLS tests need @modules On 24/06/2015 16:40, Konstantin Shefov wrote: > Hi Alan, > > Please review updated patch. I made it using the tool Alexander > Kulyakhtin has given me. > > http://cr.openjdk.java.ne

Re: [9] Review request: JDK-8129595: New DTLS tests need @modules

2015-06-24 Thread Alexander Kulyakhtin
Please review updated patch. I made it using the tool Alexander > Kulyakhtin has given me. > > http://cr.openjdk.java.net/~kshefov/8129595/webrev.01/ This looks okay to me. Thanks for sorting this out. -Alan

Re: [9] Review request: JDK-8129595: New DTLS tests need @modules

2015-06-24 Thread Alexander Kulyakhtin
quot; and the > TEST.properties file just like one suggested in this fix. > If yes, it is not worth changing TEST.properties any more. Alexander Kulyakhtin has been working on a tool that uses jdeps to get the dependences of each test. It's not in OpenJDK yet but I'm sure he can

Re: [9] Review request: JDK-8129595: New DTLS tests need @modules

2015-06-24 Thread Alexander Kulyakhtin
ile just like one suggested in this fix. > If yes, it is not worth changing TEST.properties any more. Alexander Kulyakhtin has been working on a tool that uses jdeps to get the dependences of each test. It's not in OpenJDK yet but I'm sure he can help you get the @modules right for these tests. -Alan

Re: Changes for JDK-8075327: moving jdk testlibraty files duplicated in hotspot to the common test repository

2015-05-13 Thread Alexander Kulyakhtin
tspot-...@openjdk.java.net, jdk9-...@openjdk.java.net Sent: Wednesday, May 13, 2015 7:48:06 PM GMT +03:00 Iraq Subject: Re: Changes fro JDK-8075327: moving jdk testlibraty files duplicated in hotspot to the common test repository Alexander, > On 13 May 2015, at 16:46, Alexander Kulyakhtin

Re: Changes fro JDK-8075327: moving jdk testlibraty files duplicated in hotspot to the common test repository

2015-05-13 Thread Alexander Kulyakhtin
Hi Chris, > I suspect that these changes are best going directly into jdk9/dev, as > opposed to a a downstream forest. Yes, they are going directly to jdk9/dev, I forgot to add the group, adding now. > In may places '@library /lib/testlibrary ...' remains. Is this > redundant, in many tests? I

Changes fro JDK-8075327: moving jdk testlibraty files duplicated in hotspot to the common test repository

2015-05-13 Thread Alexander Kulyakhtin
Hi, Could you please, review the following tests-only changes to the hs-rt/jdk and hs-rt/test repositories. These changes are a part of the changes for "JDK-8075327: Merge jdk and hotspot test libraries" The changes are as follows: http://cr.openjdk.java.net/~akulyakh/8075327/jdk_patch/webrev/

Re: Changes fro JDK-8075327: moving jdk testlibraty files duplicated in hotspot to the common test repository

2015-05-13 Thread Alexander Kulyakhtin
Adding jdk9-dev mailing list - Original Message - From: alexander.kulyakh...@oracle.com To: core-libs-dev@openjdk.java.net, awt-...@openjdk.java.net, hotspot-...@openjdk.java.net Cc: stefan.sa...@oracle.com, yekaterina.kantser...@oracle.com, alan.bate...@oracle.com Sent: Wednesday, May 1