Re: RFR 8043954: Fix behavior difference of connect() for AIX

2014-06-06 Thread Jonathan Lu
Hi Alan, On Fri, Jun 6, 2014 at 1:53 AM, Alan Bateman alan.bate...@oracle.com wrote: On 05/06/2014 11:37, Jonathan Lu wrote: If getsockopt(SO_ERROR) failed, I did not find any explicit docs about the behavior. but as I tested with some C code snippet, the value of sockopt_arg would

Re: RFR 8043954: Fix behavior difference of connect() for AIX

2014-06-06 Thread Jonathan Lu
tests without specific issues. So thumbs up from me! Regards, Volker On Fri, Jun 6, 2014 at 12:03 PM, Jonathan Lu luc...@linux.vnet.ibm.com wrote: Hi Alan, On Fri, Jun 6, 2014 at 1:53 AM, Alan Bateman alan.bate...@oracle.com wrote: On 05/06/2014 11:37, Jonathan Lu wrote

Re: RFR 8043954: Fix behavior difference of connect() for AIX

2014-06-05 Thread Jonathan Lu
Hi Alan, On Wed, Jun 4, 2014 at 9:16 PM, Alan Bateman alan.bate...@oracle.com wrote: On 04/06/2014 07:31, Jonathan Lu wrote: Hi Volker, Thanks for your comment! an updated webrev was made at http://cr.openjdk.java.net/~luchsh/JDK-8043954.2/ Would it make sense to set errno

Re: RFR 8043954: Fix behavior difference of connect() for AIX

2014-06-04 Thread Jonathan Lu
regards, Volker On Tue, Jun 3, 2014 at 11:51 AM, Jonathan Lu luc...@linux.vnet.ibm.com wrote: Hello, Could I have following patch reviewed for bug 8034954 ? http://cr.openjdk.java.net/~luchsh/JDK-8043954/ The patch is to fix a behavior difference of connect() API for AIX platform

RFR 8043954: Fix behavior difference of connect() for AIX

2014-06-03 Thread Jonathan Lu
Hello, Could I have following patch reviewed for bug 8034954 ? http://cr.openjdk.java.net/~luchsh/JDK-8043954/ The patch is to fix a behavior difference of connect() API for AIX platform, according to the documentation,

Re: RFR JDK-8043495: add native FileChannelImpl.transferTo0() implementation for AIX

2014-05-27 Thread Jonathan Lu
Hi Alan, Thank you for the comments, here's the updated webrev, http://cr.openjdk.java.net/~luchsh/JDK-8043495-2/ On Mon, May 26, 2014 at 6:09 PM, Alan Bateman alan.bate...@oracle.comwrote: On 26/05/2014 10:04, Jonathan Lu wrote: Hello, May I have following patch reviewed ? http

Re: RFR JDK-8043495: add native FileChannelImpl.transferTo0() implementation for AIX

2014-05-27 Thread Jonathan Lu
Thanks, Alan and Volker! I will push this change. Regards, Jonathan On Tue, May 27, 2014 at 5:00 PM, Alan Bateman alan.bate...@oracle.comwrote: On 27/05/2014 09:49, Volker Simonis wrote: : 'send_file()' is declared in 'sys/socket.h' on AIX, so we need it. Thanks, just checking. :

RFR JDK-8043495: add native FileChannelImpl.transferTo0() implementation for AIX

2014-05-26 Thread Jonathan Lu
Hello, May I have following patch reviewed ? http://cr.openjdk.java.net/~luchsh/JDK-8043495/ The patch will add native FileChannelImpl.transferTo0() implementation for AIX by using the 'send_file' API,

Re: i18n dev Improve timezone mapping for AIX platform

2014-04-15 Thread Jonathan Lu
think that's a big deal as this only touches AX code. Thank you and best regards, Volker On Thu, Apr 10, 2014 at 11:44 AM, Jonathan Lu luc...@linux.vnet.ibm.comwrote: Hi Volker, Thanks a lot for your comments, I've made another patch, http://cr.openjdk.java.net/~luchsh/JDK

Re: i18n dev Improve timezone mapping for AIX platform

2014-04-10 Thread Jonathan Lu
regards, Volker On Fri, Apr 4, 2014 at 10:18 AM, Jonathan Lu luc...@linux.vnet.ibm.com wrote: Hi Volker, Masayoshi, I made another patch which fixed the problems mentioned in last mail, http://cr.openjdk.java.net/~luchsh/JDK-8034220.v3/ Could you pls help to take a look? Many

Re: Improve timezone mapping for AIX platform

2014-04-02 Thread Jonathan Lu
Hi Volker, On 2014年04月02日 23:07, Volker Simonis wrote: Hi Jonathan, thanks for updating the change. Please find my comments inline: On Tue, Apr 1, 2014 at 4:52 PM, Jonathan Lu luc...@linux.vnet.ibm.com luc...@linux.vnet.ibm.com wrote: Hi Volker, Masayoshi, Thanks a lot for your review

Re: Improve timezone mapping for AIX platform

2014-04-01 Thread Jonathan Lu
a function for producing a fallback ID in GMT±hh:mm, getGMTOffsetID() which can be called in tzerr. Thanks, Masayoshi On 3/26/2014 3:47 PM, Jonathan Lu wrote: Hi ppc-aix-port-dev, core-libs-dev, Here's a patch for JDK-8034220, http://cr.openjdk.java.net/~luchsh/JDK-8034220

Improve timezone mapping for AIX platform

2014-03-26 Thread Jonathan Lu
Hi ppc-aix-port-dev, core-libs-dev, Here's a patch for JDK-8034220, http://cr.openjdk.java.net/~luchsh/JDK-8034220/ It is trying to add the a more complete timezone mapping mechanism for AIX platform. the changes are primarily based on IBM's commercial JDK code, which includes: - A new

Re: Add IDN support to existing net APIs

2014-02-19 Thread Jonathan Lu
of the work. Michael. Copying core-libs-dev and security-dev to get more comments. Many thanks - Jonathan [1] http://www.ietf.org/rfc/rfc2396.txt On 19/02/14 04:00, Jonathan Lu wrote: Hi net-dev, If a Java application tries to support International Domain Names (IDN) [1], which was firstly

Re: RFR: 8019381: HashMap.isEmpty is non-final, potential issues for get/remove

2013-07-04 Thread Jonathan Lu
On 07/03/2013 11:04 AM, Shi Jun Zhang wrote: On 7/1/2013 11:49 PM, Chris Hegarty wrote: On 1 Jul 2013, at 17:22, Remi Forax fo...@univ-mlv.fr wrote: On 07/01/2013 09:43 AM, Shi Jun Zhang wrote: On 6/29/2013 12:05 AM, Shi Jun Zhang wrote: On 6/28/2013 9:02 PM, Alan Bateman wrote: On

Re: 7099119: Remove unused dlinfo local variable in launcher code

2012-11-30 Thread Jonathan Lu
On 11/30/2012 03:10 PM, Shi Jun wrote: On 11/29/2012 6:40 PM, Alan Bateman wrote: On 29/11/2012 07:17, Shi Jun wrote: Hi all, Previously 7099119 is fixed in the following changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd55467dd1f2, but this change is lost during the Mac port merging

Re: Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract

2012-11-13 Thread Jonathan Lu
Hi Sean, Patch pushed @ http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83765e82cacb Could you please verify? Thanks regards Jonathan On 11/14/2012 10:23 AM, Sean Chou wrote: Thanks Alan and Chris. On Tue, Nov 13, 2012 at 7:21 PM, Chris Hegarty chris.hega...@oracle.comwrote: Sean, Looks good

Re: Code review request 7190219 CharBuffer position changed after BufferOverflowException in put()

2012-08-13 Thread Jonathan Lu
Hello Alan, Thanks for reviewing, I've updated the webrev, could you please take a look? http://cr.openjdk.java.net/~luchsh/7190219_2/ On 08/09/2012 09:28 PM, Alan Bateman wrote: On 09/08/2012 13:16, Jonathan Lu wrote: Hi folks, Here's a patch for bug 7190219, could you please help to have

Code review request 7190219 CharBuffer position changed after BufferOverflowException in put()

2012-08-09 Thread Jonathan Lu
Hi folks, Here's a patch for bug 7190219, could you please help to have a look? http://cr.openjdk.java.net/~luchsh/7190219/ According to the specification, in the method java.nio.CharBuffer.put(String src, int start, int end). If there are more chars to be copied from the string than remain in

Re: Time format in jar and jarsigner output (was Re: Code review request: 7163483 JarSigner -verify -verbose does not format date string according to locale)

2012-07-11 Thread Jonathan Lu
(xueming.s...@oracle.com) owns the jar tool. I've included sun.tools.jar.Main in the latest patch and CCed Sherman. Could you please help to take another look? Many thanks Jonathan Thanks Max On 07/09/2012 03:24 PM, Jonathan Lu wrote: Hi Max, Thanks for reviewing. On 07/06/2012 06:27 PM, Weijun

Re: Time format in jar and jarsigner output (was Re: Code review request: 7163483 JarSigner -verify -verbose does not format date string according to locale)

2012-07-11 Thread Jonathan Lu
the initialization is quite heavy. You recently became a jdk8 committer, right? That means you can do your own push but if you want to make any changes to the bug database, just tell me. Thanks Max On 07/11/2012 02:07 PM, Jonathan Lu wrote: Hello Max, Thanks a lot for review, here's

Re: Problem of using malloc() without including stdlib.h

2012-02-03 Thread Jonathan Lu
like to see any changes to those files, and the reasoning discussed on 2d-dev .. -phil. On 1/18/2012 8:26 AM, Kelly O'Hair wrote: On Jan 18, 2012, at 12:19 AM, Jonathan Lu wrote: Hi core-libs-dev, I found that for some native code of OpenJDK code base, malloc() is used without including

Re: POSIX compatibility change for including wait.h in UNIXProcess_md.c

2012-01-31 Thread Jonathan Lu
On 01/31/2012 06:40 PM, Neil Richards wrote: On Thu, 2012-01-26 at 17:45 +0800, Jonathan Lu wrote: I think we forgot to create a bug for this, I've created it now: 7133301: (process) UNIXProcess_md.c should include sys/wait.h rather than wait.h Thanks

Re: POSIX compatibility change for including wait.h in UNIXProcess_md.c

2012-01-26 Thread Jonathan Lu
I think we forgot to create a bug for this, I've created it now: 7133301: (process) UNIXProcess_md.c should include sys/wait.h rather than wait.h Thanks a lot, Alan! I don't mind pushing it for you but maybe this is something that Neil wants to do? Hi Neil, could you please help to

Re: Problem of using malloc() without including stdlib.h

2012-01-18 Thread Jonathan Lu
On 01/18/2012 04:31 PM, Alan Bateman wrote: On 18/01/2012 08:19, Jonathan Lu wrote: Hi core-libs-dev, I found that for some native code of OpenJDK code base, malloc() is used without including header file stdlib.h, such as following files, ./src/solaris/native/sun/java2d/opengl

Re: POSIX compatibility change for including wait.h in UNIXProcess_md.c

2012-01-12 Thread Jonathan Lu
Hello David and Alan, Thanks for the review. Do you plan to push it? Cheers - Jonathan On 01/12/2012 07:33 PM, Alan Bateman wrote: On 12/01/2012 09:35, Jonathan Lu wrote: Hi core-libs-dev, It was found that solaris/native/java/lang/UNIXProcess_md.c includes wait.h which does not seem

Re: Patch to expand tz checking scope in TimeZone_md.c

2012-01-09 Thread Jonathan Lu
Hi core-libs-dev, Here's another approach to just add a defined(AIX) check to make sure it works on Aix platform. http://cr.openjdk.java.net/~luchsh/timezone_md_ret_check/ Any suggestions? Cheers, - Jonathan On 11/02/2011 04:56 PM, Jonathan Lu wrote: Hi core-libs-dev, In jdk/src/solaris

Re: Patch to expand tz checking scope in TimeZone_md.c

2011-11-14 Thread Jonathan Lu
Hi Kurt, On 11/10/2011 11:09 AM, Kurt Miller wrote: On 11/09/11 03:01, Jonathan Lu wrote: On 11/04/2011 01:26 PM, David Holmes wrote: On 4/11/2011 2:53 PM, David Holmes wrote: On 4/11/2011 2:13 PM, Masayoshi Okutsu wrote: Probably the difference isn't documented. I tried Solaris 10

Re: Patch to expand tz checking scope in TimeZone_md.c

2011-11-09 Thread Jonathan Lu
, Jonathan Lu wrote: Hi Masayoshi, I did find some references about date-time related functions / TZ variables on Linux but got only a few about Solaris, so could not see any differences between those two platforms about the changes described in my patch. Have you got any links or references about

Re: Patch to expand tz checking scope in TimeZone_md.c

2011-11-02 Thread Jonathan Lu
On 11/02/2011 07:00 PM, David Holmes wrote: On 2/11/2011 7:01 PM, Jonathan Lu wrote: On 11/02/2011 04:56 PM, Jonathan Lu wrote: Hi core-libs-dev, In jdk/src/solaris/native/java/util/TimeZone_md.c, starting from line 626, I found that the scope of #ifdef __solaris__ might be too narrow, since