On Mon, 15 Nov 2021 18:47:34 GMT, Andrew Leonard wrote:
> Both jar and jmod utilise java.io file operations whose methods define no
> ordering of the return file lists, and in fact rely on OS query file
> ordering, which can differ by underlying OS architecture.
> This PR adds sort processing
On Wed, 17 Nov 2021 19:18:19 GMT, Magnus Ihse Bursie wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort
On Tue, 16 Nov 2021 00:40:10 GMT, Sergey Bylokhov wrote:
>> The ZipOutputStream class may create bogus zip data which cannot be opened
>> by the ZipFile. The root cause is how the comment field is stored by the
>> ZipOutputStream. According to the zip specification, the comment field
>>
On Wed, 17 Nov 2021 19:25:33 GMT, Sergey Bylokhov wrote:
> > Sorry if my point was not clear. I would prefer to have 1 test to exercise
> > a Zip file comment vs have tests in multiple areas. Expanding the existing
> > test in this case keeps the primary coverage in one location and makes it
On Wed, 17 Nov 2021 18:43:46 GMT, Sergey Bylokhov wrote:
> > There appears to be a similar test,
> > open/test/jdk/java/util/zip/ZipFile/Comment.java, I think we probably want
> > to fold your changes into the existing test and possibly convert to use
> > TestNG.
>
> I know that test, and I
On Tue, 16 Nov 2021 00:40:10 GMT, Sergey Bylokhov wrote:
>> The ZipOutputStream class may create bogus zip data which cannot be opened
>> by the ZipFile. The root cause is how the comment field is stored by the
>> ZipOutputStream. According to the zip specification, the comment field
>>
On Fri, 5 Nov 2021 13:52:49 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to keep track of the last modified
On Sun, 14 Nov 2021 15:12:16 GMT, Alan Bateman wrote:
>> The ZipOutputStream class may create bogus zip data which cannot be opened
>> by the ZipFile. The root cause is how the comment field is stored by the
>> ZipOutputStream. According to the zip specification, the comment field
>> should
On Sun, 14 Nov 2021 11:18:48 GMT, Jaikiran Pai wrote:
>> The ZipOutputStream class may create bogus zip data which cannot be opened
>> by the ZipFile. The root cause is how the comment field is stored by the
>> ZipOutputStream. According to the zip specification, the comment field
>> should
On Sat, 13 Nov 2021 23:16:22 GMT, Sergey Bylokhov wrote:
> The ZipOutputStream class may create bogus zip data which cannot be opened by
> the ZipFile. The root cause is how the comment field is stored by the
> ZipOutputStream. According to the zip specification, the comment field should
>
On Tue, 9 Nov 2021 15:48:22 GMT, Roger Riggs wrote:
> When set on the command line `jdk.serialFilter` to an invalid value, the
> invalid value is logged but the application is allowed to start without
> setting the filter.
> This leaves the application without the protections of the serial
On Wed, 10 Nov 2021 20:51:20 GMT, Lance Andersen wrote:
> Hi all,
>
> This patch addresses a regression introduced in JDK 15 via JDK-8242959 where
> you can no longer access a file entry contained within a Zip file when there
> is also a directory entry with the same name via Z
On Thu, 11 Nov 2021 12:04:46 GMT, Alan Bateman wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address minor review comments
>
> test/jdk/java/util/zip/ZipFile/ZipFileDuplicateEntr
On Thu, 11 Nov 2021 12:50:30 GMT, Claes Redestad wrote:
>> Thank you for that clarification. The "addSlash" param being "false" in the
>> call below that comment is what made me think that the comment had a typo. I
>> read that code in a bit more detail now and I see what that comment means.
or will be consistent with earlier JDK releases.
>
> Mach5 tiers 1-3 have been run without failure
>
> Best
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Address minor review comments
--
On Thu, 11 Nov 2021 02:14:50 GMT, Jaikiran Pai wrote:
>> Hi all,
>>
>> This patch addresses a regression introduced in JDK 15 via JDK-8242959 where
>> you can no longer access a file entry contained within a Zip file when there
>> is also a directory entry with the same name via
On Wed, 10 Nov 2021 21:32:32 GMT, Claes Redestad wrote:
>> Hi all,
>>
>> This patch addresses a regression introduced in JDK 15 via JDK-8242959 where
>> you can no longer access a file entry contained within a Zip file when there
>> is also a directory entry with the same name via
Hi all,
This patch addresses a regression introduced in JDK 15 via JDK-8242959 where
you can no longer access a file entry contained within a Zip file when there is
also a directory entry with the same name via ZipFile:getEntry().
Once fixed, the behavior will be consistent with earlier JDK
On Tue, 9 Nov 2021 22:29:12 GMT, Naoto Sato wrote:
> Simple doc clarification where the `toString()` output only conforms to ISO
> 8601 if the seconds in the offset are zero.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6321
On Tue, 9 Nov 2021 22:29:12 GMT, Naoto Sato wrote:
> Simple doc clarification where the `toString()` output only conforms to ISO
> 8601 if the seconds in the offset are zero.
Hi Naoto,
I would probably file a CSR to track this minor update
-
PR:
On Wed, 3 Nov 2021 21:46:08 GMT, Eamonn McManus wrote:
> This change applies the minimal fix suggested in
> https://bugs.openjdk.java.net/browse/JDK-8231490.
> The bug text suggests possibilities for reworking, but notes that
> this change is enough to fix the data race.
> Adding a regression
On Wed, 3 Nov 2021 21:46:08 GMT, Eamonn McManus wrote:
> This change applies the minimal fix suggested in
> https://bugs.openjdk.java.net/browse/JDK-8231490.
> The bug text suggests possibilities for reworking, but notes that
> this change is enough to fix the data race.
> Adding a regression
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote:
> This PR enables reproducible Jars, Jmods and openjdk image zip files
> (eg.src.zip).
> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
> ZipOutputStream's.
> It fixes the following keys issues relating to
On Thu, 28 Oct 2021 11:56:45 GMT, Ravi Reddy wrote:
>> Hi all,
>>
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close
>> operations on GZip we are not setting the deflator to a finished state which
>>
On Sun, 24 Oct 2021 07:55:01 GMT, Mitsuru Kariya wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation
On Tue, 26 Oct 2021 06:30:39 GMT, Ravi Reddy wrote:
>> Hi all,
>>
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close
>> operations on GZip we are not setting the deflator to a finished state which
>>
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote:
> Trivial clean-up.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6110
On Fri, 15 Oct 2021 09:30:18 GMT, Mitsuru Kariya wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation
On Tue, 19 Oct 2021 06:32:57 GMT, Mitsuru Kariya wrote:
> The pre-submit test seems to have failed because the compiler was not found
> in some environments.
> Should I take any action?
> Or should I issue the /integrate pull request command?
You should be OK. Just as an extra sanity check, I
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote:
>> As a follow up of JEP 411, we will soon disallow security manager by
>> default. jtreg 6.1 does not set its own security manager if JDK version is
>> >= 18.
>
> Weijun Wang has updated the pull request incrementally with one additional
>
On Mon, 18 Oct 2021 20:49:07 GMT, Naoto Sato wrote:
> Removing a problem-listed test case, which has little value in itself.
> Confirmed it did succeed on all platforms before the removal.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5996
On Wed, 13 Oct 2021 17:43:29 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review the fix to address a javadoc issue for the Deflater::deflate
> methods that were added as part of JDK-6341887 that could throw a
> ReadOnlyBufferException.
>
>
On Fri, 15 Oct 2021 09:30:18 GMT, Mitsuru Kariya wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation
On Thu, 14 Oct 2021 01:46:31 GMT, Mitsuru Kariya wrote:
> Sorry for my very slow response.
No problem at all. I was delayed in getting the CSR created and finalized.
> These `{@code bytes}` point to the `bytes` argument, but should I change it
> to `{@code byte}s`?
Yes please make that minor
On Wed, 13 Oct 2021 18:20:03 GMT, Brian Burkhalter wrote:
>> Hi all,
>>
>> Please review the fix to address a javadoc issue for the Deflater::deflate
>> methods that were added as part of JDK-6341887 that could throw a
>> ReadOnlyBufferException.
>>
>> The` @throws ` clause for
Hi all,
Please review the fix to address a javadoc issue for the Deflater::deflate
methods that were added as part of JDK-6341887 that could throw a
ReadOnlyBufferException.
The` @throws ` clause for `ReadOnlyBufferException` was inadvertently omitted
from the javadoc for these new
On Wed, 13 Oct 2021 05:02:15 GMT, Joe Darcy wrote:
> After a refinement to the checks under development in #5709, the new checks
> examine array types of serial fields and warn if the underlying component
> type is not serializable. Per the JLS, all array types are serializable, but
> if the
On Fri, 17 Sep 2021 08:56:47 GMT, Andrey Turbanov
wrote:
> String.contains was introduced in Java 5.
> Some code in java.base still uses old approach with `String.indexOf` to check
> if String contains specified substring.
> I propose to migrate such usages. Makes code shorter and easier to
On Thu, 9 Sep 2021 20:12:47 GMT, Andrey Turbanov
wrote:
> Redundant castings make code harder to read.
> Found them by IntelliJ IDEA.
> I tried to select only casts which are definitely safe to remove. Also didn't
> touch primitive types casts.
Marked as reviewed by lancea (Reviewer).
On Fri, 1 Oct 2021 18:57:28 GMT, Naoto Sato wrote:
> This is to incorporate the ISO 4217 amendment #170, which has been released
> today, effective immediately.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5790
On Tue, 28 Sep 2021 03:10:33 GMT, Lin Zang wrote:
> Dear All， This PR has been pending there for quite a long time. I am
> wondering maybe this PR is not so interesting? I would like to leave this PR
> open for a while more, and if no new update, I would let it close
> automatically by
On Mon, 27 Sep 2021 18:51:37 GMT, Joe Darcy wrote:
> Follow-up change to JDK-8231442, augmentations to javac's Xlint:serial
> checking are out for review (#5709) and java.sql.rowset would need some
> changes to pass under the expanded checks.
>
> The changes are to suppress warnings where
On Mon, 27 Sep 2021 18:40:10 GMT, Joe Darcy wrote:
> Follow-up change to JDK-8232230, augmentations to javac's Xlint:serial
> checking are out for review (https://github.com/openjdk/jdk/pull/5709) and
> java.util.concurrent would need some changes to pass under the expanded
> checks.
>
> The
Hi Jaikiran
This is on my todo list, sorry for the delay.
Hoping we can get a couple additional eyes on this as well.
Best
Lance
-
PR: https://git.openjdk.java.net/jdk/pull/5486
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance Andersen| Principal Member of Technical Staff | +1.
On Thu, 23 Sep 2021 19:47:51 GMT, Andrey Turbanov
wrote:
> Usages of methods Integer.valueOf, Byte.valueOf, Short.valueOf,
> Float.valueOf, Double.valueOf, Long.valueOf often can be simplified by using
> their pair methods parseInt/parseLong/parseShort/parseByte/parseFloat.
Marked as
On Thu, 23 Sep 2021 14:53:42 GMT, Christian Stein wrote:
>> This commit appends the name of the JAR file to the exception message for
>> when automatic module lists a non-existing provider class.
>
> Christian Stein has updated the pull request incrementally with one
> additional commit since
On Wed, 22 Sep 2021 15:35:54 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing "the"
>
> (Spotted by Brian Burkhalter.)
Marked as
On Wed, 22 Sep 2021 13:01:34 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Fix "non-white space"
>
>JDK predominantly uses
On Tue, 21 Sep 2021 21:45:40 GMT, Naoto Sato wrote:
> Simple doc fix.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5620
On Sun, 19 Sep 2021 15:34:44 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch which addresses the issue where Zip FS will throw a
> UOE instead of returning null when Files.getFileAttributeView() is invoked
> and the view not supported.
>
> Mach5 tie
On Tue, 21 Sep 2021 12:05:27 GMT, Pavel Rappo wrote:
> This PR fixes an inline comment typo and reduces "overlinking" in a doc
> comment in `java.lang.ref.Reference`. Overlinking happens because the
> `reachabilityFence` method:
> * Links `package-summary.html#reachability` twice.
> * Refers
On Tue, 21 Sep 2021 13:16:02 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Tweak wording for Throwable constructor parameters
Overall looks like a
On Tue, 21 Sep 2021 16:48:53 GMT, Brian Burkhalter wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Tweak wording for Throwable constructor parameters
>
> src/java.base/share/classes/java/lang/Throwable.java line
> Hi all,
>
> Please review this patch which addresses the issue where Zip FS will throw a
> UOE instead of returning null when Files.getFileAttributeView() is invoked
> and the view not supported.
>
> Mach5 tiers1 - tier3 are clean.
>
> Best
> Lance
Lance
> Hi all,
>
> Please review this patch which addresses the issue where Zip FS will throw a
> UOE instead of returning null when Files.getFileAttributeView() is invoked
> and the view not supported.
>
> Mach5 tiers1 - tier3 are clean.
>
> Best
> Lance
Lance
On Mon, 20 Sep 2021 17:05:33 GMT, Severin Gehwolf wrote:
>> Hi all,
>>
>> Please review this patch which addresses the issue where Zip FS will throw a
>> UOE instead of returning null when Files.getFileAttributeView() is invoked
>> and the view not supported.
>>
>> Mach5 tiers1 - tier3
On Mon, 20 Sep 2021 11:28:10 GMT, Alan Bateman wrote:
>> Hi all,
>>
>> Please review this patch which addresses the issue where Zip FS will throw a
>> UOE instead of returning null when Files.getFileAttributeView() is invoked
>> and the view not supported.
>>
>> Mach5 tiers1 - tier3 are
Hi all,
Please review this patch which addresses the issue where Zip FS will throw a
UOE instead of returning null when Files.getFileAttributeView() is invoked
and the view not supported.
Mach5 tiers1 - tier3 are clean.
Best
Lance
-
Commit messages:
- Add Cleanup Method
-
On Thu, 16 Sep 2021 01:29:12 GMT, wxiang
wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two before
On Thu, 16 Sep 2021 09:33:44 GMT, wxiang
wrote:
>> Given that there is a precedence in this file:
>>
>>
>> p =
>> props.getProperty("jdk.net.URLClassPath.showIgnoredClassPathEntries");
>> DEBUG_CP_URL_CHECK = p != null ? p.equals("true") || p.isEmpty() :
>> false;
>>
>>
>>
On Wed, 15 Sep 2021 18:59:08 GMT, Daniel Fuchs wrote:
>> I assume the reason for specifically checking for a value of true or an
>> empty string as you envision allowing the property to be explicitly set to
>> false in the future?
>>
>> Otherwise we could just check if the property is
On Wed, 15 Sep 2021 15:48:55 GMT, Alan Bateman wrote:
>>> Another question is where to document this property. We will obviously need
>>> a CSR and releases notes. I also wonder if it should be promoted into a
>>> networking property - which would make it possible to document it in the
>>>
On Mon, 24 May 2021 11:18:57 GMT, Mitsuru Kariya
wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation
On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use "ensure" instead of "insure"
Marked as reviewed by lancea
On Fri, 10 Sep 2021 23:20:11 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert two fixes
Marked as reviewed by lancea (Reviewer).
On Sat, 11 Sep 2021 13:59:25 GMT, Naoto Sato wrote:
>> That sounds good to me, suggesting doing it at launch while discouraging the
>> use of setProperty.
>
> Hi Lance,
>
>> * Are there any scenarios where invoking setProperty will not override the
>> command line setting ?
>
> Yes. For
On Fri, 10 Sep 2021 20:35:25 GMT, Naoto Sato wrote:
>> Small spec clarification. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflecting review comment.
Marked as reviewed by
On Fri, 10 Sep 2021 20:32:03 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line
>> 120:
>>
>>> 118: * the locale sensitive services separated by a comma. It is only read
>>> and cached at
>>> 119: * the initialization of this class, so the
On Thu, 9 Sep 2021 10:14:48 GMT, kabutz
wrote:
> …of MAX_PRIORITY-2 during refactoring
>
> Appears in Java 17 for the first time.
>
> During refactoring, the priority was changed from Thread.MAX_PRIORITY - 2 to
> instead state Thread.MIN_PRIORITY - 2, which results in a negative priority,
On Thu, 9 Sep 2021 13:37:23 GMT, Aleksey Shipilev wrote:
>> …of MAX_PRIORITY-2 during refactoring
>>
>> Appears in Java 17 for the first time.
>>
>> During refactoring, the priority was changed from Thread.MAX_PRIORITY - 2
>> to instead state Thread.MIN_PRIORITY - 2, which results in a
On Thu, 9 Sep 2021 17:12:23 GMT, Maurizio Cimadamore
wrote:
> This small patch adds missing copyright header to a segment allocator
> implementation class.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5447
On Wed, 8 Sep 2021 19:31:46 GMT, Roger Riggs wrote:
>> The ExecCommand test of Runtime.exec is difficult to maintain; the parallel
>> arrays are hard to keep in sync.
>> This cleanup converts to use TestNG DataProviders and other improvements.
>
> Roger Riggs has updated the pull request with a
On Wed, 8 Sep 2021 17:40:29 GMT, Naoto Sato wrote:
>> Please review the fix to the issue. Avoiding overflow by not calling
>> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
>> in nano unit.
>
> Naoto Sato has updated the pull request incrementally with one
On Wed, 1 Sep 2021 16:37:24 GMT, Roger Riggs wrote:
> The ExecCommand test of Runtime.exec is difficult to maintain; the parallel
> arrays are hard to keep in sync.
> This cleanup converts to use TestNG DataProviders and other improvements.
Looks good Roger.
A couple trivial
On Tue, 7 Sep 2021 18:18:49 GMT, Naoto Sato wrote:
> Please review the fix to the issue. Avoiding overflow by not calling
> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
> in nano unit.
Looks OK to me
-
Marked as reviewed by lancea (Reviewer).
PR:
On Tue, 7 Sep 2021 07:03:20 GMT, Alan Bateman wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> With some discussions about the bug, the current priority is to remove the
>> JAR index support in URLClassPath,
>> and don’t need to do anything to the jar tool in the short
-
PR: https://git.openjdk.java.net/jdk/pull/5316
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com<mailto:lance.ander...@oracle.com>
On Thu, 2 Sep 2021 19:26:12 GMT, Naoto Sato wrote:
> Simple spec clarification. A CSR has also been drafted
> (https://bugs.openjdk.java.net/browse/JDK-8273296).
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5354
On Wed, 1 Sep 2021 19:26:17 GMT, Lance Andersen wrote:
> Hi,
>
> Please review this trivial fix to the javadoc which addresses an issue shown
> via Intellij where the error: "Symbol 'getAdler' is inaccessible from here"
> is generated for the "@See Inflater#g
Hi,
Please review this trivial fix to the javadoc which addresses an issue shown
via Intellij where the error: "Symbol 'getAdler' is inaccessible from here" is
generated for the "@See Inflater#getAlder" references.
Best
Lance
-
Commit messages:
- Address JDK-8273250
Changes:
On Tue, 31 Aug 2021 02:08:48 GMT, Weijun Wang wrote:
>> This change modifies the default value of the `java.security.manager` system
>> property from "allow" to "disallow". This means unless it's explicitly set
>> to "allow", any call to `System.setSecurityManager()` would throw an UOE.
>>
>>
On Mon, 23 Aug 2021 16:42:03 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. When instant seconds and zone
> co-exist in parsed data, instant seconds was not resolved correctly from them.
Marked as reviewed by lancea (Reviewer).
-
PR:
On Fri, 20 Aug 2021 22:44:34 GMT, Weijun Wang wrote:
> This change modifies the default value of the `java.security.manager` system
> property from "allow" to "disallow". This means unless it's explicitly set to
> "allow", any call to `System.setSecurityManager()` would throw an UOE.
>
> The
On Mon, 24 May 2021 11:18:57 GMT, Mitsuru Kariya
wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation
On Thu, 12 Aug 2021 17:43:48 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review the fix for JDK-8263940 to address an issues when the default
> file system provider is packaged as JAR file on class path.
>
> The patch also addresses the `@bug` line for JDK-8271194
>
On Thu, 12 Aug 2021 18:55:08 GMT, Naoto Sato wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use toList()
>
> test/jdk/java/nio/file/spi/SetDefaultProvider.java line 107:
>
>
> Hi all,
>
> Please review the fix for JDK-8263940 to address an issues when the default
> file system provider is packaged as JAR file on class path.
>
> The patch also addresses the `@bug` line for JDK-8271194
>
> Mach5 Tier1 - Tier3 have run without issues
&
Hi all,
Please review the fix for JDK-8263940 to address an issues when the default
file system provider is packaged as JAR file on class path.
The patch also addresses the `@bug` line for JDK-8271194
Mach5 Tier1 - Tier3 have run without issues
Best,
Lance
-
Commit messages:
-
On Sun, 25 Jul 2021 21:56:10 GMT, Lance Andersen wrote:
> Hi,
>
> As discussed in the
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079621.html
> thread, this is the revised patch to address the use of '.' and '..' within
> Zip FS
>
f on updates to the PR until Alan has a chance to provide his
input. I have not yet had time to go through everything outside of the very
quick pass I made earlier.
Best
Lance
Lin
-
PR: https://git.openjdk.java.net/jdk/pull/3072
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
La
current and parent
> directories and cannot reliably support entries that have "." and ".." as
> name elements. This patch updates Zip Fs to reject ZIP files that have
> entries in the CEN that can't be used for files in a file system.
>
>
> Mach5 tiers 1
On Fri, 30 Jul 2021 11:24:37 GMT, Alan Bateman wrote:
>> src/jdk.zipfs/share/classes/module-info.java line 49:
>>
>>> 47: *
>>> 48: * @implNote The Zip File System will throw a ZipException when opening
>>> an
>>> 49: * existing Zip file that contains Zip entries with "." or ".." in its
current and parent
> directories and cannot reliably support entries that have "." and ".." as
> name elements. This patch updates Zip Fs to reject ZIP files that have
> entries in the CEN that can't be used for files in a file system.
>
>
> Mach5 tiers 1
current and parent
> directories and cannot reliably support entries that have "." and ".." as
> name elements. This patch updates Zip Fs to reject ZIP files that have
> entries in the CEN that can't be used for files in a file system.
>
>
> Mach5 tiers 1
current and parent
> directories and cannot reliably support entries that have "." and ".." as
> name elements. This patch updates Zip Fs to reject ZIP files that have
> entries in the CEN that can't be used for files in a file system.
>
>
> Mach5 tiers 1
On Fri, 23 Jul 2021 16:22:01 GMT, Lance Andersen wrote:
> > Thank you for the review Alan.
> > @LanceAndersen, I've run the tier1 tests locally with the latest PR and
> > they have passed without any regressions. Given that we changed the
> > implementation to wr
On Mon, 26 Jul 2021 03:28:44 GMT, Lin Zang wrote:
>> 4890732: GZIPOutputStream doesn't support optional GZIP fields
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 13 commits:
>
> - change since version to 18
> -
On Mon, 26 Jul 2021 09:52:09 GMT, Jaikiran Pai wrote:
> This change looks fine to me. I was unsure how the writing/creating entries
> with `.` or `..` with `ZipFileSystem` would behave in context of this change,
> so I gave this a try locally with the changes from this PR:
>
> ```
> try
On Mon, 26 Jul 2021 07:30:12 GMT, Alan Bateman wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add missing Copyright header and address minor comments
>
> src/jdk.zip
current and parent
> directories and cannot reliably support entries that have "." and ".." as
> name elements. This patch updates Zip Fs to reject ZIP files that have
> entries in the CEN that can't be used for files in a file system.
>
>
> Mach5 tiers 1
201 - 300 of 1866 matches
Mail list logo
