Re: RFR: 8150469: unpack200 fails to compare crc correctly.

2016-02-29 Thread Omair Majid
Hi, * Kumar Srinivasan [2016-02-29 11:07]: > Please review fix for https://bugs.openjdk.java.net/browse/JDK-8150469 > > The review is at: > http://cr.openjdk.java.net/~ksrini/8150469/webrev.00/ I can confirm this patch fixes the problem with a particular pack.gz that I was observing. (This isn

Re: JDK-8036003: Add variable not to separate debug information.

2014-04-23 Thread Omair Majid
Hi, * Yasumasa Suenaga [2014-04-04 10:56]: > I've succeeded to make binaries which are contained debuginfo as following: > > http://mail.openjdk.java.net/pipermail/build-dev/2014-March/012037.html > $ make images STRIP_POLICY=no_strip POST_STRIP_CMD="" > > I guess that we should run "make" abov

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-03 Thread Omair Majid
* David Holmes [2014-02-28 18:48]: > There are three pieces to all of this: > > 1. Generating debug symbols in the binaries (via gcc -g or whatever) > 2. Generating debuginfo files (zipped or not) (FDS) > 3. Stripping debug symbols from the binaries (strip-policy) > > It may be that we don't hav

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-03 Thread Omair Majid
Hi, * Daniel D. Daugherty [2014-03-03 09:57]: > On 3/1/14 4:08 PM, Mike Duigou wrote: > > If we can put debuginfo into external files why would we ever want > > unstripped binaries? > > We deliver minimal stripped binaries so that can have stack traces > with some amount of information in them

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-03 Thread Omair Majid
* Andrew Haley [2014-03-03 04:43]: > On 02/28/2014 09:18 AM, Yasumasa Suenaga wrote: > > For example, OpenJDK8 in Fedora20 ships libjvm.so and libjvm.debuginfo . > > libjvm.debuginfo is generated in OpenJDK's makefiles, however it does not > > contain debug information. Actual debug information is

Re: Additional source to guess the local timezone ID on linux

2013-08-27 Thread Omair Majid
On 08/27/2013 03:00 AM, Masayoshi Okutsu wrote: > /etc/sysconfig/clock used to be supported, but it was removed in JDK 7. > The problem is discussed in bug #6456628. > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6456628 Thanks for that link. I did not know that this support was present i

Re: Additional source to guess the local timezone ID on linux

2013-08-25 Thread Omair Majid
Hi David, Thanks for looking at the patch! On 08/25/2013 09:59 PM, David Holmes wrote: > On 24/08/2013 7:09 AM, Omair Majid wrote: >> The algorithm that OpenJDK uses to guess the local timezone ID on Linux >> goes like this: >> >> 1. If TZ environment variable is

Additional source to guess the local timezone ID on linux

2013-08-23 Thread Omair Majid
Hi, The algorithm that OpenJDK uses to guess the local timezone ID on Linux goes like this: 1. If TZ environment variable is set, use that 2. If /etc/timezone is readable, read the time zone from there 3. If /etc/localtime is a symlink, resolve that, and use the name to guess the time zone. 4. Sc

Re: Enum.valueOf(String)

2013-08-20 Thread Omair Majid
On 08/20/2013 04:09 PM, Eamonn McManus wrote: > It might occur to me to look at valueOf(Class, String) if I was > looking for a method to convert a string to an enum constant, but I > don't think it would occur to me to look there if I was looking for a > method to get all the values of an enum. I'

Re: Build error with GCC4.8 on Fedora19

2013-07-24 Thread Omair Majid
On 07/24/2013 04:11 PM, Helio Frota wrote: > Hi, > > I got the same problem with GCC 4.8.1 and Manjaro distribution ( distro > son of archlinux ) > > Generating precompiled header precompiled.hpp.gch > cc1plus: error: the "stabs" debug format cannot be used with > pre-compiled headers [-Werror=de

Re: Build error with GCC4.8 on Fedora19

2013-07-24 Thread Omair Majid
On 07/24/2013 03:44 PM, Helio Frota wrote: > Hi, > > Another problem: > > configure: error: Could not find all X11 headers (shape.h Xrender.h > XTest.h). You might be able to fix this by running 'sudo yum install > libXtst-devel'. > configure exiting with result code 1 > > I did this, but the er

Re: Build error with GCC4.8 on Fedora19

2013-07-10 Thread Omair Majid
On 07/09/2013 03:40 AM, Erik Joelsson wrote: > I would like to see a comment explaining why the option was needed. Is > this a bug in gcc or has the checking just become better? -Werror is not a great default. It means "all warnings are errors". The set of warnings that a compiler emits changes al

Re: Review Request: 7193406 - Clean-up JDK Build Warnings in java.util, java.io

2012-08-24 Thread Omair Majid
On 08/23/2012 09:43 PM, Stuart Marks wrote: > However, there are several cases where the following occurs: > > SUBDIRS_MAKEFLAGS += JAVAC_WARNINGS_FATAL=true > > and this is **not** overridable on the command line. But it is! Use: make SUBDIRS_MAKEFLAGS="" instead of SUBDIRS_MAKEFLAGS=""

Re: [PATCH FOR REVIEW] Potential Buffer Overflow in java_props_md.c

2012-08-01 Thread Omair Majid
On 08/01/2012 09:52 AM, Andrew Hughes wrote: > I have no idea what happened with Omair's > extended version. It's not in IcedTea. > I didn't commit it to icedtea since I assumed I would be committing it to OpenJDK7/8 anyway (and icedtea would get it on the next sync). And I didn't commit it to O

Re: 7121110 : JAXP 1.4.5 update 1 for 7u4 & jaxp source in jdk7 repo

2011-12-23 Thread Omair Majid
On 12/23/2011 04:27 PM, Joe Wang wrote: Hi All, We have prepared a jaxp update for 7u4. The listed changes have been posted to the jdk7u-dev alias with "7u4 Request for approval for CR 7121110 - JAXP 1.4.5 update 1 for 7u4". With this update, we are adding jaxp sources back into the jdk7 reposi

Re: please review 7117612: warnings fixes in java.lang

2011-12-08 Thread Omair Majid
On 12/08/2011 01:25 PM, Stuart Marks wrote: On 12/8/11 8:25 AM, Omair Majid wrote: On 12/7/11 3:13 PM, Omair Majid wrote: You have commit rights, don't you? I'd say it's OK to proceed with the push. Or, if you prefer, Alan should be online in just a couple hours, and I'm

Re: please review 7117612: warnings fixes in java.lang

2011-12-08 Thread Omair Majid
On 12/08/2011 01:22 AM, Stuart Marks wrote: On 12/7/11 3:13 PM, Omair Majid wrote: On 12/07/2011 05:43 AM, Alan Bateman wrote: I looked through the latest webrev. In EnumConstantNotPresentException.java then the @SuppressWarnings("rawtypes") should probably have a comment to explain

Re: please review 7117612: warnings fixes in java.lang

2011-12-07 Thread Omair Majid
On 12/07/2011 05:43 AM, Alan Bateman wrote: On 05/12/2011 22:09, Omair Majid wrote: I have posted a new webrev: http://cr.openjdk.java.net/~omajid/webrevs/warnings-day-2011/03/ This includes all the changes from the feedback so far, as well as changes to ThreadLocal. I will not be posting a

Re: please review 7117612: warnings fixes in java.lang

2011-12-05 Thread Omair Majid
Hi, On 12/04/2011 08:02 PM, Stuart Marks wrote: Please review the following webrev submitted by Omair Majid, consisting of warnings fixes for a variety of files in java.lang. http://cr.openjdk.java.net/~omajid/webrevs/warnings-day-2011/01/ It looks pretty clean, but it would be good to get

Re: please review 7117612: warnings fixes in java.lang

2011-12-05 Thread Omair Majid
On 12/05/2011 11:28 AM, Alan Bateman wrote: On 05/12/2011 16:14, Omair Majid wrote: src/windows/classes/java/lang/ProcessEnvironment.java: - Added a serialVersionUID. Unfortunately, I don't have a windows box so I cant identify the previous serialVersionUID value for this class. Can so

Re: please review 7117612: warnings fixes in java.lang

2011-12-05 Thread Omair Majid
11 6:04 PM, David Holmes wrote: Are the signature changes in src/share/classes/java/lang/EnumConstantNotPresentException.java permitted? Otherwise looks okay to me. David On 5/12/2011 11:02 AM, Stuart Marks wrote: Please review the following webrev submitted by Omair Majid, consisting of

Re: Request for Review: Warnings cleanup in java.lang.*, java.util.**

2011-12-02 Thread Omair Majid
Hi, On 12/02/2011 07:18 AM, Alan Bateman wrote: cc'ing core-libs-dev as that is the place to discuss these changes. I see on the sign-up sheet [1] that omajid has signed up for java.lang, maybe you are working together? Unfortunately, David and I were not working together :( Anyway, here is

Re: hidden directories under /etc/

2011-09-29 Thread Omair Majid
On 09/29/2011 05:43 PM, Alan Bateman wrote: Omair Majid wrote: Hi, I recently discovered that openjdk creates hidden directories under /etc/ [1]. I would like to propose that those directories should be made explicit. webrev at: http://cr.openjdk.java.net/~omajid/webrevs/hidden-dirs-under-etc

hidden directories under /etc/

2011-09-29 Thread Omair Majid
Hi, I recently discovered that openjdk creates hidden directories under /etc/ [1]. I would like to propose that those directories should be made explicit. webrev at: http://cr.openjdk.java.net/~omajid/webrevs/hidden-dirs-under-etc/01/ The patch modifies the directory names to make them visib

Re: Request for approval: Bug 100057 - Potential stack corruption in GetJavaProperties

2011-05-18 Thread Omair Majid
On 05/18/2011 09:56 AM, Alan Bateman wrote: Omair Majid wrote: : It looks like this patch still has not been applied to OpenJDK7. I have prepared a webrev that updates this patch so it applies cleanly: http://cr.openjdk.java.net/~omajid/webrevs/stack-overflow-ParserLocale/01/ I would

Re: Request for approval: Bug 100057 - Potential stack corruption in GetJavaProperties

2011-05-17 Thread Omair Majid
Xueming Shen writes: > This is kind of nitpicking > comment, so definitely not going to block your patch. > It looks like this patch still has not been applied to OpenJDK7. I have prepared a webrev that updates this patch so it applies cleanly: http://cr.openjdk.java.net/~omajid/webrevs/stack-o