Integrated: 8269124: Update java.time to use switch expressions (part II)

2021-07-05 Thread Patrick Concannon
On Tue, 22 Jun 2021 10:50:17 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review the second half of my update for the `java.time` > package to make use of switch expressions? > > This PR was split into two parts due to the large number of files affected.

Re: RFR: 8269124: Update java.time to use switch expressions (part II) [v6]

2021-07-02 Thread Patrick Concannon
> Hi, > > Could someone please review the second half of my update for the `java.time` > package to make use of switch expressions? > > This PR was split into two parts due to the large number of files affected. > > Kind regards, > > Patrick Patrick Concanno

Integrated: 8268469: Update java.time to use switch expressions

2021-06-25 Thread Patrick Concannon
On Wed, 9 Jun 2021 15:41:59 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.time` > packages to make use of the switch expressions? > > Kind regards, > Patrick This pull request has now been integrated.

Re: RFR: 8268469: Update java.time to use switch expressions [v6]

2021-06-25 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.time` > packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. T

Re: RFR: 8269124: Update java.time to use switch expressions (part II) [v5]

2021-06-24 Thread Patrick Concannon
> Hi, > > Could someone please review the second half of my update for the `java.time` > package to make use of switch expressions? > > This PR was split into two parts due to the large number of files affected. > > Kind regards, > > Patrick Patrick Concanno

Re: RFR: 8269124: Update java.time to use switch expressions (part II) [v2]

2021-06-24 Thread Patrick Concannon
On Wed, 23 Jun 2021 17:54:30 GMT, Daniel Fuchs wrote: >> I'd personally replace all the applicable locations, as otherwise, it would >> confuse why there are two idioms. But it is outside of this PR so probably >> for another day. > > I agree with Naoto that it's a bit strange. OK. If you

Re: RFR: 8269124: Update java.time to use switch expressions (part II) [v4]

2021-06-24 Thread Patrick Concannon
> Hi, > > Could someone please review the second half of my update for the `java.time` > package to make use of switch expressions? > > This PR was split into two parts due to the large number of files affected. > > Kind regards, > > Patrick Patrick Concanno

Re: RFR: 8268469: Update java.time to use switch expressions [v5]

2021-06-24 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.time` > packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. T

Re: RFR: 8269124: Update java.time to use switch expressions (part II) [v2]

2021-06-23 Thread Patrick Concannon
On Tue, 22 Jun 2021 17:27:58 GMT, Naoto Sato wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8269124: Added missing brace; fixed build issue > > src/java.base/share/classes/j

Re: RFR: 8269124: Update java.time to use switch expressions (part II) [v3]

2021-06-22 Thread Patrick Concannon
> Hi, > > Could someone please review the second half of my update for the `java.time` > package to make use of switch expressions? > > This PR was split into two parts due to the large number of files affected. > > Kind regards, > > Patrick Patrick Concanno

Re: RFR: 8269124: Update java.time to use switch expressions (part II) [v2]

2021-06-22 Thread Patrick Concannon
On Tue, 22 Jun 2021 15:40:12 GMT, Aleksei Efimov wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8269124: Added missing brace; fixed build issue > > src/java.base/share/classes/j

Re: RFR: 8269124: Update java.time to use switch expressions (part II) [v2]

2021-06-22 Thread Patrick Concannon
> Hi, > > Could someone please review the second half of my update for the `java.time` > package to make use of switch expressions? > > This PR was split into two parts due to the large number of files affected. > > Kind regards, > > Patrick Patrick Concanno

RFR: 8269124: Update java.time to use switch expressions (part II)

2021-06-22 Thread Patrick Concannon
Hi, Could someone please review the second half of my update for the `java.time` package to make use of switch expressions? This PR was split into two parts due to the large number of files affected. Kind regards, 
Patrick - Commit messages: - 8269124: Update java.time to use

Re: RFR: 8268469: Update java.time to use switch expressions [v3]

2021-06-22 Thread Patrick Concannon
On Thu, 17 Jun 2021 13:51:27 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contai

Re: RFR: 8268469: Update java.time to use switch expressions [v4]

2021-06-22 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.time` > packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. T

Re: RFR: 8268469: Update java.time to use switch expressions [v3]

2021-06-22 Thread Patrick Concannon
On Wed, 16 Jun 2021 10:58:22 GMT, Stephen Colebourne wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull req

Re: RFR: 8268469: Update java.time to use switch expressions [v3]

2021-06-16 Thread Patrick Concannon
On Wed, 9 Jun 2021 22:11:59 GMT, Stephen Colebourne wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contai

Re: RFR: 8268469: Update java.time to use switch expressions [v3]

2021-06-16 Thread Patrick Concannon
On Wed, 9 Jun 2021 16:25:55 GMT, Naoto Sato wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contai

Re: RFR: 8268469: Update java.time to use switch expressions [v3]

2021-06-16 Thread Patrick Concannon
On Wed, 9 Jun 2021 16:31:10 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contai

Re: RFR: 8268469: Update java.time to use switch expressions [v3]

2021-06-16 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.time` > packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. T

Re: RFR: 8268469: Update java.time to use switch expressions [v3]

2021-06-16 Thread Patrick Concannon
On Wed, 9 Jun 2021 22:03:54 GMT, Stephen Colebourne wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contai

Integrated: 8268124: Update java.lang to use switch expressions

2021-06-10 Thread Patrick Concannon
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.lang` > packages to make use of the switch expressions? > > Kind regards, > Patrick This pull request has now been integrated.

Re: RFR: 8268469: Update java.time to use switch expressions [v2]

2021-06-10 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.time` > packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. T

Re: RFR: 8268124: Update java.lang to use switch expressions [v6]

2021-06-10 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.lang` > packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. T

RFR: 8268469: Update java.time to use switch expressions

2021-06-09 Thread Patrick Concannon
Hi, Could someone please review my code for updating the code in the `java.time` packages to make use of the switch expressions? Kind regards, Patrick - Commit messages: - 8268469: Update java.time to use switch expressions Changes:

Re: RFR: 8268124: Update java.lang to use switch expressions [v3]

2021-06-09 Thread Patrick Concannon
On Thu, 3 Jun 2021 17:04:58 GMT, Mandy Chung wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268124: small refactoring; fixed misplaced comment and added missing >> lambda op

Re: RFR: 8268124: Update java.lang to use switch expressions [v5]

2021-06-09 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.lang` > packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with two additional commits since the last

Re: RFR: 8268124: Update java.lang to use switch expressions [v4]

2021-06-09 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.lang` > packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. T

Re: RFR: 8268124: Update java.lang to use switch expressions [v4]

2021-06-09 Thread Patrick Concannon
On Wed, 2 Jun 2021 16:10:19 GMT, Rémi Forax wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contai

Re: RFR: 8268124: Update java.lang to use switch expressions [v3]

2021-06-04 Thread Patrick Concannon
On Thu, 3 Jun 2021 11:35:13 GMT, Rémi Forax wrote: >> My mistake. I've replaced the colon now with the lambda operator. See a8706b0 > >> My mistake. I've replaced the colon now with the lambda operator. > > Drive by comment, in term of name, `->` is the arrow operator not the lambda >

Re: RFR: 8268124: Update java.lang to use switch expressions [v3]

2021-06-03 Thread Patrick Concannon
On Wed, 2 Jun 2021 16:06:42 GMT, Rémi Forax wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268124: small refactoring; fixed misplaced comment and added missing >> lambda op

Re: RFR: 8268124: Update java.lang to use switch expressions [v3]

2021-06-03 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.lang` > packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8268124: Update java.lang to use switch expressions [v3]

2021-06-03 Thread Patrick Concannon
On Wed, 2 Jun 2021 16:43:25 GMT, Naoto Sato wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268124: small refactoring; fixed misplaced comment and added missing >> lambda op

Re: RFR: 8268124: Update java.lang to use switch expressions [v2]

2021-06-03 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.lang` > packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. T

RFR: 8268124: Update java.lang to use switch expressions

2021-06-02 Thread Patrick Concannon
Hi, Could someone please review my code for updating the code in the `java.lang` packages to make use of the switch expressions? Kind regards, Patrick - Commit messages: - 8268124: Update java.lang to use switch expressions Changes:

Integrated: 8267670: Update java.io, java.math, and java.text to use switch expressions

2021-06-01 Thread Patrick Concannon
On Tue, 25 May 2021 09:37:58 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick This pull

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v10]

2021-06-01 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v9]

2021-05-31 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v8]

2021-05-27 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v7]

2021-05-26 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v6]

2021-05-26 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one ad

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v5]

2021-05-26 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v4]

2021-05-26 Thread Patrick Concannon
On Wed, 26 May 2021 09:05:34 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.io`, >> `java.math`, and `java.text` packages to make use of the switch expressions? >> >> Kind regards, >>

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v4]

2021-05-26 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one ad

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v2]

2021-05-26 Thread Patrick Concannon
On Tue, 25 May 2021 15:18:46 GMT, Chris Hegarty wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contain

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v3]

2021-05-25 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one ad

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v2]

2021-05-25 Thread Patrick Concannon
On Tue, 25 May 2021 12:43:00 GMT, Naoto Sato wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contain

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v2]

2021-05-25 Thread Patrick Concannon
On Tue, 25 May 2021 12:31:38 GMT, Chris Hegarty wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contain

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v2]

2021-05-25 Thread Patrick Concannon
On Tue, 25 May 2021 13:16:00 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contain

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v2]

2021-05-25 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to

RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions

2021-05-25 Thread Patrick Concannon
Hi, Could someone please review my code for updating the code in the `java.io`, `java.math`, and `java.text` packages to make use of the switch expressions? Kind regards, Patrick - Commit messages: - 8267670: Update java.io, java.math, and java.text to use switch expressions

Re: RFR: 8267587: Update java.util to use enhanced switch [v3]

2021-05-25 Thread Patrick Concannon
On Tue, 25 May 2021 06:01:49 GMT, Tagir F. Valeev wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch

Integrated: 8267110: Update java.util to use instanceof pattern variable

2021-05-25 Thread Patrick Concannon
On Tue, 18 May 2021 10:37:21 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.util` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick This pull request has now been i

Re: RFR: 8267110: Update java.util to use instanceof pattern variable [v5]

2021-05-24 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.util` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a re

Re: RFR: 8267110: Update java.util to use instanceof pattern variable [v4]

2021-05-21 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.util` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit si

Re: RFR: 8267110: Update java.util to use instanceof pattern variable [v3]

2021-05-21 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.util` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a re

Re: RFR: 8267110: Update java.util to use instanceof pattern variable [v2]

2021-05-19 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.util` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a re

RFR: 8267110: Update java.util to use instanceof pattern variable

2021-05-18 Thread Patrick Concannon
Hi, Could someone please review my code for updating the code in the `java.util` package to make use of the `instanceof` pattern variable? Kind regards, Patrick - Commit messages: - 8267110: Update java.util to use instanceof pattern variable Changes:

Integrated: 8265746: Update java.time to use instanceof pattern variable (part II)

2021-04-26 Thread Patrick Concannon
On Fri, 23 Apr 2021 10:44:30 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review the second half of my update for the `java.time` > package to make use of the `instanceof` pattern variable? > > This PR was split into two parts due to the large number

Re: RFR: 8265746: Update java.time to use instanceof pattern variable (part II) [v2]

2021-04-26 Thread Patrick Concannon
On Fri, 23 Apr 2021 14:29:36 GMT, Chris Hegarty wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contain

Re: RFR: 8265746: Update java.time to use instanceof pattern variable (part II) [v2]

2021-04-23 Thread Patrick Concannon
> Hi, > > Could someone please review the second half of my update for the `java.time` > package to make use of the `instanceof` pattern variable? > > This PR was split into two parts due to the large number of files affected. > > Kind regards, > > Patrick

RFR: 8265746: Update java.time to use instanceof pattern variable (part II)

2021-04-23 Thread Patrick Concannon
Hi, Could someone please review the second half of my update for the `java.time` package to make use of the `instanceof` pattern variable? This PR was split into two parts due to the large number of files affected. Kind regards, 
Patrick - Commit messages: - 8265746: Update

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v7]

2021-04-22 Thread Patrick Concannon
On Wed, 21 Apr 2021 13:02:06 GMT, Andrey Turbanov wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request cont

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v8]

2021-04-22 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.time` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a re

Integrated: 8263668: Update java.time to use instanceof pattern variable

2021-04-22 Thread Patrick Concannon
On Wed, 24 Mar 2021 09:56:16 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.time` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick This pull request has now been i

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v7]

2021-04-21 Thread Patrick Concannon
On Wed, 21 Apr 2021 13:02:06 GMT, Andrey Turbanov wrote: > I was able to find (with IntelliJ IDEA help) few more places to improve > > ``` > java.time 27 warnings > class Clock 2 warnings > class FixedClock 1 warning > method equals(Object) 1

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v6]

2021-04-21 Thread Patrick Concannon
On Wed, 21 Apr 2021 09:06:45 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated single letter pattern variable names > > src/java.base/share/classes/ja

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v7]

2021-04-21 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.time` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a re

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v6]

2021-04-21 Thread Patrick Concannon
On Wed, 24 Mar 2021 11:06:38 GMT, Rémi Forax wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated single letter pattern variable names > > src/java.base/

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v6]

2021-04-20 Thread Patrick Concannon
On Wed, 24 Mar 2021 10:57:11 GMT, Rémi Forax wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated single letter pattern variable names > > src/java.base/share/classes/jav

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v6]

2021-04-20 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.time` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit si

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v4]

2021-04-20 Thread Patrick Concannon
On Mon, 19 Apr 2021 15:37:24 GMT, Roger Riggs wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request conta

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v5]

2021-04-20 Thread Patrick Concannon
On Wed, 24 Mar 2021 13:57:35 GMT, Roger Riggs wrote: > In addition to the other suggestions, java.time could use a round of cleanup > to use switch expressions. Hi Roger, I plan to introduce switch expressions in a follow up issue/PR. - PR:

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v5]

2021-04-20 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.time` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a re

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v4]

2021-04-19 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.time` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a re

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v3]

2021-04-08 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.time` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a re

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v2]

2021-03-25 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.time` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a re

RFR: 8263668: Update java.time to use instanceof pattern variable

2021-03-24 Thread Patrick Concannon
Hi, Could someone please review my code for updating the code in the `java.time` package to make use of the `instanceof` pattern variable? Kind regards, Patrick - Commit messages: - Merge remote-tracking branch 'origin/master' into JDK-8263668 - 8263668: Update java.time to use

Integrated: 8263358: Update java.lang to use instanceof pattern variable

2021-03-24 Thread Patrick Concannon
On Wed, 10 Mar 2021 12:59:18 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.lang` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick This pull request has now been i

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v8]

2021-03-22 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.lang` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a re

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v5]

2021-03-22 Thread Patrick Concannon
On Mon, 15 Mar 2021 13:49:56 GMT, Pavel Rappo wrote: >> yes, >> javac should emit a warning in that case, that also the answer of Brian. >> >> https://mail.openjdk.java.net/pipermail/amber-spec-experts/2021-March/002925.html > > Then we should use an unbounded wildcard here and in similar

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v5]

2021-03-22 Thread Patrick Concannon
On Tue, 16 Mar 2021 19:26:35 GMT, Daniel Fuchs wrote: >> `declaringClass` is a string representing the class name (not the `Class` >> object). The variable name indeed causes confusion. > > Doh. My mistake. Was thinking about `StackFrame`. Thanks Mandy! I've reordered the checks as suggested

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v7]

2021-03-22 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.lang` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit si

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v6]

2021-03-22 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.lang` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a re

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v3]

2021-03-15 Thread Patrick Concannon
On Fri, 12 Mar 2021 17:38:30 GMT, Chris Hegarty wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8263358: Refactored equals methods > > src/java.base/share/classes/java/lang/P

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v5]

2021-03-15 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.lang` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit si

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v4]

2021-03-15 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.lang` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a re

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v3]

2021-03-11 Thread Patrick Concannon
On Thu, 11 Mar 2021 08:56:00 GMT, Alan Bateman wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8263358: Refactored equals methods > > src/java.base/share/classes/java/lang/mod

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v3]

2021-03-11 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.lang` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit si

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable

2021-03-11 Thread Patrick Concannon
gt; ??? && Arrays.equals(ptypes, that.ptypes); > > The use of "if it's not, return false" is a holdover from when we > couldn't express this as a single expression (which is almost always > preferable), which means we had to fall back to control flow.? Now we > d

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v2]

2021-03-11 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.lang` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a re

RFR: 8263358: Update java.lang to use instanceof pattern variable

2021-03-10 Thread Patrick Concannon
Hi, Could someone please review my code for updating the code in the `java.lang` package to make use of the `instanceof` pattern variable? Kind regards, Patrick - Commit messages: - 8263358: Update java.lang to use instanceof pattern variable Changes:

Integrated: 8263190: Update java.io, java.math, and java.text to use instanceof pattern variable

2021-03-09 Thread Patrick Concannon
On Mon, 8 Mar 2021 18:48:30 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the `instanceof` pattern > variable? > > Kind regards, > Patrick T

Integrated: 8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview

2021-03-09 Thread Patrick Concannon
On Fri, 12 Feb 2021 11:46:09 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my changeset for JDK-8252399: 'Update mapMulti > documentation to use type test pattern instead of instanceof once JEP 375 > exits preview' ? > > This change updates the e

RFR: 8263190: Update java.io, java.math, and java.text to use instanceof pattern variable

2021-03-08 Thread Patrick Concannon
Hi, Could someone please review my code for updating the code in the `java.io`, `java.math`, and `java.text` packages to make use of the `instanceof` pattern variable? Kind regards, Patrick - Commit messages: - 8263190: Update java.io, java.math, and java.text to use instanceof

Re: RFR: 8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview [v9]

2021-03-01 Thread Patrick Concannon
lti to use the type test pattern introduced in > [JEP375](https://openjdk.java.net/jeps/375). > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision: 8252399: Added note for keeping example in syn

Re: RFR: 8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview [v7]

2021-03-01 Thread Patrick Concannon
On Wed, 24 Feb 2021 19:26:02 GMT, Stuart Marks wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8252399: Converted JavadocExamples to test > > src/java.base/share/classes/java/ut

Re: RFR: 8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview [v8]

2021-03-01 Thread Patrick Concannon
lti to use the type test pattern introduced in > [JEP375](https://openjdk.java.net/jeps/375). > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brou

Re: RFR: 8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview [v7]

2021-02-12 Thread Patrick Concannon
lti to use the type test pattern introduced in > [JEP375](https://openjdk.java.net/jeps/375). > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision: 8252399: Converted JavadocExamples to test --

Re: RFR: 8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview [v6]

2021-02-12 Thread Patrick Concannon
lti to use the type test pattern introduced in > [JEP375](https://openjdk.java.net/jeps/375). > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brou

  1   2   >