Hi All,
Please review fix for
https://bugs.openjdk.java.net/browse/JDK-8177275 . The jtreg test runs fine
with the changes.
http://cr.openjdk.java.net/~vtheeyarath/8177275/webrev.02/
CSR : https://bugs.openjdk.java.net/browse/JDK-8205917
Regards
Vivek
Hi All,
Please review fix for
https://bugs.openjdk.java.net/browse/JDK-8204342 . The jtreg test runs fine
with the changes.
http://cr.openjdk.java.net/~vtheeyarath/8204342/webrev.00/
Regards
Vivek
Hi All,
Please review fix for
https://bugs.openjdk.java.net/browse/JDK-8202216
Webrev: http://cr.openjdk.java.net/~vtheeyarath/8202216/webrev.00/
CSR : https://bugs.openjdk.java.net/browse/JDK-8204852
Regards
Vivek
list where this test has been
ported to. So, I am assuming this would still help. But for that, I agree with
you that this may not be needed.
Regards
Vivek
From: Lance Andersen
Sent: Saturday, May 26, 2018 6:06 PM
To: Vivek Theeyarath <vivek.theeyar...@oracle.com>
Cc: core-libs-dev <
Hi All,
Please review fix for
https://bugs.openjdk.java.net/browse/JDK-8193154 .
http://cr.openjdk.java.net/~vtheeyarath/8193154/webrev.00/
The test ran fine with Mach5
http://java.se.oracle.com:10065/mdash/jobs/root-jdk-dev-20180526-0645-24095
Regards
Vivek
Thanks for the comments Mandy. I have updated the test accordingly.
http://cr.openjdk.java.net/~vtheeyarath/8177276/webrev.04/
Regards
Vivek
From: mandy chung
Sent: Tuesday, May 22, 2018 10:07 PM
To: Vivek Theeyarath <vivek.theeyar...@oracle.com>; Paul Sandoz
<paul.san...@o
/8177276/webrev.03/
Bug : https://bugs.openjdk.java.net/browse/JDK-8177276
CSR : https://bugs.openjdk.java.net/browse/JDK-8202991
Regards
Vivek
-Original Message-
From: Paul Sandoz
Sent: Monday, May 21, 2018 10:19 PM
To: Vivek Theeyarath <vivek.theeyar...@oracle.com>
Cc: core-li
Hi All,
A gentle reminder seeking review.
Regards
Vivek
From: Vivek Theeyarath
Sent: Thursday, May 17, 2018 6:22 AM
To: core-libs-dev@openjdk.java.net
Subject: RFR: 8177276: MethodHandles.insertArguments doesn't specify
IllegalArgumentException on index mismatch
Hi All
Hi All,
Please review fix for https://bugs.openjdk.java.net/browse/JDK-8177276
.
http://cr.openjdk.java.net/~vtheeyarath/8177276/webrev.02/
The related CSR is https://bugs.openjdk.java.net/browse/JDK-8202991 .
Regards
Vivek
Hi All,
Please review fix for https://bugs.openjdk.java.net/browse/JDK-8195717 .
http://cr.openjdk.java.net/~vtheeyarath/8195717/webrev.02/
The test class has been re factored into multiple classes with the existing
MethodHandlesTest.java being made abstract.
Testing Done:
Hi Stuart,
Done with the changes
http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.05/ .
Regards
Vivek
-Original Message-
From: Stuart Marks
Sent: Wednesday, April 18, 2018 8:56 AM
To: Vivek Theeyarath <vivek.theeyar...@oracle.com>
Cc: core-libs-dev <core
Hi All,
Please find the updated webrev
http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.04
Regards
Vivek
-Original Message-
From: Stuart Marks
Sent: Tuesday, April 17, 2018 5:11 AM
To: Vivek Theeyarath <vivek.theeyar...@oracle.com>
Cc: core-libs-dev <core
, 2018 6:48 PM
To: Vivek Theeyarath <vivek.theeyar...@oracle.com>
Cc: Remi Forax <fo...@univ-mlv.fr>; core-libs-dev
<core-libs-dev@openjdk.java.net>
Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
> On 15 Apr 2018, at 11:25, Vivek Theeyarath <vivek.theeyar...@oracl
Hi All,
Please review
http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.01/
Regards
Vivek
-Original Message-
From: Vivek Theeyarath
Sent: Saturday, April 14, 2018 6:24 PM
To: Remi Forax <fo...@univ-mlv.fr>
Cc: core-libs-dev <core-libs-dev@openjdk.java.net>
Subj
I missed that Remi. Thanks for pointing it out. Will address those and get back.
Regards
Vivek
-Original Message-
From: Remi Forax [mailto:fo...@univ-mlv.fr]
Sent: Saturday, April 14, 2018 2:58 PM
To: Vivek Theeyarath <vivek.theeyar...@oracle.com>
Cc: core-libs-dev <core
Hi All,
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8184693
Webrev : http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.00/
The related jtreg test was run and the test passed .
Regards
Vivek
easy enough to create a simple script to create the webrev and copy it to
cr.openjdk...
Continued javadoc @xxx lines should be indented to improve readability of the
source.
5845 * against this pattern.
Thanks, Roger
On 4/12/18 8:49 AM, Vivek Theeyarath wrote:
Hi,
I
Hi,
I have updated the doc as per the suggestion. Have finalized the csr
too.
Regards
Vivek
-Original Message-
From: Paul Sandoz
Sent: Thursday, April 12, 2018 12:40 AM
To: Vivek Theeyarath <vivek.theeyar...@oracle.com>
Cc: Roger Riggs <roger.ri...@oracle.com>; C
tire' will make it clearer that the pattern must match then entire input
> string.
>
> 5827: Split into two sentences, the second one starting "For example,"
>
> 5840: add a blank line between methods
>
> Regards, Roger
>
>
> On 4/9/18 5:05 AM, Vivek Th
Sent: Friday, April 06, 2018 6:55 AM
To: Vivek Theeyarath <vivek.theeyar...@oracle.com>
Cc: Core-Libs-Dev <core-libs-dev@openjdk.java.net>
Subject: Re: RFR: 8184692: add Pattern.asMatchPredicate
> On Apr 4, 2018, at 10:47 AM, Vivek Theeyarath <vivek.theeyar...@oracle.com>
string for a subsequence that
matches this pattern.
-or-
* Creates a predicate that tests if this pattern is found in a given input
string. Thanks, Roger
On 4/5/18 6:34 AM, Vivek Theeyarath wrote:
>>> Hi,
>>> I have incorporated the changes as per the feedback and here is the
>>
>> Hi,
>> I have incorporated the changes as per the feedback and here is the
>> updated webrev .
>> http://cr.openjdk.java.net/~rraghavan/8164781/webrev.02/ .
>>Bug: https://bugs.openjdk.java.net/browse/JDK-8164781
>>
>+1
Thanks Paul
>I know it’s picky, but would you mind sticking
Hi All,
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8184692
Webrev : http://cr.openjdk.java.net/~vtheeyarath/8184692/webrev.00/
The related jtreg test was run and the test passed .
Regards
Vivek
to address Uwe's point with a fix separately.
Regards
Vivek
-Original Message-
From: Stuart Marks
Sent: Wednesday, April 04, 2018 6:13 AM
To: Vivek Theeyarath <vivek.theeyar...@oracle.com>
Cc: Paul Sandoz <paul.san...@oracle.com>; Core-Libs-Dev
<core-libs-dev@openjdk.ja
Hi all,
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8164781
Webrev: http://cr.openjdk.java.net/~rraghavan/8164781/webrev.01/
Regards
Vivek
25 matches
Mail list logo
