Please take a look at
http://cr.openjdk.java.net/~weijun/8021788/webrev.00/
The problem is that the method treats no META-INF entry as normal. If we
can be sure that MANIFEST.MF and signature-related files are always at
the beginning, we can safely treat an entry normal when we have done
w
Changeset: 29f153e11683
Author:weijun
Date: 2013-08-02 08:59 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/29f153e11683
8021789: jarsigner parses alias as command line option (depending on locale)
Reviewed-by: vinnie
! src/share/classes/sun/security/tools/jarsigner/Main.jav
Changeset: 5f2a8db78aca
Author:weijun
Date: 2013-07-13 08:47 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5f2a8db78aca
8019410: sun/security/krb5/auto/ReplayCacheTestProc.java
Reviewed-by: mullan
! test/sun/security/krb5/auto/ReplayCacheTestProc.java
Changeset: 780a64979c8d
Author:weijun
Date: 2013-07-10 15:11 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/780a64979c8d
8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5
Reviewed-by: mullan
! src/share/classes/com/sun/security/sasl/util/AbstractSaslImpl.jav
-process interaction. Maybe you don't need it.
--Max
On 6/26/13 9:33 AM, Weijun Wang wrote:
>
>
> On 6/26/13 9:32 AM, huizhe wang wrote:
>> Thanks! I'll give it a try. Do you plan to backport this to jdk7?
>
> No, but you can smuggle it there inside your test.
>
spath?
>>>
>>> e.g.
>>> Proc pc = Proc.create("Test")
>>> .args("-Xbootclasspath/p:"+pathtoXercesImpljar)
>>> .start();
>>> is that how 3rd party jar file can be put on the bootclasspath? what else
>>> n
Changeset: 89631a384ee6
Author:weijun
Date: 2013-06-25 21:51 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89631a384ee6
8016051: Possible ClassCastException in KdcComm
Reviewed-by: weijun
Contributed-by: Artem Smotrakov
! src/share/classes/sun/security/krb5/KdcComm.java
On 6/25/13 6:42 AM, Rob McKenna wrote:
Some interesting conversations were had lately about shell scripts
during Joe Darcy's recent infrastructure tech talk. In particular around
the idea of a "jdk.testing" package to provide libraries that would help
with the types of operations seen in shell sc
Changeset: 1bf060029a5d
Author:weijun
Date: 2013-06-24 16:25 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1bf060029a5d
8017453: ReplayCache tests fail on multiple platforms
Reviewed-by: xuelei
! test/sun/security/krb5/auto/ReplayCacheExpunge.java
! test/sun/security/krb5/a
some toUppreCase, some might not be complete (no OS X?). It will be
nice if we have a safe and consistent way. It could even cover the
PropertyPermission needed.
--Max
On 6/24/13 4:13 PM, Alan Bateman wrote:
On 24/06/2013 05:57, Weijun Wang wrote:
I thought os.name for Solaris is 'Solaris
I thought os.name for Solaris is 'Solaris' but it's actually 'SunOS'.
There is a helper class at
http://hg.openjdk.java.net/jdk8/tl/jdk/file/fd050ba1cf72/src/share/classes/sun/awt/OSInfo.java
This file uses
if (osName.contains("Solaris") || osName.contains("SunOS"))
Is it real that the val
Changeset: 4503e04141f7
Author:weijun
Date: 2013-06-21 18:26 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4503e04141f7
8001326: Improve Kerberos caching
Reviewed-by: valeriep
! src/share/classes/sun/security/jgss/krb5/AcceptSecContextToken.java
! src/share/classes/sun/secu
On 6/19/2013 8:58 PM, Alan Bateman wrote:
One question on the attribution (so that we have it right). In the
Contributed-by line then you have Alan Eliasen listed but the @author
tags have been extended to list Tim Buktu in addition to Alan. Is the
patch from both Alan and Tim? I ask because I
Changeset: 021fdd093cd9
Author:weijun
Date: 2013-06-13 09:59 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/021fdd093cd9
8014310: JAAS/Krb5LoginModule using des encytypes failure with NPE after
JDK-8012679
Reviewed-by: valeriep
! src/share/classes/sun/security/krb5/Config.j
Hi All
I have a method that could throw two kinds of checked exceptions and
possibly other unchecked ones:
void once() throws One, Two
Now I have a wrapper method that calls once() for multiple times, and
want to throw the first exception if *all* fails. Now it looks like
void multip
On 5/16/13 5:52 PM, Xuelei Fan wrote:
On 5/16/2013 5:22 PM, Weijun Wang wrote:
Hi Xuelei
I'm busy on something else, so probably have no time (or cannot
concentrate) to read in details.
Not urgent fix, so please review these request only when you available.
In my opinion, ther
Changeset: 0f7aaabed25f
Author:weijun
Date: 2013-05-18 10:15 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f7aaabed25f
8012261: update policytool to support java.net.HttpURLPermission
Reviewed-by: mullan
! src/share/classes/sun/security/tools/policytool/PolicyTool.java
! s
Hi Xuelei
I'm busy on something else, so probably have no time (or cannot
concentrate) to read in details.
In my opinion, there are several cases as to whether to clone or not:
1. MUST NOT clone, because the value must be shared so that change at
one side appears on the other side.
2. MUST
Out of curiosity (my major was math back in university), I take a look
at BigInteger.java.phase1:
First you have:
/**
* The threshold value for using 3-way Toom-Cook multiplication.
* If the number of ints in both mag arrays are greater than this
number,
* then Toom-Cook mu
Good. They look fine.
-Max
On 5/9/13 10:31 AM, Xuelei Fan wrote:
Oops, here is the webrev:
http://cr.openjdk.java.net/~xuelei/8005598/webrev.00/
Xuelei
On 5/9/2013 10:30 AM, Xuelei Fan wrote:
Hi,
It's a correction of previous fix of JDK-8003265:
http://hg.openjdk.java.net/jdk8/tl/jdk/r
Changeset: 814dcc08df52
Author:weijun
Date: 2013-05-07 12:30 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/814dcc08df52
8010192: Enable native JGSS provider on Mac
Reviewed-by: valeriep
! make/sun/security/Makefile
! makefiles/CompileNativeLibraries.gmk
! src/share/classes/
Changeset: 81be41c7323f
Author:weijun
Date: 2013-05-03 10:43 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81be41c7323f
8013855: DigestMD5Client has not checked RealmChoiceCallback value
Reviewed-by: xuelei, mullan
! src/share/classes/com/sun/security/sasl/digest/DigestMD5C
Changeset: ae4a82e69da2
Author:weijun
Date: 2013-05-01 21:05 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae4a82e69da2
8012082: SASL: auth-conf negotiated, but unencrypted data is accepted, reset to
unencrypt
Reviewed-by: vinnie
! src/share/classes/com/sun/security/sasl/g
On 4/27/13 3:34 PM, Alan Bateman wrote:
On 27/04/2013 04:14, Weijun Wang wrote:
I thought that in this case parent is just ignored and it's still the
child itself. Turns out this is not true, and
new File("/tmp", "/etc/passwd") is /tmp/etc/passwd
Is this rea
I thought that in this case parent is just ignored and it's still the
child itself. Turns out this is not true, and
new File("/tmp", "/etc/passwd") is /tmp/etc/passwd
Is this really useful in any way?
Thanks
Max
Changeset: 22a27dfd0510
Author:weijun
Date: 2013-04-22 11:39 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/22a27dfd0510
8005527: [TEST_BUG] console.sh failed Automatically with exit code 1.
Reviewed-by: xuelei
! test/sun/security/tools/keytool/console.sh
Changeset: 778b16225d85
Author:weijun
Date: 2013-04-19 15:41 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/778b16225d85
8009636: JARSigner including TimeStamp PolicyID (TSAPolicyID) as defined in
RFC3161
Reviewed-by: mullan
! src/share/classes/com/sun/jarsigner/ContentSign
Changeset: a3cc4b8e217a
Author:weijun
Date: 2013-04-17 10:15 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a3cc4b8e217a
8011124: Make KerberosTime immutable
Reviewed-by: xuelei
! src/share/classes/sun/security/krb5/KrbApReq.java
! src/share/classes/sun/security/krb5/KrbAppM
Changeset: 0ab22e58d151
Author:weijun
Date: 2013-04-11 11:09 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ab22e58d151
8011867: Accept unknown PKCS #9 attributes
Reviewed-by: vinnie
! src/share/classes/sun/security/pkcs/PKCS9Attribute.java
+ test/sun/security/pkcs/pkcs9/Un
Changeset: 6f8e1428f7c3
Author:weijun
Date: 2013-04-11 10:58 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f8e1428f7c3
8005460: [findbugs] Probably returned array should be cloned
Reviewed-by: xuelei
! src/share/classes/sun/security/krb5/PrincipalName.java
+ test/sun/secur
Changeset: a87fac00915e
Author:weijun
Date: 2013-03-28 20:27 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a87fac00915e
8010125: keytool -importkeystore could create a pkcs12 keystore with different
storepass and keypass
Reviewed-by: vinnie
! src/share/classes/sun/security
Changeset: 3470101fae58
Author:weijun
Date: 2013-03-23 11:49 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3470101fae58
8009970: Several LoginModule classes need extra permission to load AuthResources
Reviewed-by: mullan
! src/share/classes/com/sun/security/auth/module/Jndi
Changeset: 93cd7052d306
Author:weijun
Date: 2013-03-22 19:59 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93cd7052d306
8010531: Add BadKdc* tests to problem list for solaris-sparcv9
Reviewed-by: alanb
! test/ProblemList.txt
http://cr.openjdk.java.net/~weijun/8009977/webrev.00
/**
* This is a test library that makes writing a Java test that spawns
multiple
* Java processes easily.
*
* Usage:
*
*Proc.create("Clazz") // The class to launch
*.args("x")// with args
*.env("en
Changeset: cf54f6be3e9e
Author:weijun
Date: 2013-03-07 11:32 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf54f6be3e9e
8009604: old make images failed: JarBASE64Encoder class not found
Reviewed-by: xuelei, wetmore
! make/common/Release.gmk
.
Thanks
Max
On 2/19/13 8:36 PM, Peter Levart wrote:
On 02/19/2013 01:24 PM, Peter Levart wrote:
On 02/19/2013 11:38 AM, Daniel Fuchs wrote:
On 2/19/13 11:27 AM, Weijun Wang wrote:
Hi All
I'm using LinkedList to maintain a history and the elements are ordered
by their timestamps. Every
Hi All
I'm using LinkedList to maintain a history and the elements are ordered
by their timestamps. Every now and then I would "expunge" the list, that
is to say, iterating through the list and when an element is old enough
all elements after (and including) it will be removed. Currently I'm
Maybe comparing Files.getAttribute(p, "unix:uid") and
UnixSystem().getUid()? Is there a cross-platform way?
I noticed Files.getOwner(), but seems UserPrincipal has no method of its
own and all its implementation classes are non public.
Thanks
Max
Need an equivalence of the geteuid() function that returns the effective
user ID of the calling process.
Thanks
Max
Changeset: d2495b9984fa
Author:weijun
Date: 2013-02-01 07:39 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d2495b9984fa
8006564: Test sun/security/util/Oid/S11N.sh fails with timeout on Linux 32-bit
Reviewed-by: alanb
+ test/sun/security/util/Oid/S11N.java
- test/sun/securi
Just take a brief look at the codes. It seems the library can launch a
Java process, wait for it to finish, and collect all the output (stdout
and stderr). Is that all?
I would be glad if it supports manipulating the stdin, i.e. simulating
input to a process. For example, I sometimes need to s
On 01/23/2013 07:54 PM, David Holmes wrote:
On 23/01/2013 8:58 PM, Erik Joelsson wrote:
On 2013-01-23 11:30, Weijun Wang wrote:
I thought building an OpenJDK or Oracle JDK can be fully controlled by
using the --enable-openjdk-only configure option, but it seems the
OPENJDK env variable still
I thought building an OpenJDK or Oracle JDK can be fully controlled by
using the --enable-openjdk-only configure option, but it seems the
OPENJDK env variable still plays a part. If the variable is set to true
and --enable-openjdk-only is not provided, the new build process gets
confused and fa
Changeset: bb940b2107bd
Author:juh
Date: 2013-01-21 15:05 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb940b2107bd
8006092: SecurityPermission: printIdentity doesn't exist
Reviewed-by: weijun
! test/sun/security/tools/policytool/UpdatePermissions.html
On 01/18/2013 02:58 PM, Fredrik Öhrström wrote:
18 jan 2013 kl. 03:07 skrev Weijun Wang:
Just tried on a latest jdk8/tl clone and
The makefile listed source
/space/repos/jdk8/tl/build/linux-x86_64-sjavac/langtools/gensrc/com/sun/tools/doclint/resources/doclint.java
was not calculated by
Just tried on a latest jdk8/tl clone and
Building Java(TM) for target 'all' in configuration
'/space/repos/jdk8/tl/build/linux-x86_64-sjavac'
## Starting langtools
Compiling 2 files for BUILD_TOOLS
Compiling 26 properties into resource bundles
Compiling 720 files for BUILD_BOOTSTRAP_LANGTOOLS
efer it be acceptable.
Thanks
Max
On 01/17/2013 05:12 PM, Weijun Wang wrote:
I noticed that the encoding output of Base64.getMimeEncoder() never ends
with a newline char. There is no right or wrong on this but it will be
nice to write the current behavior into the spec.
Thanks
Max
This time on the decoder side:
Base64.getMimeDecoder().decode("AA==\n")
throws an exception because the string ends with a newline. I would
prefer it be acceptable.
Thanks
Max
On 01/17/2013 05:12 PM, Weijun Wang wrote:
I noticed that the encoding output of Base64.getMimeEncod
NTLM auth still uses it. Codes in src/windows and src/solaris.
-Max
On 01/14/2013 06:14 AM, chris.hega...@oracle.com wrote:
Changeset: 7db04ae3378f
Author:chegar
Date: 2013-01-13 22:09 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7db04ae3378f
8006153: HTTP protocol hand
I noticed that the encoding output of Base64.getMimeEncoder() never ends
with a newline char. There is no right or wrong on this but it will be
nice to write the current behavior into the spec.
Thanks
Max
Ah, it seems com/sun/tools/jdeps needs to be included in
IMPORT_TOOLS_PACKAGES in jdk/make/common/internal/Defs-langtools.gmk.
-Max
On 01/09/2013 11:16 AM, Weijun Wang wrote:
I'm not talking about JPRT build.
I fetched all tl8 repos and do a full build, the jdeps command runs.
Then
I'm not talking about JPRT build.
I fetched all tl8 repos and do a full build, the jdeps command runs.
Then I use this build as ALT_JDK_IMPORT_PATH to do a partial images
build in jdk/make still shows
com/sun/tools/jdeps : no such file or directory
What am I missing here?
Thanks
Max
On
The code changes look fine.
Thanks
Max
On 12/27/2012 07:06 AM, Joe Wang wrote:
Hi,
This is a patch to clean up compiling warnings in jaxp.
Bug: http://bugs.sun.com/view_bug.do?bug_id=8005473
Webrev: http://cr.openjdk.java.net/~joehw/jdk8/8005473/webrev/
Thanks,
Joe
Changeset: eaaec81aa974
Author:weijun
Date: 2012-12-17 12:18 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eaaec81aa974
7197159: accept different kvno if there no match
Reviewed-by: xuelei
! src/share/classes/sun/security/krb5/EncryptionKey.java
! test/sun/security/krb5/aut
Changeset: 5a2ab2c3f106
Author:weijun
Date: 2012-12-13 08:11 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5a2ab2c3f106
8004235: Disable native JGSS provider on Mac
Reviewed-by: erikj, valeriep
! make/sun/security/Makefile
! makefiles/CompileNativeLibraries.gmk
! src/share/
ered the priority and add a comment.
Thanks
Max
[1] https://jbs.oracle.com/bugs/browse/JDK-8004981
Can you please file a bug for this?
Naoto
On 12/11/12 11:33 PM, Weijun Wang wrote:
I haven't build on solaris-i586 for some time and see a failure today in
make/sun/cldr. The Makefile [1] has the
Changeset: 12fba0974a9d
Author:weijun
Date: 2012-12-12 18:39 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/12fba0974a9d
8004904: Makefile for ntlm
Reviewed-by: erikj, chegar
! make/com/sun/security/Makefile
+ make/com/sun/security/ntlm/Makefile
I haven't build on solaris-i586 for some time and see a failure today in
make/sun/cldr. The Makefile [1] has these lines:
75 for dir in $(GENSRCDIR); do \
76 if [ -d $$dir ] ; then \
77 ( $(CD) $$dir; \
78
Changeset: d206e52bf8a6
Author:weijun
Date: 2012-12-11 13:14 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d206e52bf8a6
8004488: wrong permissions checked in krb5
Reviewed-by: xuelei
! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java
! src/share/classes/s
Changeset: a42da685dfca
Author:weijun
Date: 2012-12-03 17:14 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a42da685dfca
7198507: [TEST_BUG] sun/security/tools/keytool/console.sh should be rewritten
Reviewed-by: xuelei
! test/sun/security/tools/keytool/console.sh
Hi
I'm trying to use Reflection.getCallerClass(n) to find out who is
calling a method. The method's spec says:
Frames associated with
java.lang.reflect.Method.invoke() and its implementation are
completely ignored and do not count toward the nu
I've seen something weird on Linux:
new File("//../").getCanonicalFile()' = /
new File("//../../").getCanonicalFile()' = /..
new File("//../../../").getCanonicalFile()' = /
new File("//../../../../").getCanonicalFile()' = /..
and
new File("//../..").getCanonicalFil
Changeset: f740a9ac6eb6
Author:weijun
Date: 2012-11-19 11:13 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f740a9ac6eb6
8002344: Krb5LoginModule config class does not return proper KDC list from DNS
Reviewed-by: weijun
Contributed-by: Severin Gehwolf , Wang Weijun
! src/s
Changeset: 51c695958712
Author:weijun
Date: 2012-11-16 10:34 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51c695958712
8003263: redundant cast build failure after 8003120
Reviewed-by: alanb
! src/share/classes/com/sun/naming/internal/ResourceManager.java
Ping again.
If there is no more suggestion, I'll push my fix in the first webrev.
Here I'm more concerned about the build failure than the behavior of the
input streams.
Thanks
Max
On 11/12/2012 06:22 PM, Weijun Wang wrote:
In fact, it looks like the resources object here
Max
On 11/12/2012 05:42 PM, Alan Bateman wrote:
On 12/11/2012 08:43, Weijun Wang wrote:
A small webrev:
http://cr.openjdk.java.net/~weijun/8003263/webrev.00/
The reason is that 8003120 added a new line
InputStream istream = (InputStream)resources.next();
but resources is already of type
A small webrev:
http://cr.openjdk.java.net/~weijun/8003263/webrev.00/
The reason is that 8003120 added a new line
InputStream istream = (InputStream)resources.next();
but resources is already of type NamingEnumeration.
Building now shows
../../../src/share/classes/com/sun/naming/interna
DI service provider then that would be
more effort.
On 7 Nov 2012, at 01:05, Weijun Wang wrote:
Hi Vinnie
I want to write a regression test so that
Context ctx = NamingManager.getURLContext("dns", new Hashtable<>(0));
Attributes attrs =((DirContext)ctx).getAttributes(
I've just synced with jdk7u-dev and now it does not build.
symbol: class TimedWindowEvent
location: class SunToolkit
../../../src/share/classes/sun/awt/SunToolkit.java:472: error: cannot
find symbol
TimedWindowEvent twe = (TimedWindowEvent)nested;
Changeset: a1bbb8805e22
Author:weijun
Date: 2012-11-07 14:13 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a1bbb8805e22
6355584: Introduce constrained Kerberos delegation
Reviewed-by: valeriep
+ src/share/classes/com/sun/security/jgss/ExtendedGSSCredential.java
! src/share/
Hi Vinnie
I want to write a regression test so that
Context ctx = NamingManager.getURLContext("dns", new Hashtable<>(0));
Attributes attrs =((DirContext)ctx).getAttributes(
"_kerberos._udp.ASDF.COM.", SRV_RR_ATTR);
can return some entries without querying a real exter
Changeset: a1e77f7ed52b
Author:weijun
Date: 2012-10-23 10:02 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a1e77f7ed52b
8001208: Fix for KRB5CCNAME not complete
Reviewed-by: xuelei
! src/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java
! test/sun/se
Changeset: e19dc885da0d
Author:weijun
Date: 2012-10-22 17:01 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e19dc885da0d
8000624: Move MaxRetries.java to ProblemList for the moment
Reviewed-by: alanb
! test/ProblemList.txt
Changeset: b39ab9c6f4cb
Author:weijun
Date: 2012-10-22 09:59 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b39ab9c6f4cb
8001204: typo: Unable to obtain Princpal Name for authentication
Reviewed-by: xuelei
! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java
Hi Christos
You mean the exception thrown in NativeGSSFactory.java lines 52-60?
Vector creds = GSSUtil.searchSubject
(name, mech, initiate, GSSCredElement.class);
// If Subject is present but no native creds available
if (creds != null && creds.isEmpty()) {
On 10/11/2012 11:32 AM, Xueming Shen wrote:
On 10/10/12 8:16 PM, Weijun Wang wrote:
On 10/11/2012 11:09 AM, Xueming Shen wrote:
On 10/10/12 6:51 PM, Weijun Wang wrote:
Several questions:
1. In encode0(byte[] src, byte[] dst)
281 if (linepos == linemax && (a
On 10/11/2012 11:09 AM, Xueming Shen wrote:
On 10/10/12 6:51 PM, Weijun Wang wrote:
Several questions:
1. In encode0(byte[] src, byte[] dst)
281 if (linepos == linemax && (atom != 0 || sp < sl)) {
Maybe atom != 0 is not necessary?
The logic here is that if we
Several questions:
1. In encode0(byte[] src, byte[] dst)
281 if (linepos == linemax && (atom != 0 || sp < sl)) {
Maybe atom != 0 is not necessary?
2. Is it necessary to explicitly mention in the spec that there is no
CrLf at the end of a MIME encoded string?
3. The test con
Changeset: 92f3a96f3c78
Author:weijun
Date: 2012-10-08 10:42 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92f3a96f3c78
7201053: Krb5LoginModule shows NPE when both useTicketCache and storeKey are
set to true
Reviewed-by: mullan
! src/share/classes/com/sun/security/auth/mo
Changeset: 7e3ef09bb348
Author:weijun
Date: 2012-09-28 17:15 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7e3ef09bb348
7200682: TEST_BUG: keytool/autotest.sh still has problems with libsoftokn.so
Reviewed-by: alanb, smarks
! test/sun/security/tools/keytool/autotest.sh
Hi Stuart
Please take a look at
http://cr.openjdk.java.net/~weijun/7200682/webrev.00/
So I am now using "java -XshowSettings:properties | grep os.arch" to
find out the arch. Not sure if there is a more formal way to do that.
I've added core-libs-dev to CC hoping more people have their opi
your tests might have to run in othervm mode.
Thanks
Max
On 09/22/2012 05:18 PM, Alan Bateman wrote:
On 22/09/2012 00:12, Weijun Wang wrote:
I think jtreg would automatically reset any changed system property so
othervm is not necessary. Have you tried running it with other tests
in agentvm mo
I think jtreg would automatically reset any changed system property so othervm
is not necessary. Have you tried running it with other tests in agentvm mode?
Thanks
Max
在 Sep 22, 2012，2:49 AM，Kurchi Hazra 写道：
>
>
> On 21.09.2012 02:03, Chris Hegarty wrote:
>> On 21/09/12 01:12, Dan Xu wrote:
Changeset: 53ca38f76eaa
Author:weijun
Date: 2012-09-18 17:38 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53ca38f76eaa
7198871: cleanup security tests in problem lists with no CR attached
Reviewed-by: alanb
! test/ProblemList.txt
Changeset: f56f85040c58
Author:weijun
Date: 2012-09-17 18:19 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f56f85040c58
7196855: autotest.sh fails on ubuntu because libsoftokn.so not found
Reviewed-by: vinnie
! test/sun/security/tools/keytool/autotest.sh
Changeset: 0c3b0a82c4fc
Author:weijun
Date: 2012-09-17 17:19 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c3b0a82c4fc
7198205: CloseTest fails on mac
Reviewed-by: alanb, chegar, michaelm
! test/ProblemList.txt
! test/java/net/URLClassLoader/closetest/CloseTest.java
Changeset: 833f4630f3a1
Author:weijun
Date: 2012-09-07 10:24 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/833f4630f3a1
7196677: diff compares same file to itself in PaddingTest regression test.
Reviewed-by: xuelei
! test/com/sun/crypto/provider/Cipher/DES/PaddingTest.java
Changeset: c4c69b4d9ace
Author:weijun
Date: 2012-08-29 11:03 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4c69b4d9ace
7184815: [macosx] Need to read Kerberos config in files
Reviewed-by: valeriep
! src/share/classes/sun/security/krb5/Config.java
Changeset: fe496675b5e7
Author:weijun
Date: 2012-08-28 17:25 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe496675b5e7
7194472: FileKeyTab.java test fails on Windows
Reviewed-by: alanb
! test/sun/security/krb5/auto/FileKeyTab.java
Changeset: 61ddc8ce7f3b
Author:weijun
Date: 2012-08-27 10:23 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/61ddc8ce7f3b
7152121: Krb5LoginModule no longer handles keyTabNames with "file:" prefix
Reviewed-by: mullan
! src/share/classes/com/sun/security/auth/module/Krb5LoginM
Changeset: 86c963b1dbf8
Author:weijun
Date: 2012-08-20 07:59 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86c963b1dbf8
7192202: Make sure keytool prints both unknown and unparseable extensions
Reviewed-by: mullan
+ test/sun/security/tools/keytool/UnknownAndUnparseable.java
Changeset: f267302093d4
Author:weijun
Date: 2012-07-26 20:38 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f267302093d4
7187051: ShortRSAKeynnn.sh tests should do cleanup before start test
Reviewed-by: xuelei
! test/sun/security/mscapi/ShortRSAKey1024.sh
Changeset: f7731fc8c98a
Author:weijun
Date: 2012-07-24 09:20 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f7731fc8c98a
7179796: GSSExceptionImpl outputs duplicate mech oid
Reviewed-by: valeriep
! src/share/classes/sun/security/jgss/GSSCredentialImpl.java
Changeset: 5dc3f32c0d26
Author:weijun
Date: 2012-07-21 19:56 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5dc3f32c0d26
7180907: Jarsigner -verify fails if rsa file used sha-256 with authenticated
attributes
Reviewed-by: xuelei
! src/share/classes/com/sun/crypto/provider/O
Changeset: 2a39c98c1241
Author:weijun
Date: 2012-07-17 11:57 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a39c98c1241
7102106: TEST_BUG: sun/security/util/Oid/S11N.sh should be modified
Reviewed-by: mullan
! test/sun/security/util/Oid/S11N.sh
Changeset: e2d265c9b592
Author:weijun
Date: 2012-07-17 11:28 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2d265c9b592
7183203: ShortRSAKeynnn.sh tests intermittent failure
Reviewed-by: xuelei
! test/sun/security/mscapi/ShortRSAKey1024.sh
- test/sun/security/mscapi/ShortRS
tiple words in one field.
Could you please take a look at the patch?
Many thanks & best regards
Jonathan
On 04/25/2012 07:48 PM, Weijun Wang wrote:
Hi Jonathan
I'm using English.
In your test all the files have a similar modified time so you cannot
see the difference. However, in
Changeset: 79b63e8eceda
Author:weijun
Date: 2012-07-11 17:10 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79b63e8eceda
6966259: Make PrincipalName and Realm immutable
Reviewed-by: xuelei
! src/share/classes/javax/security/auth/kerberos/KerberosPrincipal.java
! src/share/cl
tool.
-Sherman
On 7/10/2012 11:21 PM, Weijun Wang wrote:
Mostly fine.
1. "import java.text.FieldPosition;" is not needed anymore.
2. In jar/Main, you can also consider creating a separate
SimpleDateFormat object (maybe private final static?). It seems the
initialization is quite
means you can do your
own push but if you want to make any changes to the bug database, just
tell me.
Thanks
Max
On 07/11/2012 02:07 PM, Jonathan Lu wrote:
Hello Max,
Thanks a lot for review, here's the updated patch,
http://cr.openjdk.java.net/~luchsh/7163483_5/
On 07/10/2012 08:54
301 - 400 of 599 matches
Mail list logo
