.
-- The comments were added for each usage of the
JAVA_INVALID_HANDLE_VALUE macro.
-- 10 seconds time limit was rewritten to file signals.
Regards,
-uta
On 7/29/2013 2:32 AM, Alan Bateman wrote:
On 11/07/2013 02:03, Alexey Utkin wrote:
:
Bug description:
https://jbs.oracle.com/bugs/browse/JDK
Changeset: 40221b09812f
Author:uta
Date: 2013-08-02 13:16 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40221b09812f
8020191: System.getProperty(os.name) returns Windows NT (unknown) on
Windows 8.1
Reviewed-by: alanb, khazra, chegar
!
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-6518827
http://bugs.sun.com/view_bug.do?bug_id=6518827
Here is the suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-6518827/webrev.00/
Summary:
Here we close the long-standing problem of the lost empty
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-8020191
http://bugs.sun.com/view_bug.do?bug_id=8020191
Here is the suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8020191/webrev.00/
Summary:
We need to be consistent with the rest of OS, so I extend the case
On 7/30/2013 5:24 PM, Alan Bateman wrote:
On 29/07/2013 10:06, Alexey Utkin wrote:
Thanks, Alan
I did if reformatting and small refactoring for the code in
function in accordance with
https://jbs.oracle.com/bugs/browse/JDK-5008166
recommendations. I am sure that the presence of path
://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8021245/webrev.01/
The fix was tested in the debugger.
Regards,
-uta
On 7/28/2013 9:40 PM, Alan Bateman wrote:
On 26/07/2013 08:33, Alexey Utkin wrote:
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-8021245
http://bugs.sun.com/view_bug.do
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-8021245
http://bugs.sun.com/view_bug.do?bug_id=8021245
Here is the suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8021245/webrev.00/
Summary:
In accordance with MS spec [-1] is THE ONLY error signal from the
!)-
UTF16(Java) without information loss and has no dependance from user's
fantasy about system locale.
Regards,
-uta
Other changes look good to me. Thanks for fixing getLastErrorString
function in io_util_md.c file.
-Dan
On 07/17/2013 08:28 AM, Alexey Utkin wrote:
Thanks,
Here is new
api, and should really be pulled into some
common directory - but I don't know of any such.
On Tue, Jul 16, 2013 at 9:04 AM, Alexey Utkin
alexey.ut...@oracle.com mailto:alexey.ut...@oracle.com wrote:
Here is new version of fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK
WaitForMultipleObjects
fail report. You are right, all the calls return the problem by
GetLastMessage call.
The function is changed (reduced).
Here is new version of fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8016579/webrev.01/
Regards,
-uta
On Mon, Jul 15, 2013 at 2:41 AM, Alexey
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-8016579
http://bugs.sun.com/view_bug.do?bug_id=8016579
Here is the suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8016579/webrev.00/
Summary:
We have THREE locales in action:
1. Thread default locale - dictates
/InheritIOEHandle.java] was changed
in accordance with Martin's concern.
Regards,
-uta
On 7/5/2013 5:59 PM, Alan Bateman wrote:
On 05/07/2013 09:37, Alexey Utkin wrote:
Hi Alan,
I know that your stack is overflowed,
that is just ping.
Regards,
-uta
Sorry Alexey, I just have not had time to fully digest
Changeset: 956b00d7d4ea
Author:uta
Date: 2013-06-18 17:19 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/956b00d7d4ea
8016046: (process) Strict validation of input should be security manager case
only [win].
Reviewed-by: alanb, ahgross
!
Here is the changed version:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8016046/webrev.01/
On 6/7/2013 8:02 PM, Alan Bateman wrote:
On 07/06/2013 10:02, Alexey Utkin wrote:
Hi,
Please review the fix.
Bug description:
http://bugs.sun.com/view_bug.do?bug_id=8016046
https
Here is the changed version:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8016046/webrev.01/
On 6/7/2013 8:02 PM, Alan Bateman wrote:
On 07/06/2013 10:02, Alexey Utkin wrote:
Hi,
Please review the fix.
Bug description:
http://bugs.sun.com/view_bug.do?bug_id=8016046
https
Hi,
Please review the fix.
Bug description:
http://bugs.sun.com/view_bug.do?bug_id=8016046
https://jbs.oracle.com/bugs/browse/JDK-8016046
The suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8016046/webrev.00/
Summary:
In absence of the Security Manager the
Changeset: d78f91ab0e96
Author:uta
Date: 2013-05-27 15:18 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d78f91ab0e96
8014394: (fs) WatchService failing when watching \\server\$d
Reviewed-by: alanb
! src/windows/classes/sun/nio/fs/WindowsConstants.java
!
clear. (Webkit source-save server is a good example, but, yes, it isn't
on Windows.)
I rollback the changes in WindowsWatchService to avoid the blot.
Regards,
-uta
On 5/22/2013 11:58 PM, Alan Bateman wrote:
On 22/05/2013 17:07, Alexey Utkin wrote:
Bug description:
https://jbs.oracle.com/bugs
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-8014394
http://bugs.sun.com/view_bug.do?bug_id=8014394
Here is the suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8014394/webrev.00/
Summary:
The problem source is the ERROR_MORE_DATA warning event that was
for IDE's functionality. If
they have a hint for the problem, the hint may produce the regression.
Regards,
-uta
On 5/13/2013 6:44 PM, Alexey Utkin wrote:
Thanks, Martin!
You are right. The approach
private static String JAVA_EXE = System.getProperty(java.home)
+ File.separator
Changeset: 5ea5f5dfb96a
Author:uta
Date: 2013-05-14 20:16 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ea5f5dfb96a
8012453: (process) Runtime.exec(String) fails if command contains spaces [win]
Reviewed-by: alanb
! src/share/classes/java/lang/ProcessBuilder.java
!
Thanks, Martin!
You are right. The approach
private static String JAVA_EXE = System.getProperty(java.home)
+ File.separator + bin
+ File.separator + java;
private static String[] getCommandArray(String processName) {
String[] cmdArray = {
JAVA_EXE,
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-7147084
http://bugs.sun.com/view_bug.do?bug_id=7147084
Here is the suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7147084/webrev.00/
Summary:
I would like to describe the bug synopsis, common Java approach to
Windows
Alan,
Thanks for your comments.
I did the changes in code.
Please, read my answers below.
Here is fixed version:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8012453/webrev.02/
Regards,
-uta
On 24.04.2013 18:23, Alan Bateman wrote:
On 24/04/2013 13:58, Alexey Utkin wrote:
I changed
need to conserve backward compatibility for case of
the quoted executable name (that is the only secure way to run that you
like in legacy JDK) and provide the allowAmbigousCommands property as a
last resort.
Regards,
-uta
Martin
On Tue, Apr 23, 2013 at 6:22 AM, Alexey Utkin alexey.ut
.
-Alan
On 23/04/2013 14:22, Alexey Utkin wrote:
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-8012453
http://bugs.sun.com/view_bug.do?bug_id=8012453
Here is the suggested trivial fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8012453/webrev.00/
Summary
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-8012453
http://bugs.sun.com/view_bug.do?bug_id=8012453
Here is the suggested trivial fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8012453/webrev.00/
Summary:
--
Summary:
Since the changes
http://bjoern.hoehrmann.de/utf-8/decoder/dfa/
Verified on full UNICODE set.
Regards,
-uta
Changeset: fb23896a01f5
Author:uta
Date: 2013-03-20 13:21 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fb23896a01f5
8006193: (process) Clean-up java.lang.ProcessImpl.finalize, does not need to be
public
Reviewed-by: alanb
! src/windows/classes/java/lang/ProcessImpl.java
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-8006193
http://bugs.sun.com/view_bug.do?bug_id=8006193
Here is the suggested trivial fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8006193/
Summary:
Makes [FindBug] code analyzer happy.
-public void finalize() {
Changeset: e497a050e059
Author:uta
Date: 2013-03-13 13:22 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e497a050e059
7190897: (fs) Files.isWritable method returns false when the path is writable
(win)
Summary: The [GetEffectiveRightsFromAcl] based implementation was
, Alexey Utkin wrote:
Can I say two word about the file
http://cr.openjdk.java.net/~dxu/8001334/webrev.01/src/windows/native/java/io/io_util_md.c.frames.html
and function
getLastErrorString(char *buf, size_t len)
Here is the documentation for [FormatMessage]:
http://msdn.microsoft.com/en
Can I say two word about the file
http://cr.openjdk.java.net/~dxu/8001334/webrev.01/src/windows/native/java/io/io_util_md.c.frames.html
and function
getLastErrorString(char *buf, size_t len)
Here is the documentation for [FormatMessage]:
On 28.02.2013 19:41, Alan Bateman wrote:
On 28/02/2013 15:17, Alexey Utkin wrote:
That is not single, but 4 additional parameters ( FILE_GENERIC_READ,
FILE_GENERIC_WRITE, FILE_GENERIC_EXECUTE, FILE_ALL_ACCESS) - that are
relatively complicate masks. That parameters have to be changed
Hi,
Please review the fix.
Bug description:
http://bugs.sun.com/view_bug.do?bug_id=7190897
https://jbs.oracle.com/bugs/browse/JDK-7190897
The suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7190897/webrev.00/
Summary:
The isolated method for the file security
On 28.02.2013 18:31, Alan Bateman wrote:
On 28/02/2013 11:54, Alexey Utkin wrote:
:
The suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7190897/webrev.00/
Thanks for sorting this out, this code should have used AccessCheck in
the original implementation. A couple
Changeset: 0a2b308cc82d
Author:uta
Date: 2013-02-20 16:39 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a2b308cc82d
8007454: (process) SetHandleInformation parameters DWORD (not BOOLEAN)
Summary: the SetHandleInformation arguments list was fixed.
Reviewed-by: alanb
!
On 04.02.2013 18:25, Alan Bateman wrote:
On 04/02/2013 12:28, Alexey Utkin wrote:
Hi,
Please review the fix.
Bug description:
http://bugs.sun.com/view_bug.do?bug_id=8007454
https://jbs.oracle.com/bugs/browse/JDK-8007454
The suggested fix:
http://cr.openjdk.java.net/~uta/openjdk
Hi,
Please review the fix.
Bug description:
http://bugs.sun.com/view_bug.do?bug_id=8007454
https://jbs.oracle.com/bugs/browse/JDK-8007454
The suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8007454/webrev.01/
Summary:
Old version of code for the
in both jprt and via an ssh session to a
mac.
-Rob
On 25/01/13 16:07, Alexey Utkin wrote:
Looks good. Did you test the fix in ssh session to Mac?
-uta
On 25.01.2013 19:37, Rob McKenna wrote:
Had a chat with Alexey off list. Since 7162111 is indeed required
to get these tests running
Looks good. Did you test the fix in ssh session to Mac?
-uta
On 25.01.2013 19:37, Rob McKenna wrote:
Had a chat with Alexey off list. Since 7162111 is indeed required to
get these tests running on headless systems we've agreed to go ahead
with this fix. (but not 8004928) A webrev with this
Changeset: 01b36b400145
Author:uta
Date: 2013-01-23 15:06 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01b36b400145
6519127: user.home property not set correctly
Summary: Registry-based approach was changed to
SHGetKnownFolderPath/SHGetFolderPathW
Reviewed-by: alanb,
On 21.01.2013 20:01, Alan Bateman wrote:
On 18/01/2013 16:40, Alexey Utkin wrote:
The main difference is that after the fix Java becomes the program
that could be certified by MS as Vista comparable.
Java would support the dynamic user profiles and follow the changes
in Windows OS policy
in Client code.
However, I'll leave it up to Alan to decide if this is a good solution
for Core-libs.
--
best regards,
Anthony
On 1/22/2013 15:52, Alexey Utkin wrote:
Ok. Alan and Anthony,
would you like to be faster and follow optimistic strategy, that is
described here:
http
On 22.01.2013 16:52, Alan Bateman wrote:
On 22/01/2013 12:28, Alexey Utkin wrote:
To be clear, there are three options for a shell call:
1. Force folder creation if not exists (KF_FLAG_CREATE)
2. Return existent folder if any (0)
3. Return folder name without verification
:30, Alexey Utkin wrote:
On 22.01.2013 16:52, Alan Bateman wrote:
On 22/01/2013 12:28, Alexey Utkin wrote:
To be clear, there are three options for a shell call:
1. Force folder creation if not exists (KF_FLAG_CREATE)
2. Return existent folder if any (0)
3. Return folder name without
On 22.01.2013 19:58, Alan Bateman wrote:
On 22/01/2013 15:45, Anthony Petrov wrote:
Hi Alexey,
The fix looks good from code logic perspective.
I'm only concerned with whether we should use the __try/__except
magic, or would it rather make sense to define:
#define IS_WINVISTA
Hi Everyone,
Please review the fix.
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-6519127
Here is the suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-6519127/webrev.02/
1] The registry branch was removed from the code as obsolete. It was
actual only for
Changeset: a40052a54801
Author:uta
Date: 2013-01-15 14:26 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a40052a54801
8005250: Downgrade normative references to ${java.home}/lib folder from Java
client code.
Summary: Javadoc was changed in accordance with CCC-8005250
I am sorry. Seems that I am out of discussion context, but did we get
that sort of problem:
https://code.google.com/p/android/issues/detail?id=42265#c114
http://forum.xda-developers.com/showthread.php?t=1987032nocache=0
The article in Russian:
http://habrahabr.ru/post/164881/
Regards,
-uta
Thanks for explanation, Aleksey!
Regards,
-uta
On 07.01.2013 16:30, Aleksey Shipilev wrote:
Seriously doubt Android uses (recent) OpenJDK HashMap code, otherwise many
lawyers around the world would now be having heart attacks. Also,
java.util.Random is plain congruent PRNG, having nothing to
Looks good for me.
On 17.12.2012 22:46, Rob McKenna wrote:
Hi folks,
This review contains:
8003898: X11 toolkit can be chosen as the default toolkit
7162111: TEST_BUG: change tests run in headless mode [macosx] (open)
8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT
Changeset: a02212de8db6
Author:uta
Date: 2012-12-17 14:34 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a02212de8db6
8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem
Summary: the tests were refactored to drop AWT dependence where it was possible.
On 13.12.2012 20:59, Alan Bateman wrote:
One other one that I ran into today is this one:
test/java/lang/Throwable/LegacyChainedExceptionSerialization.java
It uses java.awt.print.PrinterIOException and I think that can be
safely removed. Do you think this could be included in your changes?
On 12.12.2012 20:52, Daniel D. Daugherty wrote:
On 12/12/12 9:47 AM, Alan Bateman wrote:
On 12/12/2012 16:36, Daniel D. Daugherty wrote:
For this item:
test/java/util/logging/LoggingDeadlock4.java
Test case was simplified to avoid AWT class loading.
Negative test
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-8004928
Here is the suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8004928/webrev.01
Summary:
*test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java*
I need the second reviewer.
-uta
On 23.11.2012 15:57, Alan Bateman wrote:
On 23/11/2012 11:40, Alexey Utkin wrote:
I mean:
# jdk_io
-# 7162111 - these tests need to be updated to run headless
-java/io/Serializable/resolveClass/deserializeButton/run.sh macosx-all
-java/io/Serializable
Changeset: 8970128e040d
Author:uta
Date: 2012-11-26 15:54 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8970128e040d
7162111: TEST_BUG: change tests run in headless mode [macosx] (open)
Summary: In problem tests detection of AWT headless mode was introduced or AWT
Changeset: ee6e5b7d5d55
Author:uta
Date: 2012-11-23 13:07 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee6e5b7d5d55
8003898: X11 toolkit can be chosen as the default toolkit
Summary: XToolkit is not selected for any values of system-wide environment
variables (ex.
:38, Alexey Utkin wrote:
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-7162111
Here is the suggested fix that contains the changes in
JFrameCreateTime.java:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/webrev.02
The changes to test/java/io/Serializable/resolveClass
On 23.11.2012 14:58, Alan Bateman wrote:
On 23/11/2012 10:40, Alexey Utkin wrote:
The sub-task JDK-8003898 (X11 toolkit can be chosen as the default
toolkit) was resolved.
New version that takes it into account (changes in TraceJFrame.java):
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK
On 23.11.2012 15:24, Alan Bateman wrote:
On 23/11/2012 11:22, Alexey Utkin wrote:
On 23.11.2012 14:58, Alan Bateman wrote:
On 23/11/2012 10:40, Alexey Utkin wrote:
The sub-task JDK-8003898 (X11 toolkit can be chosen as the default
toolkit) was resolved.
New version that takes it into account
On 22.11.2012 12:41, Alan Bateman wrote:
On 22/11/2012 07:38, Alexey Utkin wrote:
:
I take in account the AWT problem on Mac OS:
in ssh session due to compatibility reason AWT switches to X11
toolkit if DISPLAY variable is defined.
But Mac OS implementation of X11 toolkit has a deadlock
the X11 toolkit support is obsolete and problem would be
resolved by AWT team.
Regards,
-uta
On 19.11.2012 20:57, Alan Bateman wrote:
On 19/11/2012 14:54, Alexey Utkin wrote:
Here is the updated version:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/webrev.01/
In Foo.java
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-7162111
Here is the suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/
Summary:
Tests that are not changed and pass successfully (all tests run for jdk8):
Here is the updated version:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/webrev.01/
On 19.11.2012 16:26, Alan Bateman wrote:
On 19/11/2012 09:57, Alexey Utkin wrote:
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-7162111
Here is the suggested fix:
http
Let's move forward step by step and be very accurate.
There are ~35 CoreLib tests with AWT/Swing.
Here they are with short annotation (sub-question: is
[closed/com/sun/jmx] a part of CoreLib? It is not in your list.):
*closed/com/sun/jmx/snmp/B7159066.java : *
test for AppContext - Useless in
67 matches
Mail list logo
