Hi!
Any love out there for my review request?
Cheers,
-Buck
On 2017/12/15 14:42, David Buck wrote:
Hi!
May I please get a review of the following very simple backport of this
serviceability improvement to JDK 8?
The two hotspot jtreg test cases needed to be modified slightly because
of
Hi!
May I please get a review of the following very simple backport of this
serviceability improvement to JDK 8?
The two hotspot jtreg test cases needed to be modified slightly because
of the lack of dcmd-specific test support in JDK 8's HS code base. The
only non-test difference from the JD
approved for push to 8u-dev
Cheers,
-Buck
On 2017/03/23 17:55, Seán Coffey wrote:
Looks good.
regards,
Sean.
On 23/03/2017 00:26, Ivan Gerasimov wrote:
Hello!
This is an 8u-dev only fix.
(In 9 the bug was fixed with a massive update [1]).
The fix is essentially one-liner: just check that
approved for push to 8u-dev (contingent on successful code review)
I have added the core libraries alias for what will hopefully be a
trivial code review process.
Cheers,
-Buck
On 2017/01/11 22:01, Aleks Efimov wrote:
Hello,
Please, approve a backport of JDK-8159058 to JDK8u-dev. This is
Hi!
May I please have a review of this fix:
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8064516
WEBREV: http://cr.openjdk.java.net/~dbuck/8064516/webrev00/
Cheers,
-Buck
Hi!
May I please have a review of this fix:
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8062608
WEBREV: http://cr.openjdk.java.net/~dbuck/8062608/webrev.00/
Cheers,
-Buck
Changeset: 3f766f58c48a
Author:dbuck
Date: 2013-01-31 10:55 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f766f58c48a
7042126: (alt-rt) HashMap.clone implementation should be re-examined
Summary: Test case for cr7042126. Issue only found in OracleJDK, but test case
is vali
e the potentially "leaky" operation;
- Trigger gc with after check of WeakReference. Maybe a couple of times.
- If that does not clear the reference, fill-in heap until OOME is thrown and
after that check the reference.
Regards, Peter
On 01/31/2013 10:40 AM, David Buck wrote:
Hi!
I was
acceptable for pushing.
http://cr.openjdk.java.net/~dbuck/7042126/webrev.01/
Cheers,
-Buck
On 2013/01/31 23:05, Alan Bateman wrote:
On 31/01/2013 09:40, David Buck wrote:
Hi!
I was curious to see what others have done in the past and took a look
at about 15 different testcases for memory leaks in
ness
of the JVM has somehow regressed.
I plan to modify my testcase to follow pattern C and resubmit for
review. If anyone has any other ideas or comments, I would be grateful
for your input.
Cheers,
-Buck
On 2013/01/30 22:32, David Buck wrote:
Hi Alan!
Thank you for your help.
TL;DR version
ed to
be extra cautious. What do you think?
> Minor nit, should be WeakReference to avoid the raw type.
I will update the webrev once we have decided what (if anything) to do
regarding the risk of false positives.
Cheers,
-Buck
On 2013/01/30 22:09, Alan Bateman wrote:
On 29/01/2013 23:36
Hi!
This is a review request to add only the test case for the following
OracleJDK issue :
[ 7042126 : (alt-rt) HashMap.clone implementation should be re-examined ]
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7042126
* please note: I just marked the bug as "public" this morning, so the
Thanks,
Joe
On 12/9/2012 10:25 PM, David Buck wrote:
Hi!
I would like to request a code review of my JDK8 fix for the following
issue:
[ 8003147 : port fix for BCEL bug 39695 to our copy bundled as part of
jaxp ]
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003147
In addition to the f
Hi!
I would like to request a code review of my JDK8 fix for the following
issue:
[ 8003147 : port fix for BCEL bug 39695 to our copy bundled as part of
jaxp ]
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003147
In addition to the fix that the BCEL project had for this issue, I
need
uld someone please review this new version of the test case?
Cheers,
-Buck
On 11/16/12 11:45, Mike Duigou wrote:
Looks like a good test to me as well. The one possible addition is to check
that m1 hasn't been modified after the mutation of m2.
Mike
On Nov 14 2012, at 05:38 , David Buck wr
Hi!
This is a review request to add only the test case for the following
OracleJDK issue:
[ 7198904 : (alt-rt) TreeMap.clone is broken ]
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198904
The issue (root cause) is not in OpenJDK (i.e. the problem was OracleJDK
specific), but the test
16 matches
Mail list logo
