On Wed, 11 May 2022 12:59:49 GMT, Magnus Ihse Bursie wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8244681: Add a warning for possibly lossy conversion in compound
>> assignments
>> recommended correction of th
On Wed, 11 May 2022 07:45:39 GMT, Adam Sotona wrote:
>> Please review this patch adding new lint option, **lossy-conversions**, to
>> javac to warn about type casts in compound assignments with possible lossy
>> conversions.
>>
>> The new lint warning is shown if the type of the right-hand ope
On Fri, 29 Apr 2022 18:27:27 GMT, Mikhailo Seledtsov
wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
> test/jdk/jdk/jfr/api/consumer/TestManyRecordings.java line
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Wed, 30 Mar 2022 02:56:41 GMT, Vicente Romero wrote:
>> Please review this PR which is updating the ASM included in the JDK to ASM
>> 9.2. This version should be included in JDK19. There are basically two
>> commits here, one that was automatically generated and that mostly changes
>> file
On Wed, 19 Jan 2022 09:19:00 GMT, Matthias Baesken wrote:
> Very small change fixing wrong strings "Falied" in a couple of tests.
Marked as reviewed by egahlin (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7142
On Thu, 13 Jan 2022 08:39:04 GMT, Andrey Turbanov wrote:
>> Method `Class.isAssignableFrom` is often used in form of:
>>
>> if (clazz.isAssignableFrom(obj.getClass())) {
>> Such condition could be simplified to more shorter and performarnt code
>>
>> if (clazz.isInstance(obj)) {
>>
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Thu, 2 Dec 2021 08:21:30 GMT, Aleksey Shipilev wrote:
> All right then. Thanks for followups!
>
> @egahlin, @mgronlun: this affects JFR tests a bit, subsumes `jfr_tier_3` into
> `tier3`, basically. Are you good with this?
Seems reasonable.
I'm reluctant to become (R)eviewer on this, since
On Fri, 27 Aug 2021 15:23:35 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
>> replace and mitigate Object.finalize() uses in the JDK libraries; please see
>> https://bugs.openjdk.java.net/browse/JDK-8253568 for more info
On Fri, 8 Oct 2021 23:31:32 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
On Wed, 8 Sep 2021 13:00:17 GMT, Erik Gahlin wrote:
> Hi,
>
> Could I have a review of change that prevents invalid Java identifiers or
> type names in JFR events. For rationale and compatibility issues see the CSR
> request. The only change to java
Hi,
Could I have a review of change that prevents invalid Java identifiers or type
names in JFR events. For rationale and compatibility issues see the CSR
request. The only change to java.base is making
jdk.modules.internal.Checks::isJavaIdentifier(String) public, so it can be
reused by the jd
On Tue, 18 May 2021 22:41:06 GMT, Brent Christian wrote:
>> Please review this enhancement to add a new JFR event, generated whenever a
>> finalizer is run.
>> (The makeup is similar to the Deserialization event,
>> [JDK-8261160](https://bugs.openjdk.java.net/browse/JDK-8261160).)
>>
>> The ev
On Wed, 21 Apr 2021 22:38:32 GMT, Erik Gahlin wrote:
>> Jaroslav Bachorik has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
> I wonder
On Tue, 18 May 2021 22:41:06 GMT, Brent Christian wrote:
>> Please review this enhancement to add a new JFR event, generated whenever a
>> finalizer is run.
>> (The makeup is similar to the Deserialization event,
>> [JDK-8261160](https://bugs.openjdk.java.net/browse/JDK-8261160).)
>>
>> The ev
On Tue, 18 May 2021 22:41:06 GMT, Brent Christian wrote:
>> Please review this enhancement to add a new JFR event, generated whenever a
>> finalizer is run.
>> (The makeup is similar to the Deserialization event,
>> [JDK-8261160](https://bugs.openjdk.java.net/browse/JDK-8261160).)
>>
>> The ev
On Mon, 3 May 2021 13:16:06 GMT, Jaroslav Bachorik
wrote:
>> With this change it becomes possible to surface various cgroup level metrics
>> (available via `jdk.internal.platform.Metrics`) as JFR events.
>>
>> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
>> turne
On Thu, 22 Apr 2021 16:00:32 GMT, Jaroslav Bachorik
wrote:
>> With this change it becomes possible to surface various cgroup level metrics
>> (available via `jdk.internal.platform.Metrics`) as JFR events.
>>
>> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
>> turn
On Wed, 21 Apr 2021 13:34:28 GMT, Jaroslav Bachorik
wrote:
>> With this change it becomes possible to surface various cgroup level metrics
>> (available via `jdk.internal.platform.Metrics`) as JFR events.
>>
>> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
>> turn
On Wed, 14 Apr 2021 14:32:32 GMT, Severin Gehwolf wrote:
>> This is taken as reported by cgroups - I didn't want to change the semantics
>> so it does not confuse people familiar with cgroups.
>
> I don't see this event field being set anywhere? Which Metrics API call is
> this using?
How does
On Wed, 14 Apr 2021 08:28:01 GMT, Jaroslav Bachorik
wrote:
>> src/jdk.jfr/share/conf/jfr/default.jfc line 1051:
>>
>>> 1049: false
>>> 1050:
>>> 1051: true
>>
>> I don't think we should create "flag" for "Container Events". Instead we
>> should treat them like CPU and other OS ev
On Wed, 14 Apr 2021 12:14:33 GMT, Jaroslav Bachorik
wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/events/ContainerCPUThrottlingEvent.java
>> line 44:
>>
>>> 42: @Category({"Operating System", "Container", "Processor"})
>>> 43: @Description("Container CPU throttling related information.")
>>> 44:
On Sun, 18 Apr 2021 15:17:35 GMT, Erik Gahlin wrote:
> Hi,
>
> Could I have a review of fix that removes the use of "=" together with
> -XX:StartFlightRecording and -XX:FlightRecorderOptions. It's been possible to
> use "-XX:StartFlightRecording:" and &
On Mon, 19 Apr 2021 20:16:59 GMT, Chris Plummer wrote:
> The changes look good. Have you considered doing a test run where the use of
> `=` and `XX:+FlightRecorder` are disallowed just to make sure you caught them
> all?
It's a good idea, but it requires changes outside OpenJDK which I rather
t; introduced into OpenJDK (JDK 11), so this is not a change of the
> specification, just an update to make the use consistent in tests, comments,
> documentation etc.
>
> I also removed the use of -XX:+FlightRecorder, which is not needed, and has
> been deprecated since JDK 13.
Hi,
Could I have a review of fix that removes the use of "=" together with
-XX:StartFlightRecording and -XX:FlightRecorderOptions. It's been possible to
use "-XX:StartFlightRecording:" and "-XX:FlightRecorderOption:" since JFR was
introduced into OpenJDK (JDK 11), so this is not a change of the
On Wed, 14 Apr 2021 08:31:55 GMT, Jaroslav Bachorik
wrote:
>> With this change it becomes possible to surface various cgroup level metrics
>> (available via `jdk.internal.platform.Metrics`) as JFR events.
>>
>> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
>> turn
On Wed, 14 Apr 2021 08:28:37 GMT, Jaroslav Bachorik
wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line
>> 163:
>>
>>> 161: private static void initializeContainerEvents() {
>>> 162: containerMetrics = Container.metrics();
>>> 163: if (contai
On Fri, 2 Apr 2021 12:33:03 GMT, Jaroslav Bachorik
wrote:
>> With this change it becomes possible to surface various cgroup level metrics
>> (available via `jdk.internal.platform.Metrics`) as JFR events.
>>
>> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
>> turne
On Wed, 24 Mar 2021 18:39:06 GMT, Severin Gehwolf wrote:
>> With this change it becomes possible to surface various cgroup level metrics
>> (available via `jdk.internal.platform.Metrics`) as JFR events.
>>
>> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
>> turned
On Fri, 12 Feb 2021 16:26:09 GMT, Chris Hegarty wrote:
>> This issue adds a new event to improve diagnostic information of Java
>> deserialization. The event captures the details of deserialization activity
>> from ObjectInputStream. The event details are similar to that of the serial
>> filte
On Tue, 9 Feb 2021 12:35:27 GMT, Chris Hegarty wrote:
> This issue adds a new event to improve diagnostic information of Java
> deserialization. The event captures the details of deserialization activity
> from ObjectInputStream. The event details are similar to that of the serial
> filter, bu
On Wed, 23 Sep 2020 18:41:06 GMT, Philippe Marschall
wrote:
>> Hello, newbie here
>>
>> I picked JDK-8138732 to work on because it has a "starter" label and I
>> believe I understand what to do.
>>
>> - I tried to update the copyright year to 2020 in every file.
>> - I decided to change `@sin
On Sat, 12 Sep 2020 00:19:00 GMT, Vladimir Kozlov wrote:
>> Philippe Marschall has refreshed the contents of this pull request, and
>> previous commits have been removed. The
>> incremental views will show differences compared to the previous content of
>> the PR. The pull request contains one
Hi Sundar,
Will there be a replacement for Nashorn, i.e. V8 with added Java bindings?
I am asking because one of the JFR test uses Nashorn for parsing JSON and if
another parser is coming in the near future, it could be used. instead of
adding a parser for the test.
Thanks
Erik
> On 16 Apr 20
Yes, I can sponsor it.
Erik
> On 1 Apr 2020, at 16:43, Alan Bateman wrote:
>
> On 31/03/2020 17:22, Denghui Dong wrote:
>> Hi Erik,
>>
>> IMO, one event type per pool is a better choice, because:
>> 1. easy filtering and configuration as you said, and I don't think there
>> will be too many b
t; On 31 Mar 2020, at 11:06, Denghui Dong <mailto:denghui@alibaba-inc.com>> wrote:
>
> PING.
>
> @Erik Could you review it?
>
> Denghui Dong
>
>
>
> ------
> From:董登辉(卓昂) <mailto:denghui@alibaba-inc.com>>
> Sen
and a field would be better.
Erik
> On 31 Mar 2020, at 11:06, Denghui Dong wrote:
>
> PING.
>
> @Erik Could you review it?
>
> Denghui Dong
>
>
>
> --
> From:董登辉(卓昂)
> Send Time:2020年3月
@oracle.com>>
Send Time:2020年3月5日(星期四) 16:46
To:董登辉(卓昂) mailto:denghui@alibaba-inc.com>>; Erik Gahlin
mailto:erik.gah...@oracle.com>>;
hotspot-jfr-dev mailto:hotspot-jfr-...@openjdk.java.net>>; core-libs-dev
mailto:core-libs-dev@openjdk.java.net>>
e less ambiguous. (and Arrays.toString).
Otherwise, looks fine to me.
Is there already a Process exited event? Its not quite as convenient
to instrument but useful if it captures the exit status. (ProcessImpl
- Windows and Linux versions).
Roger
On 3/5/20 9:10 AM, Erik Gahlin wrote:
Hi
Co
Hi
Could I have review of a JFR event that is emitted when a process is
started from Java.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8222000
Webrev:
http://cr.openjdk.java.net/~egahlin/8222000/
Testing:
tier1,tier2 + jdk/jdk/jfr
Thanks
Erik
teman
> Send Time:2020年3月5日(星期四) 16:46
> To:董登辉(卓昂) ; Erik Gahlin
> ; hotspot-jfr-dev ;
> core-libs-dev
> Subject:Re: RFR: 8238665: Add JFR event for direct memory statistics
>
> On 05/03/2020 02:44, Denghui Dong wrote:
> > Hi Erik,
> > Upd
ange “5000 ms” to “5 s” in the .jfc
> files. When you reply with the updated patch, could you please include
> core-libs-dev@openjdk.java.net <mailto:core-libs-dev@openjdk.java.net> in the
> reply since you are modifying exports in java.base.
>
> Thanks
> Erik
>
&g
On 2019-01-17 09:00, Alan Bateman wrote:
On 17/01/2019 07:23, Thomas Stüfe wrote:
:
Do you object against keeping these counters (which basically boils
down to Thread::current->stat_structure->counter++)? Or do you even
object against making upcalls into the jvm? Note that, if deemed
necessa
Looks good.
Erik
> On 22 Nov 2018, at 16:01, Markus Gronlund wrote:
>
> Greetings,
>
> Please review the following small fix.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214161
> Webrev: http://cr.openjdk.java.net/~mgronlun/8214161/webrev01/
>
> diff -r 0a77b7e41322 -r cec1604a9b89
removed the variable names using underscore. Also optimized
some variable assignments in X509Impl.commitEvent(..)
http://cr.openjdk.java.net/~coffeys/webrev.8148188.v5/webrev/
regards,
Sean.
On 09/07/2018 18:01, Seán Coffey wrote:
Erik,
Thanks for reviewing. Comments inline..
On 09/07/18 17:21, Eri
JFR changes looks good.
Erik
> On 3 Oct 2018, at 19:56, Mandy Chung wrote:
>
> This patch replaces java.lang.invoke and JFR use of
> jdk.internal.misc.Unsafe::defineClass with Lookup::defineClass.
> It also replaces dynamic proxy and reflection implementation to
> use the shared secret to invok
ations carried out to
clean up the code up further.
http://cr.openjdk.java.net/~coffeys/webrev.8148188.v5/webrev/
This enhancement has a dependency on JDK-8203629
Regards,
Sean.
On 02/07/18 09:49, Erik Gahlin wrote:
On 29 Jun 2018, at 17:34, Seán Coffey wrote:
I've introduced a new test he
ffeys/webrev.8148188.v4/webrev/
>
> Regards,
> Sean.
>
> On 28/06/18 17:59, Seán Coffey wrote:
>> Comments inline.
>>
>>
>> On 28/06/2018 17:20, Erik Gahlin wrote:
>>> It's sufficient if an event object escapes to another method (regardless if
result the event class shouldn't
escape. If performance metrics highlight an issue, we should revisit.
regards,
Sean.
On 27/06/2018 20:57, Erik Gahlin wrote:
On 2018-06-27 21:14, Seán Coffey wrote:
On 27/06/2018 19:57, Xuelei Fan wrote:
Hi Sean,
I may reply in seve
for the review comments Erik. Replies inline.
On 24/06/2018 14:21, Erik Gahlin wrote:
Hi Sean,
Some of the changes in the webrev belongs to JDK-8203629 and
should be removed for clarity.
Some initial comments:
default.jfc, profile.jfr:
The events should not have control="enable-excepti
On 2018-06-24 19:00, Alan Bateman wrote:
On 24/06/2018 12:42, Erik Gahlin wrote:
I have updated jdk.internal.event.Event class with comments.
http://cr.openjdk.java.net/~egahlin/8203629.2/
It is basically a copy the comments in jdk.jfr.Event, but without
reference to classes in the JFR
Hi Sean,
Some of the changes in the webrev belongs to JDK-8203629 and should be
removed for clarity.
Some initial comments:
default.jfc, profile.jfr:
The events should not have control="enable-exceptions". The purpose of
the control attribute is so to provide parameterized configuration of
On 2018-06-21 09:52, Alan Bateman wrote:
On 20/06/2018 18:59, Erik Gahlin wrote:
:
Also all the methods are empty which makes me wonder if they should
be abstract (as the class is abstract) or whether it should be an
interface.
Abstract is needed to prevent user from instantiating the class
n
that front.
Regards,
Sean.
On 19/06/18 03:06, Erik Gahlin wrote:
Hi,
Could I have a review of an enhancement that will make it possible to
add JFR events to java.base, and possibly other modules in the JDK,
without a compile time dependency on jdk.jfr.
Bug:
https://bugs.openjdk.java.net/br
On 2018-06-20 19:09, Alan Bateman wrote:
On 19/06/2018 03:06, Erik Gahlin wrote:
Hi,
Could I have a review of an enhancement that will make it possible to
add JFR events to java.base, and possibly other modules in the JDK,
without a compile time dependency on jdk.jfr.
Bug:
https
Hi,
Could I have a review of an enhancement that will make it possible to
add JFR events to java.base, and possibly other modules in the JDK,
without a compile time dependency on jdk.jfr.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8203629
Webrev:
http://cr.openjdk.java.net/~egahlin/820362
Hi Robin,
I can sponsor this.
I wonder if we should change the name of the event to "Shutdown"
instead? It will give us flexibility to add other shutdown related
fields in the future.
Could you change the label and field to "Status Code" and statusCode.
Event fields should have headline-st
Looks good!
Erik
Yekaterina Kantserova skrev 2014-05-20 15:48:
Thanks Staffan!
New webrev can be found here:
http://cr.openjdk.java.net/~ykantser/8043520/webrev.01/
// Katja
On 05/20/2014 03:07 PM, Staffan Larsen wrote:
test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.
Changeset: 91ec3bc92793
Author:egahlin
Date: 2013-11-21 13:46 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/91ec3bc92793
6402201: ProcessAttachTest.sh needs better synchronization
Reviewed-by: alanb
! test/ProblemList.txt
! test/com/sun/jdi/ProcessAttachDebuggee.java
! test
Changeset: 894a4bae9e33
Author:egahlin
Date: 2013-11-20 12:32 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/894a4bae9e33
7141544: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails
Reviewed-by: sla
! test/com/sun/jdi/BreakpointWithFullGC.sh
Changeset: d6195774dd1f
Author:egahlin
Date: 2013-11-19 11:47 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6195774dd1f
8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on
ProblemList.txt
Reviewed-by: alanb
! test/ProblemList.txt
Changeset: 256b3395346b
Author:egahlin
Date: 2013-11-13 18:41 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/256b3395346b
6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh
Reviewed-by: sla, sspitsyn
! test/com/sun/jdi/BreakpointWithFullGC.sh
Changeset: ddaa9a8acaed
Author:egahlin
Date: 2013-11-13 15:21 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddaa9a8acaed
6959636: testcase failing on windows
javax/management/loading/LibraryLoader/LibraryLoaderTest.java
Reviewed-by: sla, jbachorik
! test/ProblemList.txt
!
Changeset: d9f827e4d20c
Author:egahlin
Date: 2013-11-12 18:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d9f827e4d20c
6849945: VM Periodic Task Thread CPU time = -1ns in
HotspotThreadMBean.getInternalThreadCpuTimes()
Reviewed-by: sla
! test/sun/management/HotspotThreadM
Changeset: 4cff9f59644f
Author:egahlin
Date: 2013-11-12 17:40 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4cff9f59644f
6543856: MonitorVmStartTerminate.sh fails intermittently
Reviewed-by: sla, dholmes
! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java
!
Changeset: 41dcb0c2e194
Author:egahlin
Date: 2013-11-12 14:52 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41dcb0c2e194
8027209: javax/management/monitor/ThreadPoolAccTest.java fails intermittently
Reviewed-by: sla, jbachorik
! test/javax/management/monitor/ThreadPoolAccTe
Changeset: c077a2810782
Author:egahlin
Date: 2013-10-23 10:50 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c077a2810782
7105883: JDWP: agent crash if there exists a ThreadGroup with null name
Reviewed-by: sla, jbachorik
! src/share/back/ThreadGroupReferenceImpl.c
+ test/co
70 matches
Mail list logo
