Re: RFR: JDK-8224597: create automated tests for platform create-app-image options

On 6/7/19 9:52 AM, Alexey Semenyuk wrote: Not quite exactly what I meant by suggesting to use xml api. Sorry for not being specific. With DOM and Xpath this can be as simple as the following: XPath is DOM based = slow. That point is not clear. --Semyon --- package sample; import

RFR: 8223402: Create tests for some Mac installer specific options

bug: https://bugs.openjdk.java.net/browse/JDK-8223402 webrev: http://cr.openjdk.java.net/~ssadetsky/8223402/webrev.00/ By this change tests added for jpackage Mac specific options: --mac-bundle-name --mac-bundle-identifier --mac-app-store-category --Semyon

RFR: JDK-8223318: jpackage --mac-bundle-name option doesn't work

bug: https://bugs.openjdk.java.net/browse/JDK-8223318 webrev: http://cr.openjdk.java.net/~ssadetsky/8223318/webrev.00/ The fix adds reading of --mac-bundle-name option to the application image builder. --Semyon

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

The --mac-app-store-entitlements option was only used for the Mac App Store deployment. Since it is not supported anymore this option is not used anywhere and need to be removed. Also the jdk.jpackage.internal. MacAppStoreBundler class and related resources are the dead code. --Semyon On

RFR: JDK-8223038: JPackage code signing fails on Mac.

bug: https://bugs.openjdk.java.net/browse/JDK-8223038 webrev: http://cr.openjdk.java.net/~ssadetsky/8223038/webrev.00/ This is a regression of 8219683 where Java runtime was moved out from PlugIns which made codesign unable to detect the bundle type. The fix points codesign to the valid path

RFR: JDK-8219683: Investigate App Image layout on Mac

bug: https://bugs.openjdk.java.net/browse/JDK-8219683 webrev: http://cr.openjdk.java.net/~ssadetsky/8219683/webrev.00/ The fix moves Java runtime form Contents/PlugIns/Java.runtime to Contents/Java.runtime. --Semyon

Re: RFE: JDK-8217895: jpackage --identifier purpose

On 4/12/19 4:51 AM, Andy Herrick wrote: On 4/11/2019 6:06 PM, semyon.sadet...@oracle.com wrote: On 4/11/19 12:05 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1]

Re: RFE: JDK-8217895: jpackage --identifier purpose

On 4/11/19 12:05 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8217895 [2] http://cr.openjdk.java.net/~herrick/8217895/

RFR: JDK-8221876:[macOS] JPackage install takes long time

Hello, bug: https://bugs.openjdk.java.net/browse/JDK-8221876 webrev: http://cr.openjdk.java.net/~ssadetsky/8221876/webrev.00/ The fix eliminate delay in install which is caused by postinstall script introduced in 8215241 when it set permissions for large number of files. Actually setting

RFR: JDK-8208652: JPackageCreateInstallerFileAssociationsTest.java fails on Mac.

Hello, bug: https://bugs.openjdk.java.net/browse/JDK-8208652 webrev: http://cr.openjdk.java.net/~ssadetsky/8208652/webrev.00 It is a fix for a test issue on Mac. Unlikely other platforms Mac platform sends the file path to open in a special OS OpenFile event the application should handle.

Re: RFR: JDK-8221582: Rename jvm-args option to java-options

It looks like one was missed: src/demo/share/jpackage/JNLPConverter/src/jnlp/converter/JNLPConverter.java 609launchArgs.add("--jvm-args"); --Semyon On 3/28/19 8:59 AM, Victor D'yakov wrote: Alexander, Semyon, please review. Victor Forwarded Message Subject:

RFR: JDK-8215241: Permissions are not set correctly on sub-folders in /Applications

bug: https://bugs.openjdk.java.net/browse/JDK-8215241 webrev: http://cr.openjdk.java.net/~ssadetsky/8215241/webrev.00/ The fix adds preinstall/postinstall scripts to the created package which ensure that installation dir is created

Re: [9] RFR 8138838: docs cleanup for java.desktop

Hi Alexander, Since you are doing cosmetic changes, could please wrap the amended lines to 80 characters per line? Also some notes: MultiResolutionImage.java interface has a mix of verbose/implicit method modifiers. It would be nice to reduce it to the uniform style. MenuComponent.java :