Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

2017-06-14 Thread Hamlin Li
Also disable to run ParallelPrefix.java in concurrency. Ok. Please check the new webrev: http://cr.openjdk.java.net/~mli/8179242/webrev.01/ 29 * @run testng/othervm -Xms256m -Xmx1024m ParallelPrefix Why are you setting the max heap size? In my test result, 1024M is sufficient, and if

Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

2017-06-14 Thread Paul Sandoz
> On 13 Jun 2017, at 18:08, Hamlin Li wrote: > > Hi Paul, > > Please check my comments inline below. > > > On 2017/6/14 1:23, Paul Sandoz wrote: >>> On 12 Jun 2017, at 20:37, Hamlin Li wrote: >>> >>> Hi Paul, >>> >>> Good idea. Although the downside is the test will depend on java.manageme

Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

2017-06-13 Thread Hamlin Li
Hi Paul, Please check my comments inline below. On 2017/6/14 1:23, Paul Sandoz wrote: On 12 Jun 2017, at 20:37, Hamlin Li wrote: Hi Paul, Good idea. Although the downside is the test will depend on java.management and jdk.management modules, I think it's acceptable. Although to Roger’s p

Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

2017-06-13 Thread Hamlin Li
Hi Roger, Runtime.maxMemory() is for the memory JVM is trying to use, e.g. if you set -Xmx128M then you get 128M. But what we try to do is to avoid running large array size test when total physical memory of system is lower than 2G, to get total physical memory I think OperatingSystemMXBean

Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

2017-06-13 Thread Paul Sandoz
> On 12 Jun 2017, at 20:37, Hamlin Li wrote: > > Hi Paul, > > Good idea. Although the downside is the test will depend on java.management > and jdk.management modules, I think it's acceptable. > Although to Roger’s point is there a simpler way? > Also disable to run ParallelPrefix.java in

Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

2017-06-13 Thread Roger Riggs
Hi Hamlin, For max memory is Runtime.maxMemory insufficient? Thanks, Roger On 6/12/2017 11:37 PM, Hamlin Li wrote: Hi Paul, Good idea. Although the downside is the test will depend on java.management and jdk.management modules, I think it's acceptable. Also disable to run ParallelPrefix.ja

Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

2017-06-12 Thread Hamlin Li
Hi Paul, Good idea. Although the downside is the test will depend on java.management and jdk.management modules, I think it's acceptable. Also disable to run ParallelPrefix.java in concurrency. Please check the new webrev: http://cr.openjdk.java.net/~mli/8179242/webrev.01/ Thank you -Haml

Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

2017-06-12 Thread Paul Sandoz
Hi Hamlin, Do you know if it is possible to adjust the array sizes based on max memory thresholds? For example in the os.maxMemory is less than 2g then omit the LARGE_ARRAY_SIZE from the test (assuming that reduces the memory pressure, which it likely should). Paul. > On 12 Jun 2017, at 02:3

(10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

2017-06-12 Thread Hamlin Li
Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8179242 webrev: http://cr.openjdk.java.net/~mli/8179242/webrev.00/ Thank you -Hamlin the test takes about 700M on linux 64, so propo