Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

> On 11 Dec 2016, at 06:04, Vincent Ryan wrote: > > Unfortunately this feature has arrived a little too late so I’m withdrawing > it from consideration for JDK 9. > Thanks again to those who took time to review it. > +1 to defer to 10 (and review comments are of

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

Unfortunately this feature has arrived a little too late so I’m withdrawing it from consideration for JDK 9. Thanks again to those who took time to review it. > On 10 Dec 2016, at 01:02, Vincent Ryan wrote: > > Thanks to those who provided review comments. > > I

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

Hi Vincent, 177 public static Stream dumpToStream(byte[] bytes, int fromIndex, 178 int toIndex) { 179 Objects.requireNonNull(bytes); 180 Arrays.rangeCheck(bytes.length, fromIndex, toIndex); 181 182 return StreamSupport.stream( 183

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

Hello, i would agree that a hexdumper is too specific for java.base module. But what about hex encoding and parsing (similiar to java.util.Base64. Since java.xml.bind is no longer in the base modules an alternative for DataTypeConverter in SE is missing. Gruss Bernd --

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

Hi Vinnie, I think this doesn't belong in the java.base module; it doesn't add enough value for a average developer and it is not essential to the core. I don't have another module suggestion but would suggest looking elsewhere. $.02, Roger On 12/9/2016 8:02 PM, Vincent Ryan wrote:

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

Thanks to those who provided review comments. I have incorporated most of them and updated the webrev: http://cr.openjdk.java.net/~vinnie/8170769/webrev.01/ The main changes are to tighten up the javadoc spec and to add three additional methods to support byte array ranges. The total number

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

Thanks for your review comments Paul. Responses below. > On 8 Dec 2016, at 20:08, Paul Sandoz wrote: > > Hi, > > It may take a few iterations to get the API settled. > > There are other byte sources we may want to consider such as InputStream and > ByteBuffer. I’d

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

Thanks for your review comments Alan. Responses below. > On 8 Dec 2016, at 19:44, Alan Bateman wrote: > > On 07/12/2016 16:32, Vincent Ryan wrote: > >> A hexdump facility has been available for many, many years via an >> unsupported class: sun.misc.HexDumpEncoder. >>

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

Hi, It may take a few iterations to get the API settled. There are other byte sources we may want to consider such as InputStream and ByteBuffer. Comments below. Paul. > On 7 Dec 2016, at 08:32, Vincent Ryan wrote: > > A hexdump facility has been available for

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

On 07/12/2016 16:32, Vincent Ryan wrote: A hexdump facility has been available for many, many years via an unsupported class: sun.misc.HexDumpEncoder. Although that class was always unsupported, it was still accessible. That accessibility changes with Jigsaw so I’m proposing a very simple

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

> On 8 Dec 2016, at 12:10, Vincent Ryan wrote: > > >> On 8 Dec 2016, at 07:22, David Holmes wrote: >> >> On 8/12/2016 2:32 AM, Vincent Ryan wrote: >>> A hexdump facility has been available for many, many years via an >>> unsupported class:

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

> On 8 Dec 2016, at 07:22, David Holmes wrote: > > On 8/12/2016 2:32 AM, Vincent Ryan wrote: >> A hexdump facility has been available for many, many years via an >> unsupported class: sun.misc.HexDumpEncoder. >> Although that class was always unsupported, it was still

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

> On 8 Dec 2016, at 10:41, Ulf Zibis wrote: > > Hi, > > I would prefer a "normal" class instead a convolut of static methods. Via a > normal constructor, we could pass some custom parameters e.g. > capital/uppercase letters for "abcdef", prefix a header line, width of

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

Hi, I would prefer a "normal" class instead a convolut of static methods. Via a normal constructor, we could pass some custom parameters e.g. capital/uppercase letters for "abcdef", prefix a header line, width of the index counter, bytes per line, i.e. have all the parameters, you have

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

> On 8 Dec 2016, at 09:34, Volker Simonis wrote: > > Hi Vincent, > > the bug is closed and can't be looked at outside Oracle. > Can you please make it visible for everybody. Sorry. I’ve just corrected that. > > Also, this is a change of the public API so it

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

Hi Vincent, the bug is closed and can't be looked at outside Oracle. Can you please make it visible for everybody. Also, this is a change of the public API so it requires a CCC request/approval. Finally, this seems to be clearly a feature and not a bug so it requires an FC extension request [1]

Re: [9] RFR 8170769: Provide a simple hexdump facility for binary data

On 8/12/2016 2:32 AM, Vincent Ryan wrote: A hexdump facility has been available for many, many years via an unsupported class: sun.misc.HexDumpEncoder. Although that class was always unsupported, it was still accessible. That accessibility changes with Jigsaw so I’m proposing a very simple

[9] RFR 8170769: Provide a simple hexdump facility for binary data

A hexdump facility has been available for many, many years via an unsupported class: sun.misc.HexDumpEncoder. Although that class was always unsupported, it was still accessible. That accessibility changes with Jigsaw so I’m proposing a very simple replacement in a new and supported class: