On 10/16/19 10:49 AM, Amy Lu wrote:
> I think it's fine and worth to enable them in standard testing. I'll
> continue monitor the results and make necessary adjustment if they cause
> any issue.
>
> Any concerns? Please let me know.
It might be worth disabling such tests in Zero builds.
--
Hearing no other concerns, I'll do push soon.
Thanks,
Amy
On 10/16/19 5:49 PM, Amy Lu wrote:
Hi, Joe
I checked the elapsed time:
DivisionOverflow.java <10 seconds (normally 3 seconds)
StringConstructorOverflow.java <20 seconds (normally 8 seconds)
SymmetricRangeTests.java
Thank you Brian for reviewing and reminder.
Updated webrev script and re-generated (no code change compare to
webrev.00):
http://cr.openjdk.java.net/~amlu/8232195/webrev.01
Thanks,
Amy
On 10/15/19 11:33 PM, Brian Burkhalter wrote:
Hi Amy,
This looks OK. It looks like DivisionOverflow was
Hi, Joe
I checked the elapsed time:
DivisionOverflow.java <10 seconds (normally 3 seconds)
StringConstructorOverflow.java <20 seconds (normally 8 seconds)
SymmetricRangeTests.java <100 seconds (normally 60-80 seconds)
I think it's fine and worth to enable them in standard
Hello,
How long to the tests take to run when they actually run?
(It would be helpful to have a setting in jtreg that could indicate "its
okay to run the slow tests" or "run the more extensive set of test
vectors," but we haven't defined such a mechanism as of yet.)
Thanks,
-Joe
On
Hi Amy,
This looks OK. It looks like DivisionOverflow was already being run however.
Also, the navigation in your webrev is broken: is your script current?
Thanks,
Brian
> On Oct 14, 2019, at 10:05 PM, Amy Lu wrote:
>
> test/jdk/java/math/BigInteger/DivisionOverflow.java
>
test/jdk/java/math/BigInteger/DivisionOverflow.java
test/jdk/java/math/BigInteger/StringConstructorOverflow.java
test/jdk/java/math/BigInteger/SymmetricRangeTests.java
These tests require huge memory and need to run with -Xmx8g
They are skipped or tagged with @ignore and not actually run in
