Re: [PATCH] Add compareToUnsigned to java.nio.*Buffer

2018-04-24 Thread Paul Sandoz
Thanks. I attached your patch to the issue: https://bugs.openjdk.java.net/browse/JDK-8202216 > On Apr 24, 2018, at 5:51 AM, Robert Stupp wrote: > > Hi Paul, > > Thank you. > > I've filed an RFE via https://bugreport.java.com/bugreport/sta

Re: [PATCH] Add compareToUnsigned to java.nio.*Buffer

2018-04-24 Thread Robert Stupp
Hi Paul, Thank you. I've filed an RFE via https://bugreport.java.com/bugreport/start_form.do - seems to be JDK-9053522. It just has no option to add an attachment and I have no login to bugs.openjdk.java.net . On 04/23/2018 11:16 PM, Paul Sandoz wrote: The addition of mismatch is reasonabl

Re: [PATCH] Add compareToUnsigned to java.nio.*Buffer

2018-04-23 Thread Paul Sandoz
Hi Robert, Thanks. The addition of mismatch is reasonable. I am unsure about compareToUnsigned, since we are trying to be a conservative about what we add to Buffer. I’ll take a closer look but it may take a little while to get around to it. Would you mind logging a web bug and attaching your

[PATCH] Add compareToUnsigned to java.nio.*Buffer

2018-04-23 Thread Robert Stupp
The proposed patch is an improvement for Byte/Short/Int/LongBuffer classes to add compareToUnsigned() that works like compareTo() but treats the values as unsigned to leverage the vectorized mismatch implementations, which are not publicly accessible. In addition to that, it adds mismatch() fo