Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

2018-12-12 Thread Alexey Ivanov
Forgot to add the link: On 12/12/2018 16:10, Alexey Ivanov wrote: Ali has scanned the code base, he says, “couldn’t find (hopefully tbh) other occurrences of such mismatches.” http://mail.openjdk.java.net/pipermail/build-dev/2018-December/024358.html On 10/12/2018 10:45, Magnus Ihse Bursie

Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

2018-12-12 Thread Alexey Ivanov
Thank you, Ali, for doing this! On 10/12/2018 21:13, Ali İnce wrote: Hi Alexey, I’ve searched for |GetProcAddress| usages across source code and couldn’t find (hopefully tbh) other occurrences of such mismatches. Regards, Ali

Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

2018-12-12 Thread Alexey Ivanov
Ali has scanned the code base, he says, “couldn’t find (hopefully tbh) other occurrences of such mismatches.” On 10/12/2018 10:45, Magnus Ihse Bursie wrote: It might be worthwhile to scan the entire code base for JNICALL and verify that we have no more mismatches. In general, JNICALL should be

Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

2018-12-10 Thread Ali İnce
Hi Alexey, I’ve searched for |GetProcAddress| usages across source code and couldn’t find (hopefully tbh) other occurrences of such mismatches. Regards, Ali > On 7 Dec 2018, at 20:24, Alexey Ivanov wrote: > > Hi Ali, > > On 06/12/2018 22:49, Ali İnce wrote: >> Hi Magnus, Alexey, >> >> I

Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

2018-12-10 Thread Magnus Ihse Bursie
On 2018-12-07 21:24, Alexey Ivanov wrote: Hi Ali, On 06/12/2018 22:49, Ali İnce wrote: Hi Magnus, Alexey, I believe we won’t be able to get further opinions from serviceability-dev. Unfortunately, no one has replied as of now. Have you found any issues with jdwpTransport_OnLoad after

Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

2018-12-07 Thread Alexey Ivanov
Hi Ali, On 06/12/2018 22:49, Ali İnce wrote: Hi Magnus, Alexey, I believe we won’t be able to get further opinions from serviceability-dev. Unfortunately, no one has replied as of now. Have you found any issues with jdwpTransport_OnLoad after removing JNICALL? Andrew Luo suggested using a

Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

2018-12-07 Thread Ali İnce
Hi Magnus, Alexey, I believe we won’t be able to get further opinions from serviceability-dev. Andrew Luo suggested using a similar mechanism as is used for jvm.dll by using symbol name files mapped by platform (files are under make/hotspot/symbols and interestingly windows is almost the only