Re: [jdk17] RFR: 8265073: XML transformation and indentation when using xml:space [v2]

2021-06-17 Thread Joe Wang
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote: >> The issue was that the attribute was processed before the variable was set >> (e.g. m_preserveSpaces.push). Reversing the order fixed it. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revi

Re: [jdk17] RFR: 8265073: XML transformation and indentation when using xml:space [v2]

2021-06-17 Thread Iris Clark
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote: >> The issue was that the attribute was processed before the variable was set >> (e.g. m_preserveSpaces.push). Reversing the order fixed it. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revi

Re: [jdk17] RFR: 8265073: XML transformation and indentation when using xml:space [v2]

2021-06-17 Thread Naoto Sato
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote: >> The issue was that the attribute was processed before the variable was set >> (e.g. m_preserveSpaces.push). Reversing the order fixed it. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revi

Re: [jdk17] RFR: 8265073: XML transformation and indentation when using xml:space [v2]

2021-06-17 Thread Joe Wang
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote: >> The issue was that the attribute was processed before the variable was set >> (e.g. m_preserveSpaces.push). Reversing the order fixed it. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revi

Re: [jdk17] RFR: 8265073: XML transformation and indentation when using xml:space [v2]

2021-06-17 Thread Lance Andersen
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote: >> The issue was that the attribute was processed before the variable was set >> (e.g. m_preserveSpaces.push). Reversing the order fixed it. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revi

Re: [jdk17] RFR: 8265073: XML transformation and indentation when using xml:space [v2]

2021-06-17 Thread Joe Wang
> The issue was that the attribute was processed before the variable was set > (e.g. m_preserveSpaces.push). Reversing the order fixed it. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: Thanks Naoto. Updated accordingly. -

Re: [jdk17] RFR: 8265073: XML transformation and indentation when using xml:space

2021-06-17 Thread Naoto Sato
On Thu, 17 Jun 2021 16:13:49 GMT, Joe Wang wrote: > The issue was that the attribute was processed before the variable was set > (e.g. m_preserveSpaces.push). Reversing the order fixed it. Looks good overall. Some minor comments in the test. test/jaxp/javax/xml/jaxp/unittest/common/prettyprint

[jdk17] RFR: 8265073: XML transformation and indentation when using xml:space

2021-06-17 Thread Joe Wang
The issue was that the attribute was processed before the variable was set (e.g. m_preserveSpaces.push). Reversing the order fixed it. - Commit messages: - 8265073: XML transformation and indentation when using xml:space Changes: https://git.openjdk.java.net/jdk17/pull/89/files We