Re: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code

2010-10-07 Thread Alan Bateman
Dr Andrew John Hughes wrote: : It builds and there seem to be notably less warnings. The first I see now is: ../../../src/solaris/bin/java_md.c: In function 'LocateJRE': ../../../src/solaris/bin/java_md.c:871:19: warning: cast from pointer to integer of different size

hg: jdk7/tl/jdk: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code

2010-10-07 Thread alan . bateman
Changeset: 871cffb21423 Author:alanb Date: 2010-10-07 14:36 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/871cffb21423 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code Reviewed-by: andrew, mchung, ohair ! src/share/native

Re: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code

2010-10-06 Thread Kelly O'Hair
This looks ok to me. If it gets past a JPRT build on all platforms I think it's golden. Thank you. May your fortune cookies always be positive. ;^) -kto On Oct 6, 2010, at 1:37 PM, Alan Bateman wrote: This batch eliminates a bunch of compiler warnings from the native code:

Re: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code

2010-10-06 Thread Mandy Chung
On 10/06/10 13:37, Alan Bateman wrote: This batch eliminates a bunch of compiler warnings from the native code: http://cr.openjdk.java.net/~alanb/6989466/webrev/ Looks good to me. I will defer to your build to verify if there is any remaining one. It also fixes an incorrect usage of

Re: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code

2010-10-06 Thread Dr Andrew John Hughes
On 6 October 2010 21:56, Dr Andrew John Hughes gnu_and...@member.fsf.org wrote: On 6 October 2010 21:37, Alan Bateman alan.bate...@oracle.com wrote: This batch eliminates a bunch of compiler warnings from the native code:  http://cr.openjdk.java.net/~alanb/6989466/webrev/ It also fixes an

Re: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code

2010-10-06 Thread Kelly O'Hair
On Oct 6, 2010, at 2:28 PM, Mandy Chung wrote: On 10/06/10 13:37, Alan Bateman wrote: This batch eliminates a bunch of compiler warnings from the native code: http://cr.openjdk.java.net/~alanb/6989466/webrev/ Looks good to me. I will defer to your build to verify if there is any