Re: 7116404: Miscellaneous warnings (java.rmi.**, serialization, some core classes)

2011-11-30 Thread Alan Bateman
On 29/11/2011 23:01, Stuart Marks wrote: On 11/29/11 8:10 AM, Alan Bateman wrote: : http://cr.openjdk.java.net/~alanb/7116404/webrev/ Wow, you're getting a jump on us! Any idea how many warnings this cleared up? Looks like dozens. 110, so not too many. There is still plenty of low hanging

Re: 7116404: Miscellaneous warnings (java.rmi.**, serialization, some core classes)

2011-11-30 Thread Rémi Forax
On 11/30/2011 11:00 AM, Alan Bateman wrote: On 29/11/2011 23:01, Stuart Marks wrote: On 11/29/11 8:10 AM, Alan Bateman wrote: : http://cr.openjdk.java.net/~alanb/7116404/webrev/ Wow, you're getting a jump on us! Any idea how many warnings this cleared up? Looks like dozens. 110, so not too

Re: 7116404: Miscellaneous warnings (java.rmi.**, serialization, some core classes)

2011-11-30 Thread Alan Bateman
On 30/11/2011 15:06, Rémi Forax wrote: Note that you can use clazz.asSubclass(Enum.class) instead of casting to the raw type Class, you will still have a warning but you will be not the one that have introduced a raw type :) Your mail arrived just a few minutes after I did the hg push. The

Re: 7116404: Miscellaneous warnings (java.rmi.**, serialization, some core classes)

2011-11-29 Thread Chris Hegarty
On 11/29/11 06:19 PM, Lance Andersen - Oracle wrote: Looks good to me Me too. Just one minor opportunity for use of in ObjectInputStream Class?[] classObjs = new Class*?*[interfaces.length]; --- Class?[] classObjs = new Class[interfaces.length]; -Chris. Best Lance On Nov 29, 2011, at

Re: 7116404: Miscellaneous warnings (java.rmi.**, serialization, some core classes)

2011-11-29 Thread Stuart Marks
On 11/29/11 8:10 AM, Alan Bateman wrote: I don't have time on Thursday to get involved in the warnings fest [1]. However I would like to contribute something and to that end the following webrev proposes changes to eliminate the warnings from several classes including java.rmi.**, the

Re: 7116404: Miscellaneous warnings (java.rmi.**, serialization, some core classes)

2011-11-29 Thread David Holmes
cc'ing to jdk8-dev so that people know these classes have already been tackled. David On 30/11/2011 2:10 AM, Alan Bateman wrote: I don't have time on Thursday to get involved in the warnings fest [1]. However I would like to contribute something and to that end the following webrev proposes