Re: 8031494: [launcher] java launcher should check for JNI Pending exceptions.

2014-01-14 Thread Kumar Srinivasan
Good catch on the CallStaticVoidMethod, fixed these as well, here is the updated webrev: http://cr.openjdk.java.net/~ksrini/8031494/webrev.2/ delta webrev to the last: http://cr.openjdk.java.net/~ksrini/8031494/webrev.2/webrev.delta/index.html Thanks Kumar On 1/13/2014 6:35 PM, Kumar

Re: 8031494: [launcher] java launcher should check for JNI Pending exceptions.

2014-01-14 Thread Mandy Chung
On 1/14/2014 10:17 AM, Kumar Srinivasan wrote: Good catch on the CallStaticVoidMethod, fixed these as well, here is the updated webrev: http://cr.openjdk.java.net/~ksrini/8031494/webrev.2/ delta webrev to the last: http://cr.openjdk.java.net/~ksrini/8031494/webrev.2/webrev.delta/index.html

Re: 8031494: [launcher] java launcher should check for JNI Pending exceptions.

2014-01-13 Thread Kumar Srinivasan
Hi Alan, Chris, On 11/01/2014 00:55, Kumar Srinivasan wrote: Hi, Please review fixes for launcher correctness wrt. JNI calls. http://cr.openjdk.java.net/~ksrini/8031494/webrev.0/ Looks okay, the only thing that isn't clear is whether the calls to the static methods defined by the launcher

Re: 8031494: [launcher] java launcher should check for JNI Pending exceptions.

2014-01-13 Thread Kumar Srinivasan
As for the launcher helper calls, they all call abort/System.exit and bale out, they are also guarded by ExceptionOccurred in the native-land. Here is the updated version: The delta webrev since the last reviewed changes:

Re: 8031494: [launcher] java launcher should check for JNI Pending exceptions.

2014-01-13 Thread Mandy Chung
On 1/13/2014 2:44 PM, Kumar Srinivasan wrote: The full webrev: http://cr.openjdk.java.net/~ksrini/8031494/webrev.1/ This looks good. Should it also check if there is any pending exception after the call to CallStaticVoidMethod that has no return value? It's fine with me if you want to

Re: 8031494: [launcher] java launcher should check for JNI Pending exceptions.

2014-01-13 Thread Kumar Srinivasan
Mandy, On 1/13/2014 2:44 PM, Kumar Srinivasan wrote: The full webrev: http://cr.openjdk.java.net/~ksrini/8031494/webrev.1/ This looks good. Should it also check if there is any pending exception after the call to CallStaticVoidMethod that has no return value? It's fine with me if you

Re: 8031494: [launcher] java launcher should check for JNI Pending exceptions.

2014-01-13 Thread Mandy Chung
On 1/13/2014 6:35 PM, Kumar Srinivasan wrote: Mandy, On 1/13/2014 2:44 PM, Kumar Srinivasan wrote: The full webrev: http://cr.openjdk.java.net/~ksrini/8031494/webrev.1/ This looks good. Should it also check if there is any pending exception after the call to CallStaticVoidMethod that

Re: 8031494: [launcher] java launcher should check for JNI Pending exceptions.

2014-01-11 Thread Chris Hegarty
Looks ok to me Kumar. -Chris. On 11 Jan 2014, at 00:55, Kumar Srinivasan kumar.x.sriniva...@oracle.com wrote: Hi, Please review fixes for launcher correctness wrt. JNI calls. http://cr.openjdk.java.net/~ksrini/8031494/webrev.0/ Thanks Kumar

Re: 8031494: [launcher] java launcher should check for JNI Pending exceptions.

2014-01-11 Thread Alan Bateman
On 11/01/2014 00:55, Kumar Srinivasan wrote: Hi, Please review fixes for launcher correctness wrt. JNI calls. http://cr.openjdk.java.net/~ksrini/8031494/webrev.0/ Looks okay, the only thing that isn't clear is whether the calls to the static methods defined by the launcher helper class can

8031494: [launcher] java launcher should check for JNI Pending exceptions.

2014-01-10 Thread Kumar Srinivasan
Hi, Please review fixes for launcher correctness wrt. JNI calls. http://cr.openjdk.java.net/~ksrini/8031494/webrev.0/ Thanks Kumar