Re: A method with return type size_t returns negative value

2011-11-29 Thread Alan Bateman
On 28/11/2011 08:36, Jing Lv wrote: Hello Alan, I am fine with the fix on the webrev, suppose it would be applied later? I don't remember (as it's been a long time) exactly I found the issue, maybe some code scan or some strong compiler :) (Problem with my mail server so I can

Re: A method with return type size_t returns negative value

2011-11-29 Thread Chris Hegarty
On 11/29/11 06:12 PM, Lance Andersen - Oracle wrote: looks ok to me... +1 -Chris. On Nov 29, 2011, at 11:19 AM, Alan Bateman wrote: On 28/11/2011 08:36, Jing Lv wrote: Hello Alan, I am fine with the fix on the webrev, suppose it would be applied later? I don't remember (as it's

Re: A method with return type size_t returns negative value

2011-11-15 Thread Jing Lv
Hello, I search the E:\workspace\openjdk\jdk\src\windows\native but find nothing similar (please tell me if I miss something), so I suggest we have a quick fix for now, like: --- E:\workspace\openjdk\jdk\src\windows\native\java\io\io_util_md.h~ 2011-11-15 15:53:21.0 +0800 +++

Re: A method with return type size_t returns negative value

2011-11-15 Thread Alan Bateman
On 15/11/2011 08:09, Jing Lv wrote: Hello, I search the E:\workspace\openjdk\jdk\src\windows\native but find nothing similar (please tell me if I miss something), so I suggest we have a quick fix for now, like: I'm not around this week but I will get back to you next week on this (as I

Re: A method with return type size_t returns negative value

2011-11-09 Thread Jing Lv
Hello Alan, (Sorry that haven't check this for months) I check with the bug 7030624 but see no progress now. What's the current status? Shall we go on with a simple patch to fix the problem? On 2011/7/21 21:32, Alan Bateman wrote: Jing LV wrote: Ping, anyone notice this? :) My plan is

Re: A method with return type size_t returns negative value

2011-07-05 Thread Jing LV
Hello, It's been quite a long time and it seems jdk7 is doing well now. I know there is still several days before its release, anyway, Alan or someone else, would you please tell me if we can start work on jdk8, and restart the discussion on the bugs like this (I remember there are still

Re: A method with return type size_t returns negative value

2011-05-05 Thread Jing LV
于 2011-4-26 16:43, Alan Bateman 写道: Jing LV wrote: Hello, Thanks for raising the defect. I see there is no patch now, so I create one (as the defect mentioned jint may be good, I use jint here). I have no Sun Online Account Id, would someone take a look? The function prototypes

Re: A method with return type size_t returns negative value

2011-04-26 Thread Jing LV
Hello, Thanks for raising the defect. I see there is no patch now, so I create one (as the defect mentioned jint may be good, I use jint here). I have no Sun Online Account Id, would someone take a look? diff --git a/src/windows/native/java/io/io_util_md.c

Re: A method with return type size_t returns negative value

2011-04-26 Thread Alan Bateman
Jing LV wrote: Hello, Thanks for raising the defect. I see there is no patch now, so I create one (as the defect mentioned jint may be good, I use jint here). I have no Sun Online Account Id, would someone take a look? The function prototypes would also require to be updated and

Re: A method with return type size_t returns negative value

2011-04-26 Thread Steve Poole
On 26/04/11 09:43, Alan Bateman wrote: . Another point is that jdk8 will be our opportunity to remove the dependencies on the JVM_* functions That sounds interesting Alan - care to share more?

Re: A method with return type size_t returns negative value

2011-04-26 Thread Alan Bateman
Steve Poole wrote: On 26/04/11 09:43, Alan Bateman wrote: . Another point is that jdk8 will be our opportunity to remove the dependencies on the JVM_* functions That sounds interesting Alan - care to share more? As you know, it's really hard to remove things from the JDK. Medals are few.

Re: A method with return type size_t returns negative value

2011-04-26 Thread Alan Bateman
Steve Poole wrote: Ok Alan - thanks for the background. I must of missed the VM option along the way - what's it called? It's HotSpot specific and is named UseVMInterruptibleIO. -Alan

Re: A method with return type size_t returns negative value

2011-03-24 Thread Jing LV
于 2011-3-23 18:23, Alan Bateman 写道: Jing LV wrote: Hello, I found a problem in windows/native/java/io/io_util_md.c, method handleRead(). The return type of the method is size_t, which is defined as unsigned int. However we see the method would return negative values while it meets some error.

Re: A method with return type size_t returns negative value

2011-03-24 Thread Alan Bateman
Jing LV wrote: : Thanks Alan. Would you please tell me the bug number? The bug now tracking this is: 7030624: size_t usages in src/windows/native/java/io/io_util_md.c need to be re-visited -Alan.

A method with return type size_t returns negative value

2011-03-23 Thread Jing LV
Hello, I found a problem in windows/native/java/io/io_util_md.c, method handleRead(). The return type of the method is size_t, which is defined as unsigned int. However we see the method would return negative values while it meets some error. This may be a problem as the API comsumer and later

Re: A method with return type size_t returns negative value

2011-03-23 Thread Alan Bateman
Jing LV wrote: Hello, I found a problem in windows/native/java/io/io_util_md.c, method handleRead(). The return type of the method is size_t, which is defined as unsigned int. However we see the method would return negative values while it meets some error. This may be a problem as the API