Hi Lance,
As a general comment, I would prefer release-specific information (As
of Java SE 8...) to appear not in javadoc, but in the non-javadoc
comments in a class. Such release-specific notes in the specification
quickly become out of date.
I suggest explicitly documenting how the two
Hi Joe,
Thank you for the sanity check.
I had added the following to the top of the javadoc (still playing with the
wording):
As of Java SE 8, the method getLargeUpdateCount has been added to provide
support for update counts that may be exceed Integer.MAX_VALUE and returned by
the method
Hi Lance,
I would throw an IllegalStateException if invoking e.g. getUpdateCounts on
integer overflow.
-Ulf
Am 26.11.2012 20:44, schrieb Lance Andersen - Oracle:
Hi Joe,
Thank you for the sanity check.
I had added the following to the top of the javadoc (still playing with the
wording):
Hi Ulf,
Thank you for the suggestion
The current spec is silent on what happens if the update count overflows for
any executeUpdate method. Today the driver vendors just pass in their array of
UpdateCounts (or status) to BatchException (or overflow the return count from
executeUpdate) if an
Hi Lance,
I don't see an obvious problem with the code, but I strongly suggest
documenting the correctness conditions regarding the updateCounts and
longUpdateCounts fields; I think that would ease reviewing the new
constructors and serialization code.
Cheers,
-Joe
On 11/24/2012 2:05 PM,
Hi,
For JDBC 4.2, I am adding methods to allow for larger update counts (request
from JDBC driver vendors) and because of this I have to tweak
BatchUpdateException
The Statement interface has the method
int[] executeBatch()
I am planning to add
long[] executeLargeBatch().
To accomodate
