Re: Garbage collection race condition before final checks

2011-11-17 Thread Mandy Chung
On 11/15/11 10:20 AM, Gary Adams wrote: Added PlatformLoggingMXBeanTest to the 7067691 bug fix, e.g. instance variables for Logger variables to prevent premature weak reference collection. http://cr.openjdk.java.net/~gadams/7067691/ Gary, I have pushed your changeset:

Re: Garbage collection race condition before final checks

2011-11-15 Thread David Holmes
Gary: Please do not start discussing other bugs in this thread - please keep them distinct. Remi: please add any comments to the discussion threads on those other bugs. Thanks David On 16/11/2011 12:30 AM, Rémi Forax wrote: On 11/15/2011 01:26 PM, Gary Adams wrote: Added

Re: Garbage collection race condition before final checks

2011-11-10 Thread Gary Adams
On 11/ 8/11 11:13 PM, Mandy Chung wrote: Thanks for picking up this bug and fixing this intermittent issue. PlatformLoggingMXBeanTest.java in the same directory has the same issue. It'd be good to fix that with the same CR. These tests were copied from

Re: Garbage collection race condition before final checks

2011-11-09 Thread Alan Bateman
On 08/11/2011 15:35, Gary Adams wrote: Here's another intermittent bug that is attributed to the garbage collection of the loggers before the final static check can be applied in the test. CR#7067691 : java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently I

Re: Garbage collection race condition before final checks

2011-11-09 Thread Gary Adams
On 11/8/11 11:13 PM, Mandy Chung wrote: Gary, Thanks for picking up this bug and fixing this intermittent issue. PlatformLoggingMXBeanTest.java in the same directory has the same issue. It'd be good to fix that with the same CR. These tests were copied from

Re: Garbage collection race condition before final checks

2011-11-09 Thread Gary Adams
Here's an updated diff : - added current CR# to the @bug tag - made logger1 and logger2 instance variables - renamed test instance variable lmxbeantest - removed excessive diagnostic print outs --- a/test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java +++

Re: Garbage collection race condition before final checks

2011-11-09 Thread Alan Bateman
On 09/11/2011 19:26, Gary Adams wrote: Here's an updated diff : - added current CR# to the @bug tag - made logger1 and logger2 instance variables - renamed test instance variable lmxbeantest - removed excessive diagnostic print outs Looks fine to me except that we might find a

Re: Garbage collection race condition before final checks

2011-11-09 Thread Mandy Chung
On 11/9/2011 1:18 PM, Alan Bateman wrote: On 09/11/2011 19:26, Gary Adams wrote: Here's an updated diff : - added current CR# to the @bug tag - made logger1 and logger2 instance variables - renamed test instance variable lmxbeantest - removed excessive diagnostic print outs Looks

Re: Garbage collection race condition before final checks

2011-11-08 Thread Mandy Chung
Gary, Thanks for picking up this bug and fixing this intermittent issue. PlatformLoggingMXBeanTest.java in the same directory has the same issue. It'd be good to fix that with the same CR. These tests were copied from test/java/util/logging/LoggingMXBeanTest.java. I haven't looked in