Re: JNI VERSION CHANGE: RFR: 8145098: JNI GetVersion should return JNI_VERSION_9

2016-02-19 Thread Alan Bateman
On 19/02/2016 03:10, Iris Clark wrote: Hi, Alan and Rachel. Here's a proposal for the new text for JEP 223: --- [ insert between existing sections "@since..." and "Mercurial..."] JNI Version The [JNI Specification][JNISpec] defines a constant representing the JNI version number. The

RE: JNI VERSION CHANGE: RFR: 8145098: JNI GetVersion should return JNI_VERSION_9

2016-02-18 Thread Iris Clark
updating the JNI Spec itself? Thanks, iris -Original Message- From: Alan Bateman Sent: Wednesday, February 17, 2016 11:49 PM To: Rachel Protacio; hotspot-runtime-...@openjdk.java.net; core-libs-dev@openjdk.java.net; Iris Clark Subject: Re: JNI VERSION CHANGE: RFR: 8145098: JNI GetVersio

Re: JNI VERSION CHANGE: RFR: 8145098: JNI GetVersion should return JNI_VERSION_9

2016-02-18 Thread Rachel Protacio
Thanks for the reviews, David and Alan! Rachel On 2/18/2016 2:48 AM, Alan Bateman wrote: On 17/02/2016 21:21, Rachel Protacio wrote: Hello, everyone, We are moving forward with "JNI_VERSION_9". If it later turns out that it should be "9_0", we will file a separate bug, but the plain 9 is

Re: JNI VERSION CHANGE: RFR: 8145098: JNI GetVersion should return JNI_VERSION_9

2016-02-17 Thread Alan Bateman
On 17/02/2016 21:21, Rachel Protacio wrote: Hello, everyone, We are moving forward with "JNI_VERSION_9". If it later turns out that it should be "9_0", we will file a separate bug, but the plain 9 is most likely. There is currently a compatibility request in the approval process. Here is

Re: JNI VERSION CHANGE: RFR: 8145098: JNI GetVersion should return JNI_VERSION_9

2016-02-17 Thread David Holmes
Hi Rachel, On 18/02/2016 7:21 AM, Rachel Protacio wrote: Hello, everyone, We are moving forward with "JNI_VERSION_9". If it later turns out that it should be "9_0", we will file a separate bug, but the plain 9 is most likely. There is currently a compatibility request in the approval process.

Re: JNI VERSION CHANGE: RFR: 8145098: JNI GetVersion should return JNI_VERSION_9

2016-02-17 Thread Rachel Protacio
Hello, everyone, We are moving forward with "JNI_VERSION_9". If it later turns out that it should be "9_0", we will file a separate bug, but the plain 9 is most likely. There is currently a compatibility request in the approval process. Here is the updated code, which builds properly and

Re: JNI VERSION CHANGE: RFR: 8145098: JNI GetVersion should return JNI_VERSION_9

2016-01-29 Thread Rachel Protacio
Thanks for the review, Dan. We'll see how the 9 v. 9_0 discussion plays out. Rachel On 1/28/2016 1:37 PM, Daniel D. Daugherty wrote: On 1/27/16 4:02 PM, Rachel Protacio wrote: Hello! Small but important change for review: updating the JNI_VERSION and in so doing, changing the format from

Re: JNI VERSION CHANGE: RFR: 8145098: JNI GetVersion should return JNI_VERSION_9

2016-01-28 Thread Alan Bateman
On 27/01/2016 23:02, Rachel Protacio wrote: Hello! Small but important change for review: updating the JNI_VERSION and in so doing, changing the format from JNI_VERSION_1_x to JNI_VERSION_x_y (see code/bug for details). Bug: https://bugs.openjdk.java.net/browse/JDK-8145098 hotspot repo

Re: JNI VERSION CHANGE: RFR: 8145098: JNI GetVersion should return JNI_VERSION_9

2016-01-28 Thread Daniel D. Daugherty
On 1/27/16 4:02 PM, Rachel Protacio wrote: Hello! Small but important change for review: updating the JNI_VERSION and in so doing, changing the format from JNI_VERSION_1_x to JNI_VERSION_x_y (see code/bug for details). Bug: https://bugs.openjdk.java.net/browse/JDK-8145098 hotspot repo