RE: RFR: JDK-8153781 Issue in XMLScanner: EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping large DOCTYPE section with CRLF at wrong place

Thanks Joe :-) > -Original Message- > From: huizhe wang [mailto:huizhe.w...@oracle.com] > Sent: Dienstag, 19. April 2016 23:44 > To: Langer, Christoph > Cc: core-libs-dev@openjdk.java.net > Subject: Re: RFR: JDK-8153781 Issue in XMLScanner: >

Re: RFR: JDK-8153781 Issue in XMLScanner: EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping large DOCTYPE section with CRLF at wrong place

On 4/19/2016 1:45 PM, Langer, Christoph wrote: Hi Joe, I've updated the testcase to increase the probability of it really hitting the issue. The old version was prone to miss the issue in case something changed in the parser. http://cr.openjdk.java.net/~clanger/webrevs/8153781.2/ Looks

RE: RFR: JDK-8153781 Issue in XMLScanner: EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping large DOCTYPE section with CRLF at wrong place

Hi Joe, > > I've updated the testcase to increase the probability of it really hitting > > the > issue. The old version was prone to miss the issue in case something changed > in > the parser. > > > > http://cr.openjdk.java.net/~clanger/webrevs/8153781.2/ > > Looks good overall. OK, thanks. >

Re: RFR: JDK-8153781 Issue in XMLScanner: EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping large DOCTYPE section with CRLF at wrong place

On 4/19/2016 6:54 AM, Langer, Christoph wrote: Hi again, I've updated the testcase to increase the probability of it really hitting the issue. The old version was prone to miss the issue in case something changed in the parser. http://cr.openjdk.java.net/~clanger/webrevs/8153781.2/ Looks

RE: RFR: JDK-8153781 Issue in XMLScanner: EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping large DOCTYPE section with CRLF at wrong place

Hi again, I've updated the testcase to increase the probability of it really hitting the issue. The old version was prone to miss the issue in case something changed in the parser. http://cr.openjdk.java.net/~clanger/webrevs/8153781.2/ Best regards Christoph > -Original Message- >

RE: RFR: JDK-8153781 Issue in XMLScanner: EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping large DOCTYPE section with CRLF at wrong place

Hi Joe, here is the updated webrev where I incorporated your suggestions: http://cr.openjdk.java.net/~clanger/webrevs/8153781.1/ I also added a testcase. As for the message " DoctypedeclNotClosed ": I did it in several languages but there are some languages where I don't have the knowledge to

Re: RFR: JDK-8153781 Issue in XMLScanner: EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping large DOCTYPE section with CRLF at wrong place

On 4/12/2016 11:50 AM, Langer, Christoph wrote: Hi Joe, thanks as always for your suggestions and I'll try to work it in. It will probably take me a little while as I'm currently busy with another thing. I'll update my webrev eventually and add a testcase, too. Ok. But one question: I

RE: RFR: JDK-8153781 Issue in XMLScanner: EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping large DOCTYPE section with CRLF at wrong place

Hi Joe, thanks as always for your suggestions and I'll try to work it in. It will probably take me a little while as I'm currently busy with another thing. I'll update my webrev eventually and add a testcase, too. But one question: I understand that the fix in skipDTD will be sufficient to

Re: RFR: JDK-8153781 Issue in XMLScanner: EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping large DOCTYPE section with CRLF at wrong place

Also, EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET was a wrong msg id. It would be good to change that to DoctypedeclNotClosed and add a message to XMLMessages.properties right before DoctypedeclUnterminated, sth. like the following: DoctypedeclNotClosed = The document type declaration

Re: RFR: JDK-8153781 Issue in XMLScanner: EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping large DOCTYPE section with CRLF at wrong place

On 4/7/2016 1:45 PM, Langer, Christoph wrote: Hi, I've run into a peculiar issue with Xerces. The problem is happening when a DTD shall be skipped, the DTD is larger than the buffer of the current entity and a CRLF sequence occurs just one char before the buffer end. The reason is