RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-06-07 Thread Langer, Christoph
va.net; core-libs-dev@openjdk.java.net; Lindenmaier, > Goetz > Subject: RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc > 12.1 > > Hello Matthias and Christoph. > Thank you for your explanations. > > I did not have enough knowledge about &

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-06-05 Thread Ichiroh Takiguchi
or maybe just sume specific required symbols are not declared correctly? Best regards Christoph > -Original Message- > From: Ichiroh Takiguchi [mailto:taki...@linux.vnet.ibm.com] > Sent: Donnerstag, 31. Mai 2018 09:55 > To: Langer, Christoph > Cc: Baesken, Matthias ; 'bui

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-06-01 Thread Baesken, Matthias
> From: Langer, Christoph > Sent: Freitag, 1. Juni 2018 10:57 > To: Ichiroh Takiguchi > Cc: Baesken, Matthias ; 'build- > d...@openjdk.java.net' ; ppc-aix-port- > d...@openjdk.java.net; core-libs-dev@openjdk.java.net; Lindenmaier, > Goetz > Subject: RE: RFR : 8202322: AIX: s

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-06-01 Thread Langer, Christoph
anger, Christoph > Cc: Baesken, Matthias ; 'build- > d...@openjdk.java.net' ; ppc-aix-port- > d...@openjdk.java.net; core-libs-dev@openjdk.java.net; Lindenmaier, > Goetz > Subject: RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc > 12.1 > > Hello. > 82023

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-05-31 Thread Ichiroh Takiguchi
Mittwoch, 16. Mai 2018 09:06 To: Langer, Christoph ; 'build-...@openjdk.java.net' ; ppc-aix-port-...@openjdk.java.net; core-libs-dev@openjdk.java.net Cc: Lindenmaier, Goetz Subject: RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1 Hi Christoph can I add you as second revi

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-05-16 Thread Langer, Christoph
.java.net Cc: Lindenmaier, Goetz <goetz.lindenma...@sap.com> Subject: RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1 Hi Christoph can I add you as second reviewer (other reviewer was Erik Joelsson) can push the change ? Best regards, Matthias From: Langer, Christop

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-05-16 Thread Baesken, Matthias
<build-...@openjdk.java.net>; ppc-aix-port-...@openjdk.java.net; core-libs-dev@openjdk.java.net Cc: Simonis, Volker <volker.simo...@sap.com> Subject: RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1 Hi Matthias, to me the change in principal looks good. I'm wondering if it

Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-04-27 Thread Thomas Stüfe
Langer, Christoph <christoph.lan...@sap.com> >> Cc: Volker Simonis <volker.simo...@gmail.com>; Baesken, Matthias >> <matthias.baes...@sap.com>; Simonis, Volker <volker.simo...@sap.com>; >> ppc-aix-port-...@openjdk.java.net; core-libs-dev@openjdk.java.net; buil

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-04-27 Thread Baesken, Matthias
ias > <matthias.baes...@sap.com>; Simonis, Volker <volker.simo...@sap.com>; > ppc-aix-port-...@openjdk.java.net; core-libs-dev@openjdk.java.net; build- > d...@openjdk.java.net > Subject: Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc > 12.1 > > On

Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-04-27 Thread Thomas Stüfe
hristoph.lan...@sap.com> >> Cc: Volker Simonis <volker.simo...@gmail.com>; Baesken, Matthias >> <matthias.baes...@sap.com>; Simonis, Volker <volker.simo...@sap.com>; >> ppc-aix-port-...@openjdk.java.net; core-libs-dev@openjdk.java.net; build- >> d...

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-04-27 Thread Langer, Christoph
dk.java.net; core-libs-dev@openjdk.java.net; build- > d...@openjdk.java.net > Subject: Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc > 12.1 > > Hi Christoph > > On Fri, Apr 27, 2018 at 8:07 AM, Langer, Christoph > <christoph.lan...@sap.com> wr

Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-04-27 Thread Thomas Stüfe
t;> probably not working anyway) for the OpenJDK build . >> >> I am only aware of XLC versions 12.1 and 13.1which work / in >> >> case of >> 13.1 “might” work for OpenJDK compilation . >> >> And for 12.1 I want to remove the flags . >

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-04-27 Thread Langer, Christoph
.simo...@sap.com>; ppc-aix-port- > d...@openjdk.java.net; core-libs-dev@openjdk.java.net; build- > d...@openjdk.java.net > Subject: Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc > 12.1 > > Hi, > > This was added by "8200178: Remove mapfiles for JDK nativ

Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-04-26 Thread Thomas Stüfe
.net" <ppc-aix-port-...@openjdk.java.net>, >> "core-libs-dev@openjdk.java.net" <core-libs-dev@openjdk.java.net> >> From: "Baesken, Matthias" <matthias.baes...@sap.com> >> Date: 04/26/2018 08:23PM >> Cc: "Simonis, Volker" <volker

Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-04-26 Thread Erik Joelsson
Looks ok. /Erik On 2018-04-26 07:13, Baesken, Matthias wrote: Hello , could you please review this small adjustment to the symbol visibility compilation settings on AIX ? Currently we use XLC 12.1 to compile JDK on AIX . However XLC 12.1 does not support the "-qvisibility=hidden"

Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-04-26 Thread Volker Simonis
> ( waiting for the feedback of Bhaktavatsal Reddy , in case he prefers > it I remove them for all xlC versions including 13.1 ) > > Best regards, Matthias > > > > > > > From: Langer, Christoph > Sent: Donnerstag, 26. April 2018 16:38 > To: Baesken, Mat

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-04-26 Thread Bhaktavatsal R Maram
t> From: "Baesken, Matthias" <matthias.baes...@sap.com> Date: 04/26/2018 08:23PM Cc: "Simonis, Volker" <volker.simo...@sap.com>, Bhaktavatsal R Maram <bhama...@in.ibm.com> Subject: RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-04-26 Thread Baesken, Matthias
sap.com>; 'build-...@openjdk.java.net' <build-...@openjdk.java.net>; ppc-aix-port-...@openjdk.java.net; core-libs-dev@openjdk.java.net Cc: Simonis, Volker <volker.simo...@sap.com> Subject: RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1 Hi Matthias, to me the chang

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-04-26 Thread Langer, Christoph
Hi Matthias, to me the change in principal looks good. I'm wondering if it is possible to do a comparison like xlc < 13 (e.g. extract major number before the first dot, then compare numerically) - but maybe it is too complicated and the current single version compare suits our needs ? Best

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-04-26 Thread Baesken, Matthias
018 16:32 > To: Baesken, Matthias <matthias.baes...@sap.com> > Cc: 'build-...@openjdk.java.net' <build-...@openjdk.java.net>; ppc-aix- > port-...@openjdk.java.net; core-libs-dev@openjdk.java.net; Simonis, > Volker <volker.simo...@sap.com> > Subject: Re: RFR : 8202322: A

Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-04-26 Thread Bhaktavatsal R Maram
Hi Matthias, Its right in time. I am facing "Undefined Symbol" errors with XLC 13.1 due to "-qvisibility=hidden" which hides all symbols by default. I workaround that by removing this flag -bash-4.4$ xlC -qversion IBM XL C/C++ for AIX, V13.1.3 (5725-C72, 5765-J07) Version: 13.01.0003.

Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-04-26 Thread Thomas Stüfe
Hi Matthias, I would prefer a numerical comparison to version < 13. Otherwise the code looks like you want to just exclude 12.1 for some reason when in reality you want to omit the flag for any compiler older than xlc 13. Best Regards, Thomas On Thu, Apr 26, 2018 at 4:13 PM, Baesken, Matthias