RE: RFR 8124977 cmdline encoding challenges on Windows

2016-02-26 Thread Vladimir Shcherbakov
dimir Shcherbakov Cc: Naoto Sato ; Kumar Srinivasan ; Martin Sawicki ; core-libs-dev Libs Subject: Re: RFR 8124977 cmdline encoding challenges on Windows Vladimir, sun.jnu.encoding is used by JNU_NewStringPlatform/JNU_GetStringPlatformChars. The JNU_ pair is "widely" used by the various

RE: RFR 8124977 cmdline encoding challenges on Windows

2016-02-26 Thread Vladimir Shcherbakov
d: Windows 7(64 bit), Windows 8.1, Windows >> Server >> 2012 R2 DC, Windows 10 ; >> * System locales were used: English (United States), Persian, >> Japanese (Japan), Chinese (Traditional, Taiwan), Russian (Russia); >> >> Thanks, >> Vladimir. >>

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-02-23 Thread Xueming Shen
ing Shen [mailto:xueming.s...@oracle.com] Sent: Tuesday, February 23, 2016 8:54 PM To: Vladimir Shcherbakov Cc: Naoto Sato ; Kumar Srinivasan ; Martin Sawicki ; core-libs-dev Libs Subject: Re: RFR 8124977 cmdline encoding challenges on Windows Vladimir, sun.jnu.encoding is used by JNU_NewStri

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-02-23 Thread Xueming Shen
riginal Message- From: Naoto Sato [mailto:naoto.s...@oracle.com] Sent: Tuesday, February 23, 2016 10:47 AM To: Kumar Srinivasan ; Vladimir Shcherbakov ; SHEN,XUEMING Cc: Martin Sawicki ; core-libs-dev Libs Subject: Re: RFR 8124977 cmdline encoding challenges on Windows Hello, Sorry if this

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-02-23 Thread Naoto Sato
10:47 AM To: Kumar Srinivasan ; Vladimir Shcherbakov ; SHEN,XUEMING Cc: Martin Sawicki ; core-libs-dev Libs Subject: Re: RFR 8124977 cmdline encoding challenges on Windows Hello, Sorry if this has already been discussed, but this is my first time looking at the fix. In java_props_md.c, sprops.

RE: RFR 8124977 cmdline encoding challenges on Windows

2016-02-23 Thread Vladimir Shcherbakov
Windows 7(64 bit), Windows 8.1, Windows >> Server 2012 R2 DC, Windows 10 ; >> * System locales were used: English (United States), Persian, >> Japanese (Japan), Chinese (Traditional, Taiwan), Russian (Russia); >> >> Thanks, >> Vladimir. >> >> ---

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-02-23 Thread Naoto Sato
, 2016 11:34 AM To: Kumar Srinivasan ; Vladimir Shcherbakov Cc: core-libs-dev Libs ; Naoto Sato Subject: RE: RFR 8124977 cmdline encoding challenges on Windows Thanks for the feedback. Investigating the regression failure. We'll get back as soon as we figure this out. (and yes, we'

RE: RFR 8124977 cmdline encoding challenges on Windows

2016-02-22 Thread Vladimir Shcherbakov
Message- From: Martin Sawicki Sent: Thursday, January 14, 2016 11:34 AM To: Kumar Srinivasan ; Vladimir Shcherbakov Cc: core-libs-dev Libs ; Naoto Sato Subject: RE: RFR 8124977 cmdline encoding challenges on Windows Thanks for the feedback. Investigating the regression failure. We&#x

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-02-22 Thread Kumar Srinivasan
hanks, Vladimir. -Original Message- From: Martin Sawicki Sent: Thursday, January 14, 2016 11:34 AM To: Kumar Srinivasan ; Vladimir Shcherbakov Cc: core-libs-dev Libs ; Naoto Sato Subject: RE: RFR 8124977 cmdline encoding challenges on Windows Thanks for the feedback. Investigating

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-02-22 Thread Kumar Srinivasan
Cc: core-libs-dev Libs ; Naoto Sato Subject: RE: RFR 8124977 cmdline encoding challenges on Windows Thanks for the feedback. Investigating the regression failure. We'll get back as soon as we figure this out. (and yes, we'll run this through some localized Windows VMs) Cheers

RE: RFR 8124977 cmdline encoding challenges on Windows

2016-01-14 Thread Martin Sawicki
y, January 12, 2016 2:35 PM To: Martin Sawicki ; Vladimir Shcherbakov Cc: core-libs-dev Libs ; Naoto Sato Subject: Re: RFR 8124977 cmdline encoding challenges on Windows Hi Martin, Vladimir, It was suggested that this patch be tested on localized Windows machines and/or trying with the vario

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-01-12 Thread Kumar Srinivasan
; core-libs-dev Libs Subject: RE: RFR 8124977 cmdline encoding challenges on Windows Hi Kumar, Please find updated webreview here: http://cr.openjdk.java.net/~kshoop/8124977/webrev.04/ Thanks, Vladimir. -Original Message- From: Kumar Srinivasan [mailto:kumar.x.sriniva...@oracle.com

Re: RFR 8124977 cmdline encoding challenges on Windows

2016-01-11 Thread Kumar Srinivasan
Srinivasan ; Martin Sawicki Cc: Kirk Shoop ; core-libs-dev Libs Subject: RE: RFR 8124977 cmdline encoding challenges on Windows Hi Kumar, Please find updated webreview here: http://cr.openjdk.java.net/~kshoop/8124977/webrev.04/ Thanks, Vladimir. -Original Message- From: Kumar Srinivasan

RE: RFR 8124977 cmdline encoding challenges on Windows

2016-01-07 Thread Martin Sawicki
Sawicki Cc: Kirk Shoop ; Vladimir Shcherbakov ; core-libs-dev Libs Subject: Re: RFR 8124977 cmdline encoding challenges on Windows Hi Martin, et. al., Sorry for not getting back earlier, I am very busy right now with my other large commitments for JDK9. I will sponsor this "enhancement/bu

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-11-30 Thread Vladimir Shcherbakov
Shcherbakov ; core-libs-dev Libs Subject: Re: RFR 8124977 cmdline encoding challenges on Windows Hi Martin, et. al., Sorry for not getting back earlier, I am very busy right now with my other large commitments for JDK9. I will sponsor this "enhancement/bug fix" sometime in th

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-11-22 Thread Kumar Srinivasan
2015 6:26 AM To: Kirk Shoop (MS OPEN TECH) Cc: Valery Kopylov (Akvelon) ; core-libs-dev Libs Subject: Re: RFR 8124977 cmdline encoding challenges on Windows Hi Kirk, Thanks for proposing this change. If you notice all the posix calls are wrapped in JLI_* this gives us the ability to use &q

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-09-28 Thread Martin Sawicki
Libs Subject: Re: RFR 8124977 cmdline encoding challenges on Windows Hi Kirk, Thanks for proposing this change. If you notice all the posix calls are wrapped in JLI_* this gives us the ability to use "W" functions. I almost got it done, several years ago, but we upgraded to VS2010 and m

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-08-07 Thread Martin Buchholz
(only half paying attention) On Wed, Aug 5, 2015 at 7:45 PM, Kirk Shoop wrote: > > This webrev uses GetCommandLineW That sounds right - this should be the source of truth in win32land. > on windows to retrieve the UCS16 "UCS16" confuses me. Do you mean UTF-16 or UCS-2? I'm guessing the f

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-08-07 Thread Kumar Srinivasan
Hi Kirk, We don't allow any shell tests. There are existing shell based tests, I have not had a chance to port all of them. Your test must be rewritten to use the TestHelper framework, please see the other tests in jdk/test/tools/launcher for patterns. Kumar -Original Message- From:

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-08-05 Thread Kirk Shoop
> -Original Message- > From: Xueming Shen [mailto:xueming.s...@oracle.com] > Sent: Monday, July 20, 2015 11:50 AM > > On 07/20/2015 10:22 AM, Kirk Shoop wrote: > > So when default system locale differs from the active one, we have > different behavior on Linux and Windows. The new options

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-07-20 Thread Xueming Shen
On 07/20/2015 10:22 AM, Kirk Shoop wrote: So when default system locale differs from the active one, we have different behavior on Linux and Windows. The new options allow a windows user to select the same behavior that one would expect on unix. The switches can certainly be removed, if the

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-07-20 Thread Kirk Shoop
M > To: Kirk Shoop > Cc: core-libs-dev Libs; Valery Kopylov (Akvelon); Martin Sawicki; > SHEN,XUEMING; Henry Jen > Subject: Re: RFR 8124977 cmdline encoding challenges on Windows > > Hi Kirk, > > I took another pass over the changes. > > IMHO, we need to make it easie

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-07-20 Thread Kirk Shoop
Hi, (1) Yes, the changes don't update the underlying console encoding. There is guidance that apps should not change the console encoding as it would affect other commands in the same console. A script must explicitly use chcp to change the codepage. The change has a new option "file.encoding.

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-07-14 Thread Kumar Srinivasan
Hi Kirk, I took another pass over the changes. IMHO, we need to make it easier for people to use this feature, and eliminate these two, atleast externally. "-Dwindows.UnicodeConsole=true", "-Dfile.encoding.unicode=\"UTF-8\"", Can we invent a new command line arg ? we can make it an -X flag, by

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-07-11 Thread Xueming Shen
Hi Kirk, Two questions (1) Why do you need to change the "encoding" used by the java.io.Console class. My understanding is that the console encoding is specifically used to "talk" to the underlying terminal, it should just be the one used by the underlying terminal/console. I don't t

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-07-10 Thread Ulf Zibis
Am 08.07.2015 um 18:50 schrieb Kirk Shoop: Valery prepared a new webrev which I placed here: http://cr.openjdk.java.net/~kshoop/8124977/webrev.01 May be better to avoid potetially superfluous lookup of UTF-8: public static Charset defaultUnicodeCharset() { if (defaultUnicodeCharset ==

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-07-08 Thread Kirk Shoop
> -Original Message- > From: Kumar Srinivasan [mailto:kumar.x.sriniva...@oracle.com] > > Hi Kirk, > > Thanks for proposing this change. > > If you notice all the posix calls are wrapped in JLI_* this gives us the > ability to use "W" functions. I almost got it done, several years ago,

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-06-25 Thread Kumar Srinivasan
Hi Kirk, Thanks for proposing this change. If you notice all the posix calls are wrapped in JLI_* this gives us the ability to use "W" functions. I almost got it done, several years ago, but we upgraded to VS2010 and my work based on VS2003 keeled over, meanwhile my focus was "shifted" to s

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-06-23 Thread Kirk Shoop (MS OPEN TECH)
> From: Martin Buchholz [mailto:marti...@google.com] > "default unicode charset" is a bizarre concept to me.  Do windows users > really have a "regular" charset and a "unicode" charset?  If they do, we > probably want to keep that concept out of the public non-Windows API somehow.  > Also, the "

RE: RFR 8124977 cmdline encoding challenges on Windows

2015-06-23 Thread Kirk Shoop (MS OPEN TECH)
> -Original Message- > From: Anthony Vanelverdinghe > [mailto:anthony.vanelverdin...@gmail.com] > Sent: Tuesday, June 23, 2015 12:12 PM > > I would like to be able to associate file types with a Java program [1]. > Currently, the Java program doesn't receive the argument (i.e. the path to

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-06-23 Thread Anthony Vanelverdinghe
Hi Thanks for taking on these challenges. I would like to be able to associate file types with a Java program [1]. Currently, the Java program doesn't receive the argument (i.e. the path to the file that was double-clicked) correctly if it contains Unicode characters. I assume this would be p

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-06-22 Thread Martin Buchholz
This was on my TODO list back in 2005 or so. I never got around to it, in part because of my personal and Sun's corporate Unix focus, and because waiting for Win98 to be de-supported was a great way to procrastinate. It's good for Microsoft employees (actual Windows users) to work on this - you h