Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Hi Chris, I haven't noticed your email and have already pushed 8181761. from my point of view, FileUtils depending on Platform class is not a bug, but having lots of seemed to be unrelated @build action is a bug, I added your comment to 8181915

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 12/06/17 15:04, Alan Bateman wrote: ... For now, yes, I think these are okay. As part of the clean-up then it would be good to update FileUtils to not use Platform and that would avoid needing to build jdk.test.lib.Platform in several of these tests. I wrote the original FileUtils. Why

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 12/06/2017 07:09, Igor Ignatyev wrote: Hi Alan, I've filed https://bugs.openjdk.java.net/browse/JDK-8181915 to clean up w/ this mess w/ dependencies in testlibrary classes. just to double check, can I consider this fix and the fixes for tier1[1-2], tier3[3-4] reviewed by you? [1]

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Hi Alan, I've filed https://bugs.openjdk.java.net/browse/JDK-8181915 to clean up w/ this mess w/ dependencies in testlibrary classes. just to double check, can I consider this fix and the fixes for tier1[1-2], tier3[3-4] reviewed by you?

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 09/06/2017 19:36, Igor Ignatyev wrote: Alan, Chris, it seems I had some problems uploading the webrev, I have reuploaded it to the same place -- http://cr.openjdk.java.net/~iignatyev//8181761/webrev.02/index.html -- Igor This mostly looks okay but there are still a few tests being

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Alan, Chris, it seems I had some problems uploading the webrev, I have reuploaded it to the same place -- http://cr.openjdk.java.net/~iignatyev//8181761/webrev.02/index.html -- Igor > On Jun 9, 2017, at 2:01 AM, Alan Bateman wrote: > > On 09/06/2017 07:42, Igor

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 09/06/17 07:42, Igor Ignatyev wrote: here is the refreshed version of patch : http://cr.openjdk.java.net/~iignatyev//8181761/webrev.02/index.html I get 404 Not Found on many links, e.g.

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 09/06/2017 07:42, Igor Ignatyev wrote: here is the refreshed version of patch : http://cr.openjdk.java.net/~iignatyev//8181761/webrev.02/index.html there might be some new @build actions, b/c I have analyzed class

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

here is the refreshed version of patch : http://cr.openjdk.java.net/~iignatyev//8181761/webrev.02/index.html there might be some new @build actions, b/c I have analyzed class files from all tests instead of looking only at

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 2017/6/9 12:19, Igor Ignatyev wrote: Hi Hamlin, Hi Igor, Thank you for explanation. I'm going to add explicit @build for jdk.test.lib.** classes in jdk tests which are in :tier[1-3]. Got it. unfortunately this approach does not work if a test depends on a library indirectly, e.g. you

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Hi Hamlin, I'm going to add explicit @build for jdk.test.lib.** classes in jdk tests which are in :tier[1-3]. unfortunately this approach does not work if a test depends on a library indirectly, e.g. you might have a couple of tests which share some code (but not from /test/lib or

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Hi Igor, I'm coping Jon as it needs Jon's comments. Thank you for doing such a great refactoring, I believe it will make tests run more stable. I saw you are adding explicit @build to lots of test, are you going to clean up all tests to add explicit @build? If the answer is "yes", then I

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

> On Jun 8, 2017, at 9:35 AM, Alan Bateman wrote: > > On 08/06/2017 17:18, Igor Ignatyev wrote: >> Alan, >> >> I totally agree there are many places which we need to clean up in >> testlibraries, including these weird dependencies, but it would be much >> easier to

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

A different, more incremental approach, would be to look at the totality of the functionality being provided in libraries, and to (re)design the libraries to minimize inter-library and inter-package package dependencies, with a view to using but minimizing @build directives. (Meaning, provide

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 6/8/17 9:18 AM, Igor Ignatyev wrote: Alan, I totally agree there are many places which we need to clean up in testlibraries, including these weird dependencies, but it would be much easier to clean up test libraries after they are merged in one place. personally I don't think that

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 08/06/2017 17:18, Igor Ignatyev wrote: Alan, I totally agree there are many places which we need to clean up in testlibraries, including these weird dependencies, but it would be much easier to clean up test libraries after they are merged in one place. personally I don't think that

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

testing showed, that I missed one test, fixed and retested. http://cr.openjdk.java.net/~iignatyev//8181761/webrev.01/index.html > diff -r 8d381ca2a358 > test/java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java >

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Alan, I totally agree there are many places which we need to clean up in testlibraries, including these weird dependencies, but it would be much easier to clean up test libraries after they are merged in one place. personally I don't think that NetworkConfiguration depending on Platform is a

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

> On 8 Jun 2017, at 16:52, Alan Bateman wrote: > > On 08/06/2017 16:24, Igor Ignatyev wrote: >> Chris/Alan, >> >> Although the test itself doesn't launch new VMs, >> jdk.test.lib.NetworkConfiguration, which this test directly depends on, >> depends on

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 08/06/2017 16:24, Igor Ignatyev wrote: Chris/Alan, Although the test itself doesn't launch new VMs, jdk.test.lib.NetworkConfiguration, which this test directly depends on, depends on jdk.test.lib.Platform which depends on jdk.test.lib.Utils. and j.t.l.Utils depend on

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

> On 8 Jun 2017, at 16:24, Igor Ignatyev wrote: > > Chris/Alan, > > Although the test itself doesn't launch new VMs, > jdk.test.lib.NetworkConfiguration, which this test directly depends on, > depends on jdk.test.lib.Platform Oh I see this now. I originally wrote

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Chris/Alan, Although the test itself doesn't launch new VMs, jdk.test.lib.NetworkConfiguration, which this test directly depends on, depends on jdk.test.lib.Platform which depends on jdk.test.lib.Utils. and j.t.l.Utils depend on jdk.test.lib.process.* classes as it might start new VMs. [1] is

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 08/06/2017 11:11, Chris Hegarty wrote: : Just quickly looking at some of the networking test, e.g. JoinLeave: * @bug 4091811 4148753 4102731 * @summary Test java.net.MulticastSocket joinGroup and leaveGroup * @library /test/lib + * @build jdk.test.lib.NetworkConfiguration + *

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Igor, > On 8 Jun 2017, at 08:20, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev//8181761/webrev.00/index.html >> 432 lines changed: 404 ins; 1 del; 27 mod; > > Hi all, > > could you please review this changeset which adds explicit @build actions to >

RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

http://cr.openjdk.java.net/~iignatyev//8181761/webrev.00/index.html > 432 lines changed: 404 ins; 1 del; 27 mod; Hi all, could you please review this changeset which adds explicit @build actions to tier2 jdk tests? other tests will be updated by the corresponding sub-tasks of 8181758[1].