Hi,
the aim of this PR was firstly to have a correct implementation of the
spec. Speed improvement was a secondary goal, which was intentionally
pursued with conventional Java arithmetic and just a few calls to simple
methods in the standard library.
Whether the Vector API (which is still
On Mon, 9 May 2022 12:50:31 GMT, Raffaello Giulietti
wrote:
>> Marked as reviewed by limck...@github.com (no known OpenJDK username).
>
> @limck599
> While we at OpenJDK appreciate constructive reviews from GitHub users not
> registered in the [census](https://openjdk.java.net/census), only
On Tue, 10 May 2022 03:22:01 GMT, Joe Darcy wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 4511638: Double.toString(double) sometimes produces incorrect results
>
>
On Tue, 10 May 2022 15:50:26 GMT, Raffaello Giulietti
wrote:
> `[Float|Double]ToDecimal` do not have access to `AbstractStringBuilder`, so
> have to fail over `Appendable`, which can throw `IOException` in `append(*)`
> methods.
>
> I have to find another way if this wrapping to make the
On Tue, 10 May 2022 03:21:21 GMT, Joe Darcy wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 4511638: Double.toString(double) sometimes produces incorrect results
>
>
On Mon, 9 May 2022 12:38:48 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Mon, 9 May 2022 12:34:20 GMT, limck599 wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 4511638: Double.toString(double) sometimes produces incorrect results
>
> Marked as reviewed by limck...@github.com
On Mon, 9 May 2022 12:34:20 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
> Hello,
>
> here's a PR for a patch submitted on March 2020
> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a
> thing.
>
> The patch has been edited to adhere to OpenJDK code conventions about
> multi-line (block) comments. Nothing in the code proper has
