Re: RFR: 6594697 - varargs message and Throwable methods for java.util.Logger

I've prepared a new webrev retaining the parameter ordering, but removing the isLoggable() refactoring for now. http://cr.openjdk.java.net/~jgish/Bug6594697-AddLogThrowable/ Thanks, Jim If this looks o.k. I'll submit to CC

Re: RFR: 6594697 - varargs message and Throwable methods for java.util.Logger

On 30/10/2012 14:21, Jim Gish wrote: I was one the fence with the parameter ordering and would like additional feedback on this point. I started off as you suggested, but didn't like the fact that the params were separated from the msg by the Throwable. I could go either way, but would like t

Re: RFR: 6594697 - varargs message and Throwable methods for java.util.Logger

wable thrown)* So this will keep it consistent. Thanks Sandeep *From:*Jim Gish *Sent:* Monday, October 29, 2012 4:33 PM *To:* core-libs-dev *Cc:* Rajendra Inamdar; Sandeep Shrivastava *Subject:* RFR: 6594697 - varargs message and Throwable methods for java.util.Logger Please review

RFR: 6594697 - varargs message and Throwable methods for java.util.Logger

Please review http://cr.openjdk.java.net/~jgish/Bug6594697-AddLogThrowable/ This change adds three new methods to Logger that provide a Throwable along with a varags Object list as parameters to the log message. In addition, i