Hi Henry,
On 10/8/2013 10:57 PM, Henry Jen wrote:
Hi,
Please review updated webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/6/webrev
ProxyClassesDumper looks simpler after moving the path validation to the
static factory method.
One minor comment:
ProxyClassesDumper.getInstance
Thanks Mandy, and all others have reviewed and commented.
Cheers,
Henry
On 10/09/2013 02:47 AM, Mandy Chung wrote:
Hi Henry,
On 10/8/2013 10:57 PM, Henry Jen wrote:
Hi,
Please review updated webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/6/webrev
ProxyClassesDumper looks
Hi,
Please review updated webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/6/webrev
In this update,
- Check the specified directory once, disable dumping if it is invalid.
This address the comment of unnecessary complexity, as this is a debug
feature and most likely developer would
Hi Henry,
I think you want to revert the order of the following two lines in
ProxyClassDumper:
67 isReadyToUse();
68 dumpDir = tmp;
Otherwise looks good now.
The following is up to you. Just style nits...
If you wanted to be extra user-friendly, you could log all
OK, hopefully we are close to the end here on comments, unless there are
security related issues. We still need +1 from a jdk8 reviewer,
http://cr.openjdk.java.net/~henryjen/ccc/8023524/5/webrev
This update include what Peter's latest suggestion, and since we don't
have a reliable way to create
Hi,
Please review update of the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/4/webrev
This update address comments from Remi and Peter,
- Remove the unnecessary static field, also take out not needed
singleton behavior of ProxyClassesDumper
- Ensure InvalidPathException won't stop
On 09/19/2013 01:00 AM, Henry Jen wrote:
Class names can contain '\' and other characters which are problematic
on Windows.
Thanks for reviewing, I suspect you are pointing out a potential issue
to look at, not that the problem exists in current implementation.
According to JLS 3.8, the
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/0/webrev/
This webrev enable writing generated classes for lambda to disk at a
directory specified with -Djdk.internal.lambda.dumpProxyClasses.
The directory has to be an existing writable directory, otherwise, a
On 09/18/2013 04:56 AM, Florian Weimer wrote:
On 09/18/2013 08:18 AM, Henry Jen wrote:
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/0/webrev/
This webrev enable writing generated classes for lambda to disk at a
directory specified with