Re: RFR: 8025342: NLS: unsupported translation format in jar/pack/DriverResource.java

2013-10-01 Thread Michael Fang
Hi Kumar, Looks good. Thanks for addressing translatability conformance of this file. thanks, -michael On 13年10月01日 11:46 上午, Kumar Srinivasan wrote: Hi Naoto, Michael, Please review the webrev below. Apparently using variables to hold the common message strings between pack200(1) and unpa

Re: RFR: 8025342: NLS: unsupported translation format in jar/pack/DriverResource.java

2013-10-01 Thread Kumar Srinivasan
Hi Kumar, Just a cosmetic comment. Looks like the description columns at line 103 (and before) and line 104 (and after) do not align to each other. yes indeed, I will fix that. Thanks Naoto! Kumar Otherwise it looks good to me. Naoto On 10/1/13 11:46 AM, Kumar Srinivasan wrote: Hi

Re: RFR: 8025342: NLS: unsupported translation format in jar/pack/DriverResource.java

2013-10-01 Thread Naoto Sato
Hi Kumar, Just a cosmetic comment. Looks like the description columns at line 103 (and before) and line 104 (and after) do not align to each other. Otherwise it looks good to me. Naoto On 10/1/13 11:46 AM, Kumar Srinivasan wrote: Hi Naoto, Michael, Please review the webrev below. Apparent

RFR: 8025342: NLS: unsupported translation format in jar/pack/DriverResource.java

2013-10-01 Thread Kumar Srinivasan
Hi Naoto, Michael, Please review the webrev below. Apparently using variables to hold the common message strings between pack200(1) and unpack200(1) utilities don't bode well, with the new globalization tools. Thus the request is to remove these common variable and inline these in the messag