Re: RFR: 8130051 Cleanup usage of reflection in jaxp

2015-06-30 Thread Daniel Fuchs
Hi Joe, Paul, On 30/06/15 10:47, Daniel Fuchs wrote: OK - I will replace the offending diamonds before pushing. On 30/06/15 10:49, Paul Sandoz wrote:> I am beseech you not to do that! > > Unless there is a really strong reason why JAXP 8 code should be the > same as JAXP 9 code we should be a

Re: RFR: 8130051 Cleanup usage of reflection in jaxp

2015-06-30 Thread Daniel Fuchs
Hi Joe, On 30/06/15 00:52, huizhe wang wrote: Hi Daniel, Another great cleanup! The change looks good to me. Only minor suggestion: same as 8129956, would you want to add the types back instead of using diamond operator? It looks good, but the red flags in the NetBeans could be a bit troubleso

Re: RFR: 8130051 Cleanup usage of reflection in jaxp

2015-06-29 Thread huizhe wang
Hi Daniel, Another great cleanup! The change looks good to me. Only minor suggestion: same as 8129956, would you want to add the types back instead of using diamond operator? It looks good, but the red flags in the NetBeans could be a bit troublesome. Plus, honestly, I still regularly compil

RFR: 8130051 Cleanup usage of reflection in jaxp

2015-06-29 Thread Daniel Fuchs
Hi, Please find below a patch that cleans up some of the reflection usage in jaxp. https://bugs.openjdk.java.net/browse/JDK-8130051 http://cr.openjdk.java.net/~dfuchs/webrev_8130051/webrev.00/ This is not a deep cleanup - it is just a first pass... There may be some opportunity to get rid of so