Re: RFR: 8143165 Add Statement.isSimpleIdentifier and update enquoteLiteral

Hi Roger Thank you for the feedback On Nov 24, 2015, at 4:11 PM, Roger Riggs wrote: > Hi Lance, > > Statement.java: > - "contains a {@code null} character or double quote, and is not a simple SQL > identifier." > > The "," is not needed and changes the semantics if it is present. > > +1518:

Re: RFR: 8143165 Add Statement.isSimpleIdentifier and update enquoteLiteral

+1 On 11/24/2015 5:18 PM, Lance Andersen wrote: Hi Roger Thank you for the feedback On Nov 24, 2015, at 4:11 PM, Roger Riggs > wrote: Hi Lance, Statement.java: - "contains a {@code null} character or double quote, and is not a simple SQL identifier." The "

Re: RFR: 8143165 Add Statement.isSimpleIdentifier and update enquoteLiteral

Looks good, Lance. Have a great holiday when all these improvements are done :-) Best, Joe On 11/24/2015 11:48 AM, Lance Andersen wrote: Hi, Please provide a review for http://cr.openjdk.java.net/~lancea/8143165/webrev.00/. This adds Statement.isSimpleIdentifier, adds a throws SQLException

Re: RFR: 8143165 Add Statement.isSimpleIdentifier and update enquoteLiteral

Hi Lance, Statement.java: - "contains a {@code null} character or double quote, and is not a simple SQL identifier." The "," is not needed and changes the semantics if it is present. +1518: - "The string is between 1 and 128 characters in length" You might want to add the word inclusive, ot

RFR: 8143165 Add Statement.isSimpleIdentifier and update enquoteLiteral

Hi, Please provide a review for http://cr.openjdk.java.net/~lancea/8143165/webrev.00/. This adds Statement.isSimpleIdentifier, adds a throws SQLException to Statement.enquoteLiteral and includes a few additional tests Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.4