Re: RFR: 8159590: Remove deprecated methods from jdk.internal.misc.VM

2016-06-20 Thread Claes Redestad
On 2016-06-20 14:42, David Holmes wrote: On 17/06/2016 10:20 PM, Claes Redestad wrote: On 2016-06-17 03:35, David Holmes wrote: On 17/06/2016 8:20 AM, Claes Redestad wrote: HS: http://cr.openjdk.java.net/~redestad/8159590/hotspot.02/ JDK: http://cr.openjdk.java.net/~redestad/8159590/jdk.

Re: RFR: 8159590: Remove deprecated methods from jdk.internal.misc.VM

2016-06-20 Thread David Holmes
On 17/06/2016 10:20 PM, Claes Redestad wrote: On 2016-06-17 03:35, David Holmes wrote: Hi Claes, On 17/06/2016 8:20 AM, Claes Redestad wrote: Isn't this variable unused now: 63 boolean vmAllowSuspension; Interestingly enough there are hooks in hotspot to compute offsets of various f

Re: RFR: 8159590: Remove deprecated methods from jdk.internal.misc.VM

2016-06-17 Thread Claes Redestad
On 2016-06-17 03:35, David Holmes wrote: Hi Claes, On 17/06/2016 8:20 AM, Claes Redestad wrote: Isn't this variable unused now: 63 boolean vmAllowSuspension; Interestingly enough there are hooks in hotspot to compute offsets of various fields in j.l.ThreadGroup, so even though the vm

Re: RFR: 8159590: Remove deprecated methods from jdk.internal.misc.VM

2016-06-16 Thread David Holmes
Hi Claes, On 17/06/2016 8:20 AM, Claes Redestad wrote: Hi David, On 2016-06-16 23:11, David Holmes wrote: On 16/06/2016 10:52 PM, Claes Redestad wrote: On 06/16/2016 02:48 PM, Chris Hegarty wrote: Apologies, you corrected me off-line, TG.allowThreadSuspension calls VM.unsuspendSomeThreads

Re: RFR: 8159590: Remove deprecated methods from jdk.internal.misc.VM

2016-06-16 Thread Claes Redestad
Hi David, On 2016-06-16 23:11, David Holmes wrote: On 16/06/2016 10:52 PM, Claes Redestad wrote: On 06/16/2016 02:48 PM, Chris Hegarty wrote: Apologies, you corrected me off-line, TG.allowThreadSuspension calls VM.unsuspendSomeThreads ( which is a no-op ) and not VM.unsuspendThreads ( which

Re: RFR: 8159590: Remove deprecated methods from jdk.internal.misc.VM

2016-06-16 Thread David Holmes
On 16/06/2016 10:52 PM, Claes Redestad wrote: On 06/16/2016 02:48 PM, Chris Hegarty wrote: Apologies, you corrected me off-line, TG.allowThreadSuspension calls VM.unsuspendSomeThreads ( which is a no-op ) and not VM.unsuspendThreads ( which I thought it did ). In which case I am ok with the

Re: RFR: 8159590: Remove deprecated methods from jdk.internal.misc.VM

2016-06-16 Thread Claes Redestad
On 06/16/2016 02:48 PM, Chris Hegarty wrote: Apologies, you corrected me off-line, TG.allowThreadSuspension calls VM.unsuspendSomeThreads ( which is a no-op ) and not VM.unsuspendThreads ( which I thought it did ). In which case I am ok with the change. Ok, thanks! :-) I think we should

Re: RFR: 8159590: Remove deprecated methods from jdk.internal.misc.VM

2016-06-16 Thread Chris Hegarty
Apologies, you corrected me off-line, TG.allowThreadSuspension calls VM.unsuspendSomeThreads ( which is a no-op ) and not VM.unsuspendThreads ( which I thought it did ). In which case I am ok with the change. I think we should add ‘forRemoval = true’ while here. -Chris. > On 16 Jun 2016, a

Re: RFR: 8159590: Remove deprecated methods from jdk.internal.misc.VM

2016-06-16 Thread Chris Hegarty
On 15 Jun 2016, at 14:30, Claes Redestad wrote: > > Hi, > > after VM.java was encapsulated and moved from sun.misc to jdk.internal.misc, > the rationale for keeping a number of deprecated methods and constants no > longer applies and these methods should be removed: > > Webrev: http://cr.open

RFR: 8159590: Remove deprecated methods from jdk.internal.misc.VM

2016-06-15 Thread Claes Redestad
Hi, after VM.java was encapsulated and moved from sun.misc to jdk.internal.misc, the rationale for keeping a number of deprecated methods and constants no longer applies and these methods should be removed: Webrev: http://cr.openjdk.java.net/~redestad/8159590/webrev.01/ Bug: https://bugs.open