Hi Lance,
The revised webrev is at
http://cr.openjdk.java.net/~lancea/8211917/webrev.02/index.html
This looks good to me now. Ship it
Cheers
Christoph
Hi Christoph
> On Mar 5, 2020, at 4:03 AM, Langer, Christoph
> wrote:
>
> Hi Lance,
>
> Thanks for addressing my points. Here my answer to those things which weren't
> in full agreement yet:
Please see below
>
>> I dislike a bit the fact that we introduce a new testng subfolder in
>>
Hi Lance,
Thanks for addressing my points. Here my answer to those things which weren't
in full agreement yet:
> I dislike a bit the fact that we introduce a new testng subfolder in
> test/jdk/nio/zipfs. Wouldn’t it be possible to consolidate in the current test
> folder?
>
> I am trying to
Hi Jaikiran
> On Mar 4, 2020, at 9:54 AM, Jaikiran Pai wrote:
>
> Hello Lance,
>
> On 28/02/20 2:41 am, Lance Andersen wrote:
>> Hi Christoph,
>>
>> I have cleaned up, re-vamped and added more coverage to the test. As part
>> of this I started to lay the foundation for removing some of the
Hello Lance,
On 28/02/20 2:41 am, Lance Andersen wrote:
> Hi Christoph,
>
> I have cleaned up, re-vamped and added more coverage to the test. As
> part of this I started to lay the foundation for removing some of the
> duplicate code as part of continued clean up and enhanced coverage
> going
Hello Lance,
On 15/02/20 2:27 am, Lance Andersen wrote:
> Hi Jaikiran,
>
> I think the changes to ZipFileSystem are OK.
>
> The test overall is good. I am going to streamline it a bit and
> remove the long lines (we try to keep lines to around 80 characters).
>
I'll keep that in mind for future
Hi Jaikiran,
I think the changes to ZipFileSystem are OK.
The test overall is good. I am going to streamline it a bit and remove the
long lines (we try to keep lines to around 80 characters).
I will push a revised webrev out once I do this over the next few days
Best
Lance
> On Feb 12,
I realized that the verify() method in the testcase can include a couple
of more tests while dealing with the JarInputStream. So I've updated
that method and created a fresh webrev which is available at
https://cr.openjdk.java.net/~jpai/webrev/8211917/3/webrev/
-Jaikiran
On 11/02/20 10:03 pm,
Hello Lance,
On 05/02/20 3:13 am, Lance Andersen wrote:
> Hi Jaikiran,
>
> Thank you again for tackling this feature request.
>
> Overall, I think this looks OK.
>
> In ZipFileSystem.java, I would reverse the if statement given a
> MANiFEST.MF present is going to be the exception vs the norm.
