Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-12-10 Thread Alan Bateman
On 10/12/2018 11:05, Magnus Ihse Bursie wrote: On 2018-12-10 11:56, Nick Gasson (Arm Technology China) wrote: Hi, Any update on this one? Or do we want to give up on it until JDK-8165620 is implemented? I think Alan reviewed it as OK with just a minor fix, and offered to sponsor it for you.

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-12-10 Thread Magnus Ihse Bursie
On 2018-12-10 11:56, Nick Gasson (Arm Technology China) wrote: Hi, Any update on this one? Or do we want to give up on it until JDK-8165620 is implemented? I think Alan reviewed it as OK with just a minor fix, and offered to sponsor it for you. Then the discussion started about some major

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-12-10 Thread Nick Gasson (Arm Technology China)
Hi, Any update on this one? Or do we want to give up on it until JDK-8165620 is implemented? Thanks, Nick On 28/11/2018 11:33, Martin Buchholz wrote: > > > On Tue, Nov 27, 2018 at 7:25 PM, Nick Gasson > wrote: > > > I missed one thing then looking at this.

RE: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-29 Thread Nick Gasson
Subject: Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32 On Tue, Nov 27, 2018 at 7:25 PM, Nick Gasson mailto:nick.gas...@arm.com>> wrote: > I missed one thing then looking at this. In TimeZone_md.c it should be > #ifdef MACOSX rather than #ifndef. I

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-27 Thread Martin Buchholz
On Tue, Nov 27, 2018 at 7:25 PM, Nick Gasson wrote: > > I missed one thing then looking at this. In TimeZone_md.c it should be > > #ifdef MACOSX rather than #ifndef. I can sponsor the change for you but > > I need to change this one line before pushing. > > Hi Alan, > > Yes feel free to modify

RE: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-27 Thread Nick Gasson
dif Nick > -Original Message- > From: Alan Bateman > Sent: 28 November 2018 03:14 > To: Nick Gasson ; Magnus Ihse Bursie > ; build-dev ; > core-libs-dev@openjdk.java.net > Cc: nd > Subject: Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on >

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-27 Thread Alan Bateman
On 26/11/2018 09:08, Nick Gasson wrote: Hi Alan, I've done this here: http://cr.openjdk.java.net/~njian/8214077/webrev.3/ I missed one thing then looking at this. In TimeZone_md.c it should be #ifdef MACOSX rather than #ifndef. I can sponsor the change for you but I need to change this one

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-27 Thread Alan Bateman
On 27/11/2018 13:28, Magnus Ihse Bursie wrote: 26 nov. 2018 kl. 13:27 skrev Alan Bateman : On 26/11/2018 09:08, Nick Gasson wrote: Hi Alan, I've done this here: http://cr.openjdk.java.net/~njian/8214077/webrev.3/ This looks good and I think means we no longer have any stat usages in

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-27 Thread Magnus Ihse Bursie
> 26 nov. 2018 kl. 13:27 skrev Alan Bateman : > >> On 26/11/2018 09:08, Nick Gasson wrote: >> Hi Alan, >> >> I've done this here: >> >> http://cr.openjdk.java.net/~njian/8214077/webrev.3/ > This looks good and I think means we no longer have any stat usages in > libjava. Do we have stat

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-26 Thread Alan Bateman
On 26/11/2018 09:08, Nick Gasson wrote: Hi Alan, I've done this here: http://cr.openjdk.java.net/~njian/8214077/webrev.3/ This looks good and I think means we no longer have any stat usages in libjava. -Alan

RE: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-26 Thread Nick Gasson
jdk.java.net/~njian/8214077/webrev.3/ Thanks, Nick > -Original Message- > From: Alan Bateman > Sent: 23 November 2018 19:42 > To: Nick Gasson ; Magnus Ihse Bursie > ; build-dev ; > core-libs-dev@openjdk.java.net > Cc: nd > Subject: Re: RFR: 8214077: test jav

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-23 Thread Alan Bateman
On 23/11/2018 11:13, Nick Gasson wrote: This looks right and reduces the stat usages in libjava down to one remaining case (ProcessHandlerImpl_linux.c). Hi Alan, Do you want me to do this one too for completeness? Although as it's calling stat() on the /proc/ directory I don't think it's

RE: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-23 Thread Nick Gasson
Thanks, Nick > -Original Message- > From: Alan Bateman > Sent: 23 November 2018 19:01 > To: Nick Gasson ; Magnus Ihse Bursie > ; build-dev ; > core-libs-dev@openjdk.java.net > Cc: nd > Subject: Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on &g

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-23 Thread Alan Bateman
On 23/11/2018 09:37, Nick Gasson wrote: Hi Alan, I've done this here: http://cr.openjdk.java.net/~njian/8214077/webrev.2/ This looks right and reduces the stat usages in libjava down to one remaining case (ProcessHandlerImpl_linux.c). I'm a bit unsure about #ifndef MACOSX - some existing

RE: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-23 Thread Nick Gasson
nus Ihse Bursie > ; build-dev ; > core-libs-dev@openjdk.java.net > Cc: nd > Subject: Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on > ARM32 > > > > On 22/11/2018 10:54, Nick Gasson wrote: > >>>> Have you looked at replacing the

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-22 Thread Alan Bateman
On 22/11/2018 10:54, Nick Gasson wrote: Have you looked at replacing the remaining usages of stat changed to stat64 instead? I've tried this just now and it also resolves the issue. I can test on some more platforms and update the webrev if this is the preferred solution? I'd say this is

RE: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-22 Thread Nick Gasson
> Sent: 21 November 2018 20:00 > To: Nick Gasson ; Alan Bateman > ; build-dev ; core- > libs-...@openjdk.java.net > Cc: nd > Subject: Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on > ARM32 > > On 2018-11-21 11:08, Nick Gasson wrote: > > >

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-21 Thread Magnus Ihse Bursie
Subject: Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32 On 21/11/2018 02:46, Nick Gasson wrote: Hi, Can someone please help me review this small makefile patch to fix an issue with java.io.File::setLastModified on 32-bit systems? https://bugs.openjdk.java.net/browse/JDK

RE: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-21 Thread Nick Gasson
-- > From: Alan Bateman > Sent: Wednesday, November 21, 2018 4:55 PM > To: Nick Gasson ; build-dev d...@openjdk.java.net>; core-libs-dev@openjdk.java.net > Cc: nd > Subject: Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on > ARM32 > > On 21/11/2

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-21 Thread Alan Bateman
On 21/11/2018 02:46, Nick Gasson wrote: Hi, Can someone please help me review this small makefile patch to fix an issue with java.io.File::setLastModified on 32-bit systems? https://bugs.openjdk.java.net/browse/JDK-8214077 http://cr.openjdk.java.net/~njian/8214077/webrev.0/ If the file size

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-20 Thread David Holmes
Hi Nick, I'll leave it for core-libs and build folk to review this, but just for some background ... This is a bit of a recurring issue. We have the all encompassing: https://bugs.openjdk.java.net/browse/JDK-8165620 "Entire JDK should be built with -D_FILE_OFFSET_BITS=64" then we had the

RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-20 Thread Nick Gasson
Hi, Can someone please help me review this small makefile patch to fix an issue with java.io.File::setLastModified on 32-bit systems? https://bugs.openjdk.java.net/browse/JDK-8214077 http://cr.openjdk.java.net/~njian/8214077/webrev.0/ If the file size is > 2GB so that the size won't fit in a