On 2/20/19 10:57 AM, Daniel Fuchs wrote:
Right - here is an updated webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8216363/webrev.02/
Looks good.
Mandy
On 20/02/2019 18:27, Mandy Chung wrote:
Here is the new webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8216363/webrev.01/
Looks good.
Thanks Mandy!
I suggest to make the javadoc clear that isLoggable accepts null
@param record a {@code LogRecord} or {@code null}
Right - here is an
Hi Daniel,
I return today from vacation.
On 2/15/19 10:46 AM, Daniel Fuchs wrote:
Hi Mandy,
Here is the new webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8216363/webrev.01/
Looks good.
I suggest to make the javadoc clear that isLoggable accepts null
@param record a {@code LogRecord}
Hi Lance,
On 15/02/2019 20:07, Lance Andersen wrote:
Hi Daniel
so it looks like it was an intentional decision to support the NPE but
looks like an oversight to update the javadoc?
Well I guess it was intentional to return false for null in
StreamHandlers and FileHandlers, but the spec said
Hi Daniel
so it looks like it was an intentional decision to support the NPE but looks
like an oversight to update the javadoc?
I think you could go either way with this as I gotta believe their is a very
low compatibility impact either way…
> On Feb 15, 2019, at 1:46 PM, Daniel Fuchs wrote
Hi Mandy,
Here is the new webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8216363/webrev.01/
It is much nicer than the previous version [1], but unfortunately
it makes the following JCK tests fail:
api/java_util/logging/MemoryHandler/IsLoggable.html
api/java_util/logging/MemoryHandler/Publis
On 2/14/19 12:39 PM, Daniel Fuchs wrote:
Let me redo my fix and see if the JCK complains.
I'd be surprised if there is a JCK test expecting NPE. Will see.
I suggest to update @param record to say "a LogRecord or null"
to be explicit.
Mandy
Hi Mandy,
On 14/02/19 20:20, Mandy Chung wrote:
Fixing the implementation of Handler::isLoggable to return false
if null to match the specification seems similar risk to changing
the spec. What do you think?
How so? I mean - if no line of code is changed, then surely we can't
break existing c
Hi Daniel,
I wonder how a null LogRecord can be passed to Handler::isLoggable
in the code path during logging.
The package summary specifies that NPE will be thrown for null
argument unless it's explicitly specified. Handler.isLoggable
does specify to return false if LogRecord is null. If you
Hi Daniel,
> On Feb 14, 2019, at 2:22 PM, Daniel Fuchs wrote:
>
> Hi Lance,
>
> On 14/02/2019 20:18, Lance Andersen wrote:
>> Documenting the current behavior as it has been makes the most sense to me
>> as well
>> Have you created a CSR yet? if so I will add myself as a reviewer?
>
> I haven'
Hi Lance,
On 14/02/2019 20:18, Lance Andersen wrote:
Documenting the current behavior as it has been makes the most sense to
me as well
Have you created a CSR yet? if so I will add myself as a reviewer?
I haven't created a CSR yet.
This is a small low-priority fix - so it seemed preferable
Hi Daniel
> On Feb 14, 2019, at 2:10 PM, Daniel Fuchs wrote:
>
> Hi,
>
> Please find below a doc fix for:
>
> 8216363: NullPointerException in java.util.logging.Handler#isLoggable
> https://bugs.openjdk.java.net/browse/JDK-8216363
>
> webrev:
> http://cr.openjdk.java.net/~dfuchs/webrev_8216363
Hi,
Please find below a doc fix for:
8216363: NullPointerException in java.util.logging.Handler#isLoggable
https://bugs.openjdk.java.net/browse/JDK-8216363
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8216363/webrev.00/index.html
java.util.logging.Handler specifies that Handler.isLoggable
13 matches
Mail list logo
