Re: RFR: 8231640: (prop) Canonical property storage [v17]

2021-09-16 Thread Jaikiran Pai
On 16/09/21 4:05 am, Roger Riggs wrote: On Wed, 15 Sep 2021 21:46:59 GMT, Stuart Marks wrote: src/java.base/share/classes/java/util/Properties.java line 819: 817: * 818: * If the {@systemProperty java.util.Properties.storeDate} is set and 819: * is non-empty (as determined

Re: RFR: 8231640: (prop) Canonical property storage [v17]

2021-09-16 Thread Jaikiran Pai
On Wed, 15 Sep 2021 16:13:56 GMT, Daniel Fuchs wrote: >> src/java.base/share/classes/java/util/Properties.java line 932: >> >>> 930: if (entries instanceof Collections.SynchronizedSet ss >>> 931: && ss.c instanceof EntrySet) { >>> 932: entries =

Re: RFR: 8231640: (prop) Canonical property storage [v17]

2021-09-16 Thread Jaikiran Pai
On Wed, 15 Sep 2021 22:32:33 GMT, Roger Riggs wrote: >> This is a clever way to detect whether the `entrySet()` method has been >> overridden to return something other than the entry-set provided by the >> Properties class... but I'm wondering if it's too clever. Does anyone who >> overrides

Re: RFR: 8231640: (prop) Canonical property storage [v17]

2021-09-15 Thread Jaikiran Pai
On 15/09/21 9:48 pm, Daniel Fuchs wrote: On Wed, 15 Sep 2021 15:31:45 GMT, Roger Riggs wrote: Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision: - Clarify how overriden Properties#entrySet() method impacts the order of stored

Re: RFR: 8231640: (prop) Canonical property storage [v17]

2021-09-15 Thread Roger Riggs
On Wed, 15 Sep 2021 21:46:59 GMT, Stuart Marks wrote: >> src/java.base/share/classes/java/util/Properties.java line 819: >> >>> 817: * >>> 818: * If the {@systemProperty java.util.Properties.storeDate} is set >>> and >>> 819: * is non-empty (as determined by {@link

Re: RFR: 8231640: (prop) Canonical property storage [v17]

2021-09-15 Thread Stuart Marks
On Wed, 15 Sep 2021 15:59:53 GMT, Roger Riggs wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> - Clarify how overriden Properties#entrySet() method impacts the order of >> stored properties >> - Tests to verify

Re: RFR: 8231640: (prop) Canonical property storage [v17]

2021-09-15 Thread Daniel Fuchs
On Wed, 15 Sep 2021 15:31:45 GMT, Roger Riggs wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> - Clarify how overriden Properties#entrySet() method impacts the order of >> stored properties >> - Tests to verify

Re: RFR: 8231640: (prop) Canonical property storage [v17]

2021-09-15 Thread Roger Riggs
On Wed, 15 Sep 2021 06:11:23 GMT, Jaikiran Pai wrote: >> The commit in this PR implements the proposal for enhancement that was >> discussed in the core-libs-dev mailing list recently[1], for >> https://bugs.openjdk.java.net/browse/JDK-8231640 >> >> At a high level - the `store()` APIs in

Re: RFR: 8231640: (prop) Canonical property storage [v17]

2021-09-15 Thread Jaikiran Pai
> The commit in this PR implements the proposal for enhancement that was > discussed in the core-libs-dev mailing list recently[1], for > https://bugs.openjdk.java.net/browse/JDK-8231640 > > At a high level - the `store()` APIs in `Properties` have been modified to > now look for the