On Tue, 15 Sep 2020 16:54:29 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unintended file commit
>
> Thank you for making the changes that Brent and I suggested. This looks
> good.
On Tue, 15 Sep 2020 12:39:11 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for this patch which fixes the issue
>> reported in
>> https://bugs.openjdk.java.net/browse/JDK-8244706?
>> The commit here sets the `OS` header flag to `255` (which represents
>> `unknown`) as
On Tue, 15 Sep 2020 12:39:11 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for this patch which fixes the issue
>> reported in
>> https://bugs.openjdk.java.net/browse/JDK-8244706?
>> The commit here sets the `OS` header flag to `255` (which represents
>> `unknown`) as
> Can I please get a review and a sponsor for this patch which fixes the issue
> reported in
> https://bugs.openjdk.java.net/browse/JDK-8244706?
> The commit here sets the `OS` header flag to `255` (which represents
> `unknown`) as noted in [1]. A new test has been
> included in this commit to
On Sun, 13 Sep 2020 02:22:54 GMT, Jaikiran Pai wrote:
>> Hi Jaikiran,
>>
>> The change seems fine an inline with the RFC. I can sponsor this once we
>> have another review.
>>
>> I have run the JCK tests for Zip/Gzip/Jar and Mach5 JDK tier1, tier2 and
>> tier3
>
> Thank you Lance for the
> Can I please get a review and a sponsor for this patch which fixes the issue
> reported in
> https://bugs.openjdk.java.net/browse/JDK-8244706?
> The commit here sets the `OS` header flag to `255` (which represents
> `unknown`) as noted in [1]. A new test has been
> included in this commit to
> Can I please get a review and a sponsor for this patch which fixes the issue
> reported in
> https://bugs.openjdk.java.net/browse/JDK-8244706?
> The commit here sets the `OS` header flag to `255` (which represents
> `unknown`) as noted in [1]. A new test has been
> included in this commit to
Hi Joe,
Ok, will create one tomorrow.
Best
Lance
> On Sep 14, 2020, at 7:07 PM, Joe Darcy wrote:
>
> Hi Lance,
>
> I'd prefer to err on the side of having a CSR; thanks,
>
> -Joe
>
> On 9/14/2020 3:55 PM, Lance Andersen wrote:
>> Hi Joe,
>>
>> I guess it could. Given it is not used
Hi Lance,
I'd prefer to err on the side of having a CSR; thanks,
-Joe
On 9/14/2020 3:55 PM, Lance Andersen wrote:
Hi Joe,
I guess it could. Given it is not used within the implementation(or
defined outside of the spec), I will defer to you preference :-)
On Sep 14, 2020, at 6:49 PM, Joe
Hi Joe,
I guess it could. Given it is not used within the implementation(or defined
outside of the spec), I will defer to you preference :-)
> On Sep 14, 2020, at 6:49 PM, Joe Darcy wrote:
>
> Should issue have a CSR review for the behavior change?
>
> -Joe
>
> On 9/12/2020 7:25 PM,
Should issue have a CSR review for the behavior change?
-Joe
On 9/12/2020 7:25 PM, Jaikiran Pai wrote:
On Sat, 12 Sep 2020 17:38:34 GMT, Lance Andersen wrote:
Can I please get a review and a sponsor for this patch which fixes the issue
reported in
On Sat, 12 Sep 2020 17:38:34 GMT, Lance Andersen wrote:
>> Can I please get a review and a sponsor for this patch which fixes the issue
>> reported in
>> https://bugs.openjdk.java.net/browse/JDK-8244706?
>> The commit here sets the `OS` header flag to `255` (which represents
>> `unknown`) as
On Fri, 11 Sep 2020 14:17:45 GMT, Jaikiran Pai wrote:
> Can I please get a review and a sponsor for this patch which fixes the issue
> reported in
> https://bugs.openjdk.java.net/browse/JDK-8244706?
> The commit here sets the `OS` header flag to `255` (which represents
> `unknown`) as noted in
Can I please get a review and a sponsor for this patch which fixes the issue
reported in
https://bugs.openjdk.java.net/browse/JDK-8244706?
The commit here sets the `OS` header flag to `255` (which represents `unknown`)
as noted in [1]. A new test has been
included in this commit to verify the
14 matches
Mail list logo
