Re: RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

2020-08-04 Thread Alexey Semenyuk
Looks good. - Alexey On 8/4/2020 1:05 AM, alexander.matv...@oracle.com wrote: Hi Alexey, http://cr.openjdk.java.net/~almatvee/8250646/webrev.02/ I removed stop method. Also, if we called abort from MacDMGBundler exception will be ignored. Thanks, Alexander On 8/3/20 10:10 AM, Alexey

Re: RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

2020-08-04 Thread Andy Herrick
looks good /Andy On 8/4/2020 1:05 AM, alexander.matv...@oracle.com wrote: Hi Alexey, http://cr.openjdk.java.net/~almatvee/8250646/webrev.02/ I removed stop method. Also, if we called abort from MacDMGBundler exception will be ignored. Thanks, Alexander On 8/3/20 10:10 AM, Alexey Semenyuk

Re: RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

2020-08-03 Thread alexander . matveev
Hi Alexey, http://cr.openjdk.java.net/~almatvee/8250646/webrev.02/ I removed stop method. Also, if we called abort from MacDMGBundler exception will be ignored. Thanks, Alexander On 8/3/20 10:10 AM, Alexey Semenyuk wrote: On 7/31/2020 7:36 PM, alexander.matv...@oracle.com wrote: Hi

Re: RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

2020-08-03 Thread Alexey Semenyuk
On 7/31/2020 7:36 PM, alexander.matv...@oracle.com wrote: Hi Alexey, Without modifying some logic in Executor, yes stop is needed. After retryExecutor.stop(); is executed in MacDmgBundler we will still run command (same with abort), and this command will fail and exception will be thrown.

Re: RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

2020-07-31 Thread alexander . matveev
Hi Alexey, Without modifying some logic in Executor, yes stop is needed. After retryExecutor.stop(); is executed in MacDmgBundler we will still run command (same with abort), and this command will fail and exception will be thrown. Stop() is basically like abort, but exception is ignored.

Re: RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

2020-07-31 Thread Alexey Semenyuk
Alexander, Why introduce RetryExecutor.stop() method? Isn't RetryExecutor.abort() sufficient? - Alexey On 7/30/2020 8:10 PM, alexander.matv...@oracle.com wrote: Please review the jpackage fix for bug [1] at [2]. - DMG image can get detach even if "hdiutil detach" return resource busy

Re: RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

2020-07-31 Thread Andy Herrick
looks good to me /Andy On 7/30/2020 8:10 PM, alexander.matv...@oracle.com wrote: Please review the jpackage fix for bug [1] at [2]. - DMG image can get detach even if "hdiutil detach" return resource busy error. Fixed by stopping trying detach if DMG already got detach. [1]

RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

2020-07-30 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. - DMG image can get detach even if "hdiutil detach" return resource busy error. Fixed by stopping trying detach if DMG already got detach. [1] https://bugs.openjdk.java.net/browse/JDK-8250646 [2]