On Wed, 24 Feb 2021 17:37:13 GMT, Severin Gehwolf wrote:
>> Marked as reviewed by andrew (Reviewer).
>
> @gnu-andrew Thanks for the review! I'll retest and then integrate.
Tests look good on my end. Also this check passed all Linux tests (it's a no-op
everywhere else):
https://github.com/jerboa
On Wed, 24 Feb 2021 16:24:32 GMT, Andrew John Hughes wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add comment to parsing logic of /proc/self/cgroup
>
> Marked as reviewed by andrew (Reviewer).
@gnu-andrew Th
> This is an enhancement which solves two issues:
>
> 1. Multiple reads of relevant cgroup interface files. Now interface files are
> only read once per file (just like Hotspot).
> 2. Proxies creation of the impl specific subsystem via `determineType()` as
> before, but now reads all relevant in
On Fri, 12 Feb 2021 12:49:01 GMT, Severin Gehwolf wrote:
>> This is an enhancement which solves two issues:
>>
>> 1. Multiple reads of relevant cgroup interface files. Now interface files
>> are only read once per file (just like Hotspot).
>> 2. Proxies creation of the impl specific subsystem v
On Fri, 12 Feb 2021 12:49:19 GMT, Severin Gehwolf wrote:
>> Setting reviewers to 2 since I want @gnu-andrew to be OK with it too.
>
> Hi Harold,
>
>> Thanks for doing this! Sorry for taking so long to review this change. The
>> change looks good.
>
> Thanks for the review!
>
>> Before pushing
On Fri, 12 Feb 2021 10:19:03 GMT, Severin Gehwolf wrote:
>> Hi Severin,
>> Thanks for doing this! Sorry for taking so long to review this change. The
>> change looks good. Before pushing it, could you add a comment explaining
>> what the code in lines 185-194 of CgroupSubsystemFactory.java i
> This is an enhancement which solves two issues:
>
> 1. Multiple reads of relevant cgroup interface files. Now interface files are
> only read once per file (just like Hotspot).
> 2. Proxies creation of the impl specific subsystem via `determineType()` as
> before, but now reads all relevant in
On Thu, 11 Feb 2021 19:51:43 GMT, Harold Seigel wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>> co
On Tue, 9 Feb 2021 13:31:25 GMT, Severin Gehwolf wrote:
>> This is an enhancement which solves two issues:
>>
>> 1. Multiple reads of relevant cgroup interface files. Now interface files
>> are only read once per file (just like Hotspot).
>> 2. Proxies creation of the impl specific subsystem vi
On Mon, 1 Feb 2021 20:26:54 GMT, Andrew John Hughes wrote:
>> Anybody willing to review this?
>
>> Anybody willing to review this?
>
> I can have a go.
>
> I have two main concerns:
>
> 1. There seems to be little documentation on the new additions. I'm
> particularly concerned about things l
On Mon, 1 Feb 2021 20:26:54 GMT, Andrew John Hughes wrote:
> > Anybody willing to review this?
>
> I can have a go.
>
> I have two main concerns:
>
> 1. There seems to be little documentation on the new additions. I'm
> particularly concerned about things like CgroupV1Subsystem.java where
> This is an enhancement which solves two issues:
>
> 1. Multiple reads of relevant cgroup interface files. Now interface files are
> only read once per file (just like Hotspot).
> 2. Proxies creation of the impl specific subsystem via `determineType()` as
> before, but now reads all relevant in
On Tue, 12 Jan 2021 14:29:28 GMT, Severin Gehwolf wrote:
> Anybody willing to review this?
I can have a go.
I have two main concerns:
1. There seems to be little documentation on the new additions. I'm
particularly concerned about things like CgroupV1Subsystem.java where a big
chunk of docum
On Tue, 12 Jan 2021 14:29:28 GMT, Severin Gehwolf wrote:
>> Ping? Anyone?
>
> Anybody willing to review this?
PING?
-
PR: https://git.openjdk.java.net/jdk/pull/1393
> This is an enhancement which solves two issues:
>
> 1. Multiple reads of relevant cgroup interface files. Now interface files are
> only read once per file (just like Hotspot).
> 2. Proxies creation of the impl specific subsystem via `determineType()` as
> before, but now reads all relevant in
Hi David,
On Wed, 2021-01-13 at 11:33 +1000, David Holmes wrote:
Hi Severin,
On 13/01/2021 12:31 am, Severin Gehwolf wrote:
> On Tue, 15 Dec 2020 12:57:12 GMT, Severin Gehwolf
> wrote:
>
> > > @bobvandette Please review when you've got some cycles to spare.
> > > Much appreciated!
> >
> > Ping
Hi Severin,
On 13/01/2021 12:31 am, Severin Gehwolf wrote:
On Tue, 15 Dec 2020 12:57:12 GMT, Severin Gehwolf wrote:
@bobvandette Please review when you've got some cycles to spare. Much
appreciated!
Ping? Anyone?
Anybody willing to review this?
FYI Bob retired at the end of last year.
On Tue, 15 Dec 2020 12:57:12 GMT, Severin Gehwolf wrote:
>> @bobvandette Please review when you've got some cycles to spare. Much
>> appreciated!
>
> Ping? Anyone?
Anybody willing to review this?
-
PR: https://git.openjdk.java.net/jdk/pull/1393
On Mon, 23 Nov 2020 19:58:20 GMT, Severin Gehwolf wrote:
>>> With respect to JDK-8255908, the changes look good to me.
>>
>> Thanks!
>
> @bobvandette Please review when you've got some cycles to spare. Much
> appreciated!
Ping? Anyone?
-
PR: https://git.openjdk.java.net/jdk/pull/
> This is an enhancement which solves two issues:
>
> 1. Multiple reads of relevant cgroup interface files. Now interface files are
> only read once per file (just like Hotspot).
> 2. Proxies creation of the impl specific subsystem via `determineType()` as
> before, but now reads all relevant in
On Mon, 23 Nov 2020 19:39:18 GMT, Poonam Bajaj wrote:
> With respect to JDK-8255908, the changes look good to me.
Thanks!
-
PR: https://git.openjdk.java.net/jdk/pull/1393
On Mon, 23 Nov 2020 19:56:56 GMT, Severin Gehwolf wrote:
>> With respect to JDK-8255908, the changes look good to me.
>
>> With respect to JDK-8255908, the changes look good to me.
>
> Thanks!
@bobvandette Please review when you've got some cycles to spare. Much
appreciated!
-
PR
On Mon, 23 Nov 2020 15:50:18 GMT, Severin Gehwolf wrote:
>> This is an enhancement which solves two issues:
>>
>> 1. Multiple reads of relevant cgroup interface files. Now interface files
>> are only read once per file (just like Hotspot).
>> 2. Proxies creation of the impl specific subsystem v
On Mon, 23 Nov 2020 15:46:56 GMT, Severin Gehwolf wrote:
> This is an enhancement which solves two issues:
>
> 1. Multiple reads of relevant cgroup interface files. Now interface files are
> only read once per file (just like Hotspot).
> 2. Proxies creation of the impl specific subsystem via `d
On Mon, 23 Nov 2020 15:46:56 GMT, Severin Gehwolf wrote:
> This is an enhancement which solves two issues:
>
> 1. Multiple reads of relevant cgroup interface files. Now interface files are
> only read once per file (just like Hotspot).
> 2. Proxies creation of the impl specific subsystem via `d
This is an enhancement which solves two issues:
1. Multiple reads of relevant cgroup interface files. Now interface files are
only read once per file (just like Hotspot).
2. Proxies creation of the impl specific subsystem via `determineType()` as
before, but now reads all relevant interface file
26 matches
Mail list logo
