On Mon, 21 Dec 2020 15:34:16 GMT, Roger Riggs wrote:
>> Jie Fu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Ignore OOME for testOOME
>> - Revert the change
>
> Completely ignoring the exception will leave no trace that the test
On Sat, 19 Dec 2020 09:45:09 GMT, Jie Fu wrote:
>> Hi all,
>>
>> java/util/HexFormat/HexFormatTest.java fails on x86_32 due to '-Xmx4G'.
>> The reason is that -Xmx4G is invalid maximum heap size for 32-bit platforms.
>> The current implementation only supports maximum 3800M on 32-bit systems
On Thu, 17 Dec 2020 16:14:56 GMT, Roger Riggs wrote:
> Disabling all of the tests on 32 bit is not a good idea.
>
> Instead the HexFormatTest.testOOME test should be skipped or the OOME should
> be ignored.
> Checking Runtime.getRuntime().maxMemory() should provide enough info to skip
> it.
> Hi all,
>
> java/util/HexFormat/HexFormatTest.java fails on x86_32 due to '-Xmx4G'.
> The reason is that -Xmx4G is invalid maximum heap size for 32-bit platforms.
> The current implementation only supports maximum 3800M on 32-bit systems [1].
>
> I've tried to reduce the -Xmx size, but it
