On Wed, 5 May 2021 16:03:17 GMT, Alan Bateman wrote:
>> Yes, I plan to look at this. It would also be good to have a couple of
>> additional reviews as well :-)
>
> I think using the positional read on the underlying FileChannel is okay. I'm
> puzzled by the previous code as I would have
On Wed, 5 May 2021 15:49:00 GMT, Lance Andersen wrote:
>> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 2223:
>>
>>> 2221: synchronized (zfch) {
>>> : n = zfch.position(pos).read(bb);
>>> 2223: }
>>
>> @LanceAndersen
On Tue, 4 May 2021 14:10:52 GMT, Alan Bateman wrote:
>> Jason Zaugg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use pattern matching instanceof
>
> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 2223:
>
>> 2221:
> If the given Path represents a file, use the overload of read defined
> in FileChannel that accepts an explicit position and avoid serializing
> reads.
>
> Note: The underlying NIO implementation is not required to implement
> FileChannel.read(ByteBuffer, long) concurrently; Windows still
