Re: RFR: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories [v2]

2021-11-25 Thread Jaikiran Pai
On 26/11/21 7:32 am, Mandy Chung wrote: On Thu, 25 Nov 2021 02:22:20 GMT, Jaikiran Pai wrote: Mandy Chung has updated the pull request incrementally with one additional commit since the last revision: minor fix to avoid casting Hello Mandy, one small issue - `ClassFileReader`,

Re: RFR: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories [v2]

2021-11-25 Thread Mandy Chung
On Thu, 25 Nov 2021 02:22:20 GMT, Jaikiran Pai wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> minor fix to avoid casting > > Hello Mandy, one small issue - `ClassFileReader`, `DependencyFinder` and >

Re: RFR: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories [v2]

2021-11-24 Thread Jaikiran Pai
On Wed, 24 Nov 2021 17:06:41 GMT, Mandy Chung wrote: >> jdeps intends to report an error if there are multiple versions of the same >> class being parsed. module-info.class should be excluded from such >> detection. >> >> This patch also fixes a data race in `VersionHelper::set` and also

Re: RFR: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories [v2]

2021-11-24 Thread Alan Bateman
On Wed, 24 Nov 2021 17:06:41 GMT, Mandy Chung wrote: >> jdeps intends to report an error if there are multiple versions of the same >> class being parsed. module-info.class should be excluded from such >> detection. >> >> This patch also fixes a data race in `VersionHelper::set` and also

Re: RFR: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories [v2]

2021-11-24 Thread Mandy Chung
> jdeps intends to report an error if there are multiple versions of the same > class being parsed. module-info.class should be excluded from such > detection. > > This patch also fixes a data race in `VersionHelper::set` and also unwraps > the `ExecutionException` when FutureTask of parsing

Re: RFR: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories [v2]

2021-11-24 Thread Mandy Chung
On Wed, 24 Nov 2021 10:05:11 GMT, Alan Bateman wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> minor fix to avoid casting > > src/jdk.jdeps/share/classes/com/sun/tools/jdeps/DependencyFinder.java line > 277: > >>