Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-12-07 Thread Aleksey Shipilev
On Tue, 30 Nov 2021 18:48:15 GMT, Aleksey Shipilev wrote: > OpenJDK tiered tests definitions have the catch-all `tier4` that runs all > tests not defined in the lower tiers. `hotspot:tier4` has lots of them, > mostly long-running vmTestbase tests, which take many hours even on a very >

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-12-06 Thread Aleksey Shipilev
On Tue, 30 Nov 2021 18:48:15 GMT, Aleksey Shipilev wrote: > OpenJDK tiered tests definitions have the catch-all `tier4` that runs all > tests not defined in the lower tiers. `hotspot:tier4` has lots of them, > mostly long-running vmTestbase tests, which take many hours even on a very >

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-12-06 Thread Alan Bateman
On Tue, 30 Nov 2021 18:48:15 GMT, Aleksey Shipilev wrote: > OpenJDK tiered tests definitions have the catch-all `tier4` that runs all > tests not defined in the lower tiers. `hotspot:tier4` has lots of them, > mostly long-running vmTestbase tests, which take many hours even on a very >

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-12-06 Thread David Holmes
On Mon, 6 Dec 2021 09:11:07 GMT, Aleksey Shipilev wrote: >>> I've solicited feedback from core-libs folk as this affects them the most. >>> At present we, Oracle, run the jdk_svc tests as part of hotspot testing, >>> but this change will suddenly cause jdk testing to include them. That is >>>

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-12-06 Thread Aleksey Shipilev
On Fri, 3 Dec 2021 07:34:16 GMT, Alan Bateman wrote: > No objection to the change, I think it is just a re-balancing of tiers for CI > systems. Yes, quite. @dholmes-ora, are you happy with Alan's assessment? - PR: https://git.openjdk.java.net/jdk/pull/6619

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-12-03 Thread Alan Bateman
On Thu, 2 Dec 2021 12:15:51 GMT, David Holmes wrote: > I've solicited feedback from core-libs folk as this affects them the most. At > present we, Oracle, run the jdk_svc tests as part of hotspot testing, but > this change will suddenly cause jdk testing to include them. That is probably >

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-12-02 Thread Aleksey Shipilev
On Thu, 2 Dec 2021 12:15:51 GMT, David Holmes wrote: > I've solicited feedback from core-libs folk as this affects them the most. At > present we, Oracle, run the jdk_svc tests as part of hotspot testing, but > this change will suddenly cause jdk testing to include them. That is probably >

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-12-02 Thread David Holmes
On 2/12/2021 6:25 pm, Aleksey Shipilev wrote: On Tue, 30 Nov 2021 18:48:15 GMT, Aleksey Shipilev wrote: All right then. Thanks for followups! Hi Aleksey, I've solicited feedback from core-libs folk as this affects them the most. At present we, Oracle, run the jdk_svc tests as part of

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-12-02 Thread Erik Gahlin
On Thu, 2 Dec 2021 08:21:30 GMT, Aleksey Shipilev wrote: > All right then. Thanks for followups! > > @egahlin, @mgronlun: this affects JFR tests a bit, subsumes `jfr_tier_3` into > `tier3`, basically. Are you good with this? Seems reasonable. I'm reluctant to become (R)eviewer on this, since

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-12-02 Thread Aleksey Shipilev
On Tue, 30 Nov 2021 18:48:15 GMT, Aleksey Shipilev wrote: > OpenJDK tiered tests definitions have the catch-all `tier4` that runs all > tests not defined in the lower tiers. `hotspot:tier4` has lots of them, > mostly long-running vmTestbase tests, which take many hours even on a very >

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-12-01 Thread David Holmes
On Thu, 2 Dec 2021 02:00:11 GMT, Mikhailo Seledtsov wrote: >> Hi @shipilev , >> We need to have someone look at the impact of this on our CI. I don't think >> we run the tier4 group as defined in our tier 4 so we may not see those >> execution time savings that offset the extra cost to tier3.

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-12-01 Thread Mikhailo Seledtsov
On Wed, 1 Dec 2021 02:29:14 GMT, David Holmes wrote: >> OpenJDK tiered tests definitions have the catch-all `tier4` that runs all >> tests not defined in the lower tiers. `hotspot:tier4` has lots of them, >> mostly long-running vmTestbase tests, which take many hours even on a very >>

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-12-01 Thread Mikhailo Seledtsov
On Tue, 30 Nov 2021 18:48:15 GMT, Aleksey Shipilev wrote: > OpenJDK tiered tests definitions have the catch-all `tier4` that runs all > tests not defined in the lower tiers. `hotspot:tier4` has lots of them, > mostly long-running vmTestbase tests, which take many hours even on a very >

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-12-01 Thread Aleksey Shipilev
On Wed, 1 Dec 2021 02:29:14 GMT, David Holmes wrote: > Hi @shipilev , We need to have someone look at the impact of this on our CI. > I don't think we run the tier4 group as defined in our tier 4 so we may not > see those execution time savings that offset the extra cost to tier3. OK, I can

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-11-30 Thread David Holmes
On Tue, 30 Nov 2021 18:48:15 GMT, Aleksey Shipilev wrote: > OpenJDK tiered tests definitions have the catch-all `tier4` that runs all > tests not defined in the lower tiers. `hotspot:tier4` has lots of them, > mostly long-running vmTestbase tests, which take many hours even on a very >

RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-11-30 Thread Aleksey Shipilev
OpenJDK tiered tests definitions have the catch-all `tier4` that runs all tests not defined in the lower tiers. `hotspot:tier4` has lots of them, mostly long-running vmTestbase tests, which take many hours even on a very parallel machines. This, unfortunately, has a chilling effect on