Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v6]

2022-02-25 Thread Alexey Semenyuk
On Fri, 25 Feb 2022 01:27:52 GMT, Alexander Matveev wrote: >> Added ability to override description for additional launchers via >> "description" property. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8279995:

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v4]

2022-02-24 Thread Alexander Matveev
On Thu, 17 Feb 2022 17:53:57 GMT, Alexey Semenyuk wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8279995: jpackage --add-launcher option should allow overriding >> description [v4] > >

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v6]

2022-02-24 Thread Alexander Matveev
> Added ability to override description for additional launchers via > "description" property. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8279995: jpackage --add-launcher option should allow overriding description [v5]

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v4]

2022-02-23 Thread Alexey Semenyuk
On Thu, 17 Feb 2022 06:54:33 GMT, Alexander Matveev wrote: >> Added ability to override description for additional launchers via >> "description" property. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8279995:

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v3]

2022-02-17 Thread Alexander Matveev
On Tue, 15 Feb 2022 15:48:02 GMT, Alexey Semenyuk wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8279995: jpackage --add-launcher option should allow overriding >> description [v3] > >

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v5]

2022-02-17 Thread Alexander Matveev
> Added ability to override description for additional launchers via > "description" property. Alexander Matveev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge master - 8279995: jpackage --add-launcher

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v4]

2022-02-16 Thread Alexander Matveev
> Added ability to override description for additional launchers via > "description" property. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8279995: jpackage --add-launcher option should allow overriding description [v4]

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v3]

2022-02-15 Thread Alexey Semenyuk
On Mon, 14 Feb 2022 23:56:43 GMT, Alexander Matveev wrote: >> Added ability to override description for additional launchers via >> "description" property. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8279995:

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v3]

2022-02-15 Thread Alexey Semenyuk
On Mon, 14 Feb 2022 23:56:43 GMT, Alexander Matveev wrote: >> Added ability to override description for additional launchers via >> "description" property. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8279995:

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v2]

2022-02-14 Thread Alexander Matveev
On Fri, 11 Feb 2022 22:11:44 GMT, Alexey Semenyuk wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8279995: jpackage --add-launcher option should allow overriding >> description [v2] > >

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v3]

2022-02-14 Thread Alexander Matveev
> Added ability to override description for additional launchers via > "description" property. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8279995: jpackage --add-launcher option should allow overriding description [v3]

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v2]

2022-02-11 Thread Alexey Semenyuk
On Fri, 11 Feb 2022 21:22:44 GMT, Alexander Matveev wrote: >> Added ability to override description for additional launchers via >> "description" property. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8279995:

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description

2022-02-11 Thread Alexander Matveev
On Wed, 9 Feb 2022 07:37:42 GMT, Alexander Matveev wrote: > Added ability to override description for additional launchers via > "description" property. Added automated tests for .exe files in Windows and .desktop files on Linux. - PR: https://git.openjdk.java.net/jdk/pull/7399

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v2]

2022-02-11 Thread Alexander Matveev
> Added ability to override description for additional launchers via > "description" property. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8279995: jpackage --add-launcher option should allow overriding description [v2]

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description

2022-02-09 Thread Alexey Semenyuk
On Wed, 9 Feb 2022 07:37:42 GMT, Alexander Matveev wrote: > Added ability to override description for additional launchers via > "description" property. Unfortunately, manual testing adds zero value to automated test runs. This feature can be covered with automated tests so it should be.

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description

2022-02-09 Thread Alexey Semenyuk
On Wed, 9 Feb 2022 18:53:35 GMT, Alexander Matveev wrote: >> test/jdk/tools/jpackage/share/AddLauncherTest.java line 93: >> >>> 91: new AdditionalLauncher("Baz2") >>> 92: .setDefaultArguments() >>> 93: .addRawProperties(Map.entry("description", "Baz2 >>>

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description

2022-02-09 Thread Alexander Matveev
On Wed, 9 Feb 2022 07:37:42 GMT, Alexander Matveev wrote: > Added ability to override description for additional launchers via > "description" property. AddLauncherArguments.java class reads parameters for additional launcher from property file and if this class contains particular property

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description

2022-02-09 Thread Alexander Matveev
On Wed, 9 Feb 2022 12:35:59 GMT, Alexey Semenyuk wrote: >> Added ability to override description for additional launchers via >> "description" property. > > test/jdk/tools/jpackage/share/AddLauncherTest.java line 93: > >> 91: new AdditionalLauncher("Baz2") >> 92:

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description

2022-02-09 Thread Kevin Rushforth
On Wed, 9 Feb 2022 07:37:42 GMT, Alexander Matveev wrote: > Added ability to override description for additional launchers via > "description" property. This will need a CSR. - PR: https://git.openjdk.java.net/jdk/pull/7399

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description

2022-02-09 Thread Alexey Semenyuk
On Wed, 9 Feb 2022 07:37:42 GMT, Alexander Matveev wrote: > Added ability to override description for additional launchers via > "description" property. I don't quite understand how these changes affect the description of launcher executables on Windows. I'd expect changes at least in

RFR: 8279995: jpackage --add-launcher option should allow overriding description

2022-02-08 Thread Alexander Matveev
Added ability to override description for additional launchers via "description" property. - Commit messages: - 8279995: jpackage --add-launcher option should allow overriding description Changes: https://git.openjdk.java.net/jdk/pull/7399/files Webrev: