Re: RFR: 8281317: CompactNumberFormat displays 4-digit values when rounding to a new range [v2]

2022-02-17 Thread Naoto Sato
On Thu, 17 Feb 2022 07:32:36 GMT, Selikoff wrote: > Can I please be added as a Reviewer? I was the one who originally reported > this bug on 2/7/2022 via Oracle's web form. To be listed as a Reviewer, you will need to be a Reviewer of the JDK Project (https://openjdk.java.net/bylaws#reviewer).

Re: RFR: 8281317: CompactNumberFormat displays 4-digit values when rounding to a new range [v2]

2022-02-17 Thread Selikoff
On Tue, 15 Feb 2022 22:31:47 GMT, Naoto Sato wrote: >> Fixing an issue in `CompactNumberFormat` which was caused by >> BigDecimal.divide() that incremented the number in the resulting format >> string. Also fixing some typos by taking this opportunity. > > Naoto Sato has updated the pull reques

Re: RFR: 8281317: CompactNumberFormat displays 4-digit values when rounding to a new range [v2]

2022-02-15 Thread Joe Wang
On Tue, 15 Feb 2022 22:31:28 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/text/CompactNumberFormat.java line 595: >> >>> 593: divisor = (Long) divisors.get(++compactDataIndex); >>> 594: iPart = getIntegerPart(number, divisor); >>> 595: }

Re: RFR: 8281317: CompactNumberFormat displays 4-digit values when rounding to a new range [v2]

2022-02-15 Thread Joe Wang
On Tue, 15 Feb 2022 22:31:47 GMT, Naoto Sato wrote: >> Fixing an issue in `CompactNumberFormat` which was caused by >> BigDecimal.divide() that incremented the number in the resulting format >> string. Also fixing some typos by taking this opportunity. > > Naoto Sato has updated the pull reques

Re: RFR: 8281317: CompactNumberFormat displays 4-digit values when rounding to a new range [v2]

2022-02-15 Thread Naoto Sato
On Tue, 15 Feb 2022 21:59:42 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressing review comments > > src/java.base/share/classes/java/text/CompactNumberFormat.java line 595: > >> 593:

Re: RFR: 8281317: CompactNumberFormat displays 4-digit values when rounding to a new range [v2]

2022-02-15 Thread Naoto Sato
> Fixing an issue in `CompactNumberFormat` which was caused by > BigDecimal.divide() that incremented the number in the resulting format > string. Also fixing some typos by taking this opportunity. Naoto Sato has updated the pull request incrementally with one additional commit since the last r

Re: RFR: 8281317: CompactNumberFormat displays 4-digit values when rounding to a new range

2022-02-15 Thread Joe Wang
On Wed, 9 Feb 2022 22:37:45 GMT, Naoto Sato wrote: > Fixing an issue in `CompactNumberFormat` which was caused by > BigDecimal.divide() that incremented the number in the resulting format > string. Also fixing some typos by taking this opportunity. Marked as reviewed by joehw (Reviewer). test

Re: RFR: 8281317: CompactNumberFormat displays 4-digit values when rounding to a new range

2022-02-15 Thread Joe Wang
On Wed, 9 Feb 2022 22:37:45 GMT, Naoto Sato wrote: > Fixing an issue in `CompactNumberFormat` which was caused by > BigDecimal.divide() that incremented the number in the resulting format > string. Also fixing some typos by taking this opportunity. src/java.base/share/classes/java/text/Compact

RFR: 8281317: CompactNumberFormat displays 4-digit values when rounding to a new range

2022-02-14 Thread Naoto Sato
Fixing an issue in `CompactNumberFormat` which was caused by BigDecimal.divide() that incremented the number in the resulting format string. Also fixing some typos by taking this opportunity. - Commit messages: - 8281317: CompactNumberFormat displays 4-digit values when rounding to