Re: RFR: 8285838: DST not applying properly with zone id offset set with TZ env variable [v6]

2022-06-07 Thread openjdk-notifier[bot]
On Tue, 7 Jun 2022 14:11:57 GMT, Gaurav Chaudhari wrote: >> Gaurav Chaudhari has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8285838: Cleanup of trailing whitespace >> - 8285838: Corrected month comparison check for TZ DST > >

Re: RFR: 8285838: DST not applying properly with zone id offset set with TZ env variable [v6]

2022-06-07 Thread Gaurav Chaudhari
On Wed, 1 Jun 2022 13:32:36 GMT, Gaurav Chaudhari wrote: >> This fix ensures that when a lookup for a custom TZ code fails, and an >> attempt is made to find the GMT offset in order to get the current time, >> Daylight savings rules are applied correctly. > > Gaurav Chaudhari has updated the

Re: RFR: 8285838: DST not applying properly with zone id offset set with TZ env variable [v6]

2022-06-02 Thread Naoto Sato
On Thu, 2 Jun 2022 18:14:55 GMT, Gaurav Chaudhari wrote: > Is the suggestion here to substitute the setting of the TZ environment > variable, and simply getting a date based off this `SimpleTimeZone` , so as > to bypass the process creation and just have it as a more simpler test? No. The

Re: RFR: 8285838: DST not applying properly with zone id offset set with TZ env variable [v6]

2022-06-02 Thread Gaurav Chaudhari
On Thu, 2 Jun 2022 18:07:39 GMT, Naoto Sato wrote: >> Gaurav Chaudhari has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8285838: Cleanup of trailing whitespace >> - 8285838: Corrected month comparison check for TZ DST > > I tried

Re: RFR: 8285838: DST not applying properly with zone id offset set with TZ env variable [v6]

2022-06-02 Thread Naoto Sato
On Wed, 1 Jun 2022 13:32:36 GMT, Gaurav Chaudhari wrote: >> This fix ensures that when a lookup for a custom TZ code fails, and an >> attempt is made to find the GMT offset in order to get the current time, >> Daylight savings rules are applied correctly. > > Gaurav Chaudhari has updated the

Re: RFR: 8285838: DST not applying properly with zone id offset set with TZ env variable [v6]

2022-06-01 Thread Naoto Sato
On Wed, 1 Jun 2022 13:32:36 GMT, Gaurav Chaudhari wrote: >> This fix ensures that when a lookup for a custom TZ code fails, and an >> attempt is made to find the GMT offset in order to get the current time, >> Daylight savings rules are applied correctly. > > Gaurav Chaudhari has updated the

Re: RFR: 8285838: DST not applying properly with zone id offset set with TZ env variable [v6]

2022-06-01 Thread Gaurav Chaudhari
> This fix ensures that when a lookup for a custom TZ code fails, and an > attempt is made to find the GMT offset in order to get the current time, > Daylight savings rules are applied correctly. Gaurav Chaudhari has updated the pull request incrementally with two additional commits since the