looks good
/Andy
On 6/28/2019 10:03 PM, Alexander Matveev wrote:
Hi,
http://cr.openjdk.java.net/~almatvee/8224486/webrev.01/
- Original fix was missing (not sure why) setting Java options map
flag to allow duplicates. Without it fix does not work. See
OrderedMap.h line 92 and 261 and Packa
Hi,
http://cr.openjdk.java.net/~almatvee/8224486/webrev.01/
- Original fix was missing (not sure why) setting Java options map flag
to allow duplicates. Without it fix does not work. See OrderedMap.h line
92 and 261 and Package.cpp.
- Old loop is kept to avoid possible regression in case if we
then I'm fine with original fix.
/Andy
On 6/25/2019 6:08 PM, Alexander Matveev wrote:
Hi Alexey,
I cannot use index to get items from map. At least I did not figure it
out how to do this. We need to use iterator when getting values from map.
Thanks,
Alexander
On 6/25/2019 4:52 AM, Alexey
Hi Alexey,
I cannot use index to get items from map. At least I did not figure it
out how to do this. We need to use iterator when getting values from map.
Thanks,
Alexander
On 6/25/2019 4:52 AM, Alexey Semenyuk wrote:
In
http://cr.openjdk.java.net/~almatvee/8224486/webrev.00/src/jdk.jpackag
I'm fine with this either way.
The ini file will have GetAllowDuplicates() true, but any OrderedMap
that doesn't will have count of 1.
/Andy
On 6/25/2019 7:52 AM, Alexey Semenyuk wrote:
In
http://cr.openjdk.java.net/~almatvee/8224486/webrev.00/src/jdk.jpackage/share/native/libapplauncher/Ja
In
http://cr.openjdk.java.net/~almatvee/8224486/webrev.00/src/jdk.jpackage/share/native/libapplauncher/JavaVirtualMachine.cpp.sdiff.html,
JavaOptions::AppendValues(), why do we need branching based on the
result of Values.GetAllowDuplicates()? Why can't we use the same logic
that was introduced
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Duplicated Java options were not read correctly from OrderedMap,
instead we read only unique from map. Fixed by reading duplicated Java
options.
[
